diff mbox series

[v6,4/5] dt-bindings: iio: light: Avago APDS9306

Message ID 20240206130017.7839-5-subhajit.ghosh@tweaklogic.com
State New
Headers
Series Support for Avago APDS9306 Ambient Light Sensor |

Commit Message

Subhajit Ghosh Feb. 6, 2024, 1 p.m. UTC 
  Driver support for Avago (Broadcom) APDS9306 Ambient Light Sensor.
Extend avago,apds9300.yaml schema file to support apds9306 device.

this patch depends on patch:
"dt-bindings: iio: light: adps9300: Update interrupt definitions"

Signed-off-by: Subhajit Ghosh <subhajit.ghosh@tweaklogic.com>
---
v5 -> v6:
 - Write proper commit messages
 - Add vdd-supply in a separate commit
 - Add Interrupt macro in a separate commit
   Link: https://lore.kernel.org/all/1d0a80a6-dba5-4db8-a7a8-73d4ffe7a37e@linaro.org/
   
v2 -> v5:
 - Removed 'required' for Interrupts and 'oneOf' for compatibility strings
   as per below reviews:
   Link: https://lore.kernel.org/lkml/20231028142944.7e210eb6@jic23-huawei/
   Link: https://lore.kernel.org/lkml/22e9e5e9-d26a-46e9-8986-5062bbfd72ec@linaro.org/
---
 Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Krzysztof Kozlowski Feb. 8, 2024, 8:18 a.m. UTC | #1 
On 06/02/2024 14:00, Subhajit Ghosh wrote:
> Driver support for Avago (Broadcom) APDS9306 Ambient Light Sensor.
> Extend avago,apds9300.yaml schema file to support apds9306 device.
> 
> this patch depends on patch:
> "dt-bindings: iio: light: adps9300: Update interrupt definitions"

Drop the paragraph, not helping. There is no dependency here.

Best regards,
Krzysztof
Subhajit Ghosh Feb. 8, 2024, 10:51 a.m. UTC | #2 
Hi Krzysztof,

On 8/2/24 18:48, Krzysztof Kozlowski wrote:
> On 06/02/2024 14:00, Subhajit Ghosh wrote:
>> Driver support for Avago (Broadcom) APDS9306 Ambient Light Sensor.
>> Extend avago,apds9300.yaml schema file to support apds9306 device.
>>
>> this patch depends on patch:
>> "dt-bindings: iio: light: adps9300: Update interrupt definitions"
> 
> Drop the paragraph, not helping. There is no dependency here.
In the submitting patches guide, I read that if one patch depends
on another, it should be mentioned.
If I try to apply this patch with "git am", it fails without
first applying the patch dependency mentioned above. Is that fine?
Again, sorry about the silly questions, just don't want to assume stuff!
> 
> Best regards,
> Krzysztof
> 
Thank you for reviewing.
Regards,
Subhajit Ghosh
Conor Dooley Feb. 8, 2024, 6:52 p.m. UTC | #3 
On Thu, Feb 08, 2024 at 09:21:17PM +1030, Subhajit Ghosh wrote:
> Hi Krzysztof,
> 
> On 8/2/24 18:48, Krzysztof Kozlowski wrote:
> > On 06/02/2024 14:00, Subhajit Ghosh wrote:
> > > Driver support for Avago (Broadcom) APDS9306 Ambient Light Sensor.
> > > Extend avago,apds9300.yaml schema file to support apds9306 device.
> > > 
> > > this patch depends on patch:
> > > "dt-bindings: iio: light: adps9300: Update interrupt definitions"
> > 
> > Drop the paragraph, not helping. There is no dependency here.
> In the submitting patches guide, I read that if one patch depends
> on another, it should be mentioned.
> If I try to apply this patch with "git am", it fails without
> first applying the patch dependency mentioned above. Is that fine?
> Again, sorry about the silly questions, just don't want to assume stuff!

It's another patch in the same series, I don't think you should bother
mentioning this at all. If there's a dependency on another series, then
you should mention it under the --- line.

Cheers,
Conor.
Krzysztof Kozlowski Feb. 9, 2024, 7:34 a.m. UTC | #4 
On 08/02/2024 11:51, Subhajit Ghosh wrote:
> Hi Krzysztof,
> 
> On 8/2/24 18:48, Krzysztof Kozlowski wrote:
>> On 06/02/2024 14:00, Subhajit Ghosh wrote:
>>> Driver support for Avago (Broadcom) APDS9306 Ambient Light Sensor.
>>> Extend avago,apds9300.yaml schema file to support apds9306 device.
>>>
>>> this patch depends on patch:
>>> "dt-bindings: iio: light: adps9300: Update interrupt definitions"
>>
>> Drop the paragraph, not helping. There is no dependency here.
> In the submitting patches guide, I read that if one patch depends
> on another, it should be mentioned.

On another patchset! Not on other patch within patchset. Anyway,
submitting patches don't tell to store it in Git forever because it does
not make sense.

Third, there is no dependency.

> If I try to apply this patch with "git am", it fails without
> first applying the patch dependency mentioned above. Is that fine?

It's just context.




Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml b/Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml
index e07a074f6acf..b750096530bc 100644
--- a/Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml
+++ b/Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml
@@ -12,11 +12,13 @@  maintainers:
 description: |
   Datasheet: https://www.avagotech.com/docs/AV02-1077EN
   Datasheet: https://www.avagotech.com/docs/AV02-4191EN
+  Datasheet: https://www.avagotech.com/docs/AV02-4755EN
 
 properties:
   compatible:
     enum:
       - avago,apds9300
+      - avago,apds9306
       - avago,apds9960
 
   reg: