diff mbox series

[v6.6,51/57] eventfs: Remove unused d_parent pointer field

Message ID	20240206120954.681339731@rostedt.homelinux.com
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel+bounces-54925-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Message-ID: <20240206120954.681339731@rostedt.homelinux.com> User-Agent: quilt/0.67 Date: Tue, 06 Feb 2024 07:09:56 -0500 From: Steven Rostedt <rostedt@goodmis.org> To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Linus Torvalds <torvalds@linux-foundation.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sasha Levin <sashal@kernel.org>, Masami Hiramatsu <mhiramat@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Mathieu Desnoyers <mathieu.desnoyers@efficios.com>, Christian Brauner <brauner@kernel.org>, Al Viro <viro@ZenIV.linux.org.uk>, Ajay Kaher <ajay.kaher@broadcom.com> Subject: [v6.6][PATCH 51/57] eventfs: Remove unused d_parent pointer field References: <20240206120905.570408983@rostedt.homelinux.com> Precedence: bulk MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX
Series	eventfs: Linus's updates for 6.6 \| [v6.6,00/57] eventfs: Linus's updates for 6.6 [v6.6,05/57] Revert "eventfs: Save ownership and mode" [v6.6,07/57] eventfs: Remove eventfs_file and just use eventfs_inode [v6.6,08/57] eventfs: Use eventfs_remove_events_dir() [v6.6,09/57] eventfs: Use ERR_CAST() in eventfs_create_events_dir() [v6.6,10/57] eventfs: Fix failure path in eventfs_create_events_dir() [v6.6,11/57] tracefs/eventfs: Modify mismatched function name [v6.6,12/57] eventfs: Fix WARN_ON() in create_file_dentry() [v6.6,13/57] eventfs: Fix typo in eventfs_inode union comment [v6.6,14/57] eventfs: Remove extra dget() in eventfs_create_events_dir() [v6.6,16/57] eventfs: Remove "is_freed" union with rcu head [v6.6,17/57] eventfs: Have a free_ei() that just frees the eventfs_inode [v6.6,18/57] eventfs: Test for ei->is_freed when accessing ei->dentry [v6.6,19/57] eventfs: Save ownership and mode [v6.6,20/57] eventfs: Hold eventfs_mutex when calling callback functions [v6.6,21/57] eventfs: Delete eventfs_inode when the last dentry is freed [v6.6,22/57] eventfs: Remove special processing of dput() of events directory [v6.6,23/57] eventfs: Use simple_recursive_removal() to clean up dentries [v6.6,24/57] eventfs: Remove expectation that ei->is_freed means ei->dentry == NULL [v6.6,25/57] eventfs: Do not invalidate dentry in create_file/dir_dentry() [v6.6,26/57] eventfs: Use GFP_NOFS for allocation when eventfs_mutex is held [v6.6,27/57] eventfs: Move taking of inode_lock into dcache_dir_open_wrapper() [v6.6,28/57] eventfs: Do not allow NULL parent to eventfs_start_creating() [v6.6,29/57] eventfs: Make sure that parent->d_inode is locked in creating files/dirs [v6.6,30/57] eventfs: Fix events beyond NAME_MAX blocking tasks [v6.6,31/57] eventfs: Have event files and directories default to parent uid and gid [v6.6,32/57] eventfs: Fix file and directory uid and gid ownership [v6.6,33/57] tracefs: Check for dentry->d_inode exists in set_gid() [v6.6,34/57] eventfs: Fix bitwise fields for "is_events" [v6.6,35/57] eventfs: Remove "lookup" parameter from create_dir/file_dentry() [v6.6,36/57] eventfs: Stop using dcache_readdir() for getdents() [v6.6,37/57] tracefs/eventfs: Use root and instance inodes as default ownership [v6.6,38/57] eventfs: Have eventfs_iterate() stop immediately if ei->is_freed is set [v6.6,39/57] eventfs: Do ctx->pos update for all iterations in eventfs_iterate() [v6.6,40/57] eventfs: Read ei->entries before ei->children in eventfs_iterate() [v6.6,41/57] eventfs: Shortcut eventfs_iterate() by skipping entries already read [v6.6,42/57] eventfs: Have the inodes all for files and directories all be the same [v6.6,43/57] eventfs: Do not create dentries nor inodes in iterate_shared [v6.6,44/57] eventfs: Use kcalloc() instead of kzalloc() [v6.6,45/57] eventfs: Save directory inodes in the eventfs_inode structure [v6.6,46/57] tracefs: remove stale update_gid code [v6.6,47/57] tracefs: Zero out the tracefs_inode when allocating it [v6.6,48/57] eventfs: Initialize the tracefs inode properly [v6.6,49/57] tracefs: Avoid using the ei->dentry pointer unnecessarily [v6.6,50/57] tracefs: dentry lookup crapectomy [v6.6,51/57] eventfs: Remove unused d_parent pointer field [v6.6,52/57] eventfs: Clean up dentry ops and add revalidate function [v6.6,53/57] eventfs: Get rid of dentry pointers without refcounts [v6.6,54/57] eventfs: Warn if an eventfs_inode is freed without is_freed being set [v6.6,55/57] eventfs: Restructure eventfs_inode structure to be more condensed [v6.6,56/57] eventfs: Remove fsnotify*() functions from lookup() [v6.6,57/57] eventfs: Keep all directory links at 1

Commit Message

Steven Rostedt Feb. 6, 2024, 12:09 p.m. UTC

  From: Linus Torvalds <torvalds@linux-foundation.org>

It's never used

Link: https://lore.kernel.org/linux-trace-kernel/202401291043.e62e89dc-oliver.sang@intel.com/
Link: https://lore.kernel.org/linux-trace-kernel/20240131185512.961772428@goodmis.org

Cc: stable@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Christian Brauner <brauner@kernel.org>
Cc: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Ajay Kaher <ajay.kaher@broadcom.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fixes: c1504e510238 ("eventfs: Implement eventfs dir creation functions")
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
(cherry picked from commit 408600be78cdb8c650a97ecc7ff411cb216811b5)
---
 fs/tracefs/event_inode.c | 4 +---
 fs/tracefs/internal.h    | 2 --
 2 files changed, 1 insertion(+), 5 deletions(-)

diff mbox series

Patch

diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c
index 04c2ab90f93e..16ca8d9759b1 100644
--- a/fs/tracefs/event_inode.c
+++ b/fs/tracefs/event_inode.c
@@ -680,10 +680,8 @@  struct eventfs_inode *eventfs_create_dir(const char *name, struct eventfs_inode
 	INIT_LIST_HEAD(&ei->list);
 
 	mutex_lock(&eventfs_mutex);
-	if (!parent->is_freed) {
+	if (!parent->is_freed)
 		list_add_tail(&ei->list, &parent->children);
-		ei->d_parent = parent->dentry;
-	}
 	mutex_unlock(&eventfs_mutex);
 
 	/* Was the parent freed? */
diff --git a/fs/tracefs/internal.h b/fs/tracefs/internal.h
index 09037e2c173d..932733a2696a 100644
--- a/fs/tracefs/internal.h
+++ b/fs/tracefs/internal.h
@@ -36,7 +36,6 @@  struct eventfs_attr {
  * @name:	the name of the directory to create
  * @children:	link list into the child eventfs_inode
  * @dentry:     the dentry of the directory
- * @d_parent:   pointer to the parent's dentry
  * @d_children: The array of dentries to represent the files when created
  * @entry_attrs: Saved mode and ownership of the @d_children
  * @attr:	Saved mode and ownership of eventfs_inode itself
@@ -51,7 +50,6 @@  struct eventfs_inode {
 	const char			*name;
 	struct list_head		children;
 	struct dentry			*dentry; /* Check is_freed to access */
-	struct dentry			*d_parent;
 	struct dentry			**d_children;
 	struct eventfs_attr		*entry_attrs;
 	struct eventfs_attr		attr;