From patchwork Tue Feb 6 11:32:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 197350 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp1482660dyb; Tue, 6 Feb 2024 03:53:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IEYYTJciJfA+e1/4bWh4J8vMj+sQ2uMerBzQYrtqSxsY98wfRXR2G3k+VBF0tsF8oPhNomr X-Received: by 2002:a05:6808:f01:b0:3be:b86e:35d with SMTP id m1-20020a0568080f0100b003beb86e035dmr2611943oiw.12.1707220425853; Tue, 06 Feb 2024 03:53:45 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707220425; cv=pass; d=google.com; s=arc-20160816; b=he7QSCUeahx1Bn+07PwFo60Tb57O9X8buHByudB0Y9k0wx1CWGy40GQezpfyUfOjUm lpoA1WQv706Y2nyTeNVGPD9UaRaEckk6mWzEfzvBqX/PYfDNn0vxZnZKyWE//ntWsruA vqXOB+qrtMw8IgHb/WT7d0OCzZWnVxZYUQXrF3C2uaM4LQPSE9eqZIzgZVqLri3sWIpu KEuQ3eT2/TIXBGXhvEre/RmI/KOW+xqViaTWqe/kkzOlsR5+m+3uciA/qDxsLxj6CIjP PjIoLAi2AvwxWUpgl8y/l4RW+5LkooyicvaYTIxgJoCD3+1tuwRhra0cm5Z4CaMxzhiU Cnhg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:subject:cc:to:from:date:user-agent:message-id; bh=//znUvdDCjBcws5msj92W0S44vVgjzgRljeV2BJnUc4=; fh=ozfrZl2C32zY8sXewKj+d3iCwGLgxutsxD1ZuXez52M=; b=YW8LjGbWewNYEsbj6XK3LlPJRuxv3sspvDSS/xb7og3Y3sjN33Xl40x6Otfc+l4YZK 21Vv7EQ5jeLVh6qFXXJMW3kQ7W8Zh05sfc1UmVkdF3EBkoEnNCR34ewhjwyifCn3BQp6 sz+K21SVZ3AoaDqo37OCmRHY605XXqmLY2wKzIKqkjx4eqozl1258/zkcFK5HfAJZqCu N1AIXA4ayf9HS9YeyonVj+kKZna/CcAaG9oygB3RmE6a/EwDoycPfuy3I3wwUNuNO324 cZ9hxqTLZNDqTl3oTKwyZH6esLRlCb2E9QspTYIOAUNxi/l3p5HAu6fsDMBURK8Z/WOl r8dA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-54810-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54810-ouuuleilei=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=1; AJvYcCWb3Zj7Ve9yXZi8UDQGpk7k0V5/okMKT3D3/rwfE7kLSMRLcvBRkr5/uQEnuecCXfCw5kAc2Hf57fye84R7L1rWuWSACA== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id i24-20020a63e918000000b005cddfe0c82bsi1534721pgh.211.2024.02.06.03.53.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 03:53:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-54810-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-54810-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54810-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 968C9285E17 for ; Tue, 6 Feb 2024 11:53:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A1FC613A275; Tue, 6 Feb 2024 11:33:39 +0000 (UTC) Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B570C1350DE; Tue, 6 Feb 2024 11:33:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707219213; cv=none; b=b+E+gcksx227dnj8RHUFFW4aMTdgsYJAUmsGz0150id19T6DjANzlqY68aE6DmmWrb5aJPjygB9Uq8nfmqT/Co93PRFcZkMpvY4KTQv4ga4PM0i40Z0XqvJGH4BGEiVDVebkCYOMpKSkPeZf5uuo/JFkozDkOzoAd5F3PiUT8jk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707219213; c=relaxed/simple; bh=5yqaMUzsL24Xo1kXlS9YCQkGhNmG85TgGVOtLxrgq1g=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=IWQ5mga3cxQEFYWO/rTVDMlnwF1lA1vg+HgGfEnBzSPSTisx/QBVSTS52Kovr+HSI9Dx/xxb0JpIxGxosYegknJ9BK5x9pGIQ5Tlrol4CYLMoryguxMNUVbmVkcvTCdx8oxLCbl1JG6kC8UKbvgq5gymtujDOByRVnGhCdH3qr4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 633FCC43399; Tue, 6 Feb 2024 11:33:33 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.97) (envelope-from ) id 1rXJiD-00000006aRK-3LIc; Tue, 06 Feb 2024 06:34:01 -0500 Message-ID: <20240206113401.654906760@rostedt.homelinux.com> User-Agent: quilt/0.67 Date: Tue, 06 Feb 2024 06:32:20 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Linus Torvalds , Greg Kroah-Hartman , Sasha Levin , Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Christian Brauner , Al Viro , Ajay Kaher , Al Viro Subject: [v6.7][PATCH v2 22/23] eventfs: Remove fsnotify*() functions from lookup() References: <20240206113158.822006147@rostedt.homelinux.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790150365278772520 X-GMAIL-MSGID: 1790150365278772520 From: "Steven Rostedt (Google)" The dentries and inodes are created when referenced in the lookup code. There's no reason to call fsnotify_*() functions when they are created by a reference. It doesn't make any sense. Link: https://lore.kernel.org/linux-trace-kernel/20240201002719.GS2087318@ZenIV/ Link: https://lore.kernel.org/linux-trace-kernel/20240201161617.166973329@goodmis.org Cc: stable@vger.kernel.org Cc: Linus Torvalds Cc: Masami Hiramatsu Cc: Mark Rutland Cc: Mathieu Desnoyers Cc: Christian Brauner Cc: Al Viro Cc: Ajay Kaher Fixes: a376007917776 ("eventfs: Implement functions to create files and dirs when accessed"); Suggested-by: Al Viro Signed-off-by: Steven Rostedt (Google) (cherry picked from commit 12d823b31fadf47c8f36ecada7abac5f903cac33) --- fs/tracefs/event_inode.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c index ca7daee7c811..9e031e5a2713 100644 --- a/fs/tracefs/event_inode.c +++ b/fs/tracefs/event_inode.c @@ -366,7 +366,6 @@ static struct dentry *lookup_file(struct eventfs_inode *parent_ei, dentry->d_fsdata = get_ei(parent_ei); d_add(dentry, inode); - fsnotify_create(dentry->d_parent->d_inode, dentry); return NULL; }; @@ -408,7 +407,6 @@ static struct dentry *lookup_dir_entry(struct dentry *dentry, inc_nlink(inode); d_add(dentry, inode); inc_nlink(dentry->d_parent->d_inode); - fsnotify_mkdir(dentry->d_parent->d_inode, dentry); return NULL; }