From patchwork Tue Feb 6 11:32:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 197339 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp1481004dyb; Tue, 6 Feb 2024 03:49:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IEsEqBzV7RboRozoagGtVYYbhxh90m09+b869mcRBvK42qTzLGiB1QebC1IT5M1YYnPER3P X-Received: by 2002:a17:906:32da:b0:a35:3c1f:b29f with SMTP id k26-20020a17090632da00b00a353c1fb29fmr2288603ejk.5.1707220161757; Tue, 06 Feb 2024 03:49:21 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707220161; cv=pass; d=google.com; s=arc-20160816; b=gpFPpc5psMayKSLX58E1YzAKMFK/CZm00QG9GDO6Fqc/uHWEiW80PJrSkGJvEDgU2A TYlmu6/hGIvfPoNWhX7OP/G/n4U9IPdGLQMgeK8Os8spTuux6CB/WS0dofKsRdRTmwVe sPLkExFnYQYLJSxyDaRUYgCkACfBF7pL8LmESiM5GdVUpFkyVBDSv4vcKD0epCtJNp2Z v/ch9WwYvUKIdkBvILpuk51OcYDIGyjTifgMGZgxOLF0SMShODMY2XJFhsp73zgeRO6L ILk+qgH+3a7d4mXoMq9OVKnPF9GBNp0VJne+1Q3BS50ewo2HYYzvaGKL8y7A80EfFPrM 3pQw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:subject:cc:to:from:date:user-agent:message-id; bh=ez93nIj3r0KL5LhMXr8lgScygvkcsmAkg7g6211UaaY=; fh=qIgmGzPK2k9cCvD5p5Scv/I/U4TTnU6X0uN566hvy/Y=; b=J/wKo9k06Z77Q0KWWvpB7WdI1e4/Inf8Za2a3WMIybAoN2+Gj7ZcfpHLzLt34wHbhh G+rdiR18kcSrFJRMAClHoTLBte6YTezgmjSN6+3u+JVc3+M5kgMs29donYe+ogETZp10 0ptSuqRRa2iuw9sexCGN1ErWIbxn7jmTivErSBCf7JaaqpZMvyfWEWGWgGFwalY4Ez2M s5/ZwanBu0XGp2XBj+wc2rhlwJQcbQ4f54mZGHRf5zOxl3VX06Yid6XauJ6SUZU6Om6P cldfKN6HyuQsxv0miMai5InXDm0bwyLJnS4VrPKDE7msdfMzY3n7KMpveiPWPMRWGJkQ ZKoA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-54799-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54799-ouuuleilei=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=1; AJvYcCXxRnwGmZObjuU3ew+O5pZye2NWox0XEi1Sfz9pVpqgauyiWsrHaB69Y3/1bVS8teqbzVFr1ZxKLtMBnyiAtv17lhI3cA== Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id g19-20020a170906595300b00a3647d924ddsi954064ejr.79.2024.02.06.03.49.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 03:49:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-54799-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-54799-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54799-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 01F951F24E76 for ; Tue, 6 Feb 2024 11:49:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A40071369A9; Tue, 6 Feb 2024 11:33:36 +0000 (UTC) Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 734F3134747; Tue, 6 Feb 2024 11:33:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707219212; cv=none; b=eKC8slVqQratL83v4LPgSi3VU9YWjZL3/FbHA/9AoBOMAU2EheSZZM/3GwmpwHsQJcSdEh4a/r0WQkGun7e+eAnpsZErHRCFj7BT0VvBl22szAYv6n8yzJP37Rd/S18tRPT08uFx2uIJi4FfGdWBp9Q2kHh+jtRDecobkMnmTro= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707219212; c=relaxed/simple; bh=3cuwo8jKNFJ8ZNaRFdtkUgaWTecxRB1l6ECQ5pijtZI=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=SU0Q4xoQIxmhdVJp55/zreRVBoqnnJypBwuH4v4gzTUpnonPxqnSwR6Gya4JM6vfSBFTLXnkNtrzPejNd9NIEpy6EBf0KcbeIoWAbf6RWOwDOP8tzvaGkj8rsDuzW31019E5Djn+2Uw4C5F3Ei9+4FDfuufb+s5Z9BWECGnaKGo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5504C43399; Tue, 6 Feb 2024 11:33:31 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.97) (envelope-from ) id 1rXJiC-00000006aMK-0l4Q; Tue, 06 Feb 2024 06:34:00 -0500 Message-ID: <20240206113400.036997635@rostedt.homelinux.com> User-Agent: quilt/0.67 Date: Tue, 06 Feb 2024 06:32:10 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Linus Torvalds , Greg Kroah-Hartman , Sasha Levin , Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers Subject: [v6.7][PATCH v2 12/23] tracefs: remove stale update_gid code References: <20240206113158.822006147@rostedt.homelinux.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790150088400917437 X-GMAIL-MSGID: 1790150088400917437 From: Linus Torvalds The 'eventfs_update_gid()' function is no longer called, so remove it (and the helper function it uses). Link: https://lore.kernel.org/all/CAHk-=wj+DsZZ=2iTUkJ-Nojs9fjYMvPs1NuoM3yK7aTDtJfPYQ@mail.gmail.com/ Fixes: 8186fff7ab64 ("tracefs/eventfs: Use root and instance inodes as default ownership") Signed-off-by: Linus Torvalds Signed-off-by: Steven Rostedt (Google) (cherry picked from commit 29142dc92c37d3259a33aef15b03e6ee25b0d188) --- fs/tracefs/event_inode.c | 38 -------------------------------------- fs/tracefs/internal.h | 1 - 2 files changed, 39 deletions(-) diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c index 6b211522a13e..1c3dd0ad4660 100644 --- a/fs/tracefs/event_inode.c +++ b/fs/tracefs/event_inode.c @@ -281,44 +281,6 @@ static void update_inode_attr(struct dentry *dentry, struct inode *inode, inode->i_gid = attr->gid; } -static void update_gid(struct eventfs_inode *ei, kgid_t gid, int level) -{ - struct eventfs_inode *ei_child; - - /* at most we have events/system/event */ - if (WARN_ON_ONCE(level > 3)) - return; - - ei->attr.gid = gid; - - if (ei->entry_attrs) { - for (int i = 0; i < ei->nr_entries; i++) { - ei->entry_attrs[i].gid = gid; - } - } - - /* - * Only eventfs_inode with dentries are updated, make sure - * all eventfs_inodes are updated. If one of the children - * do not have a dentry, this function must traverse it. - */ - list_for_each_entry_srcu(ei_child, &ei->children, list, - srcu_read_lock_held(&eventfs_srcu)) { - if (!ei_child->dentry) - update_gid(ei_child, gid, level + 1); - } -} - -void eventfs_update_gid(struct dentry *dentry, kgid_t gid) -{ - struct eventfs_inode *ei = dentry->d_fsdata; - int idx; - - idx = srcu_read_lock(&eventfs_srcu); - update_gid(ei, gid, 0); - srcu_read_unlock(&eventfs_srcu, idx); -} - /** * create_file - create a file in the tracefs filesystem * @name: the name of the file to create. diff --git a/fs/tracefs/internal.h b/fs/tracefs/internal.h index 45397df9bb65..91c2bf0b91d9 100644 --- a/fs/tracefs/internal.h +++ b/fs/tracefs/internal.h @@ -82,7 +82,6 @@ struct inode *tracefs_get_inode(struct super_block *sb); struct dentry *eventfs_start_creating(const char *name, struct dentry *parent); struct dentry *eventfs_failed_creating(struct dentry *dentry); struct dentry *eventfs_end_creating(struct dentry *dentry); -void eventfs_update_gid(struct dentry *dentry, kgid_t gid); void eventfs_set_ei_status_free(struct tracefs_inode *ti, struct dentry *dentry); #endif /* _TRACEFS_INTERNAL_H */