diff mbox series

[v6.7,v2,12/23] tracefs: remove stale update_gid code

Message ID	20240206113400.036997635@rostedt.homelinux.com
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel+bounces-54799-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Message-ID: <20240206113400.036997635@rostedt.homelinux.com> User-Agent: quilt/0.67 Date: Tue, 06 Feb 2024 06:32:10 -0500 From: Steven Rostedt <rostedt@goodmis.org> To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Linus Torvalds <torvalds@linux-foundation.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sasha Levin <sashal@kernel.org>, Masami Hiramatsu <mhiramat@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Subject: [v6.7][PATCH v2 12/23] tracefs: remove stale update_gid code References: <20240206113158.822006147@rostedt.homelinux.com> Precedence: bulk MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX
Series	eventfs: Linus's updates for 6.7 \| [v6.7,v2,00/23] eventfs: Linus's updates for 6.7 [v6.7,v2,01/23] eventfs: Remove "lookup" parameter from create_dir/file_dentry() [v6.7,v2,02/23] eventfs: Stop using dcache_readdir() for getdents() [v6.7,v2,03/23] tracefs/eventfs: Use root and instance inodes as default ownership [v6.7,v2,04/23] eventfs: Have eventfs_iterate() stop immediately if ei->is_freed is set [v6.7,v2,05/23] eventfs: Do ctx->pos update for all iterations in eventfs_iterate() [v6.7,v2,06/23] eventfs: Read ei->entries before ei->children in eventfs_iterate() [v6.7,v2,07/23] eventfs: Shortcut eventfs_iterate() by skipping entries already read [v6.7,v2,08/23] eventfs: Have the inodes all for files and directories all be the same [v6.7,v2,09/23] eventfs: Do not create dentries nor inodes in iterate_shared [v6.7,v2,10/23] eventfs: Use kcalloc() instead of kzalloc() [v6.7,v2,11/23] eventfs: Save directory inodes in the eventfs_inode structure [v6.7,v2,12/23] tracefs: remove stale update_gid code [v6.7,v2,13/23] tracefs: Zero out the tracefs_inode when allocating it [v6.7,v2,14/23] eventfs: Initialize the tracefs inode properly [v6.7,v2,15/23] tracefs: Avoid using the ei->dentry pointer unnecessarily [v6.7,v2,16/23] tracefs: dentry lookup crapectomy [v6.7,v2,17/23] eventfs: Remove unused d_parent pointer field [v6.7,v2,18/23] eventfs: Clean up dentry ops and add revalidate function [v6.7,v2,19/23] eventfs: Get rid of dentry pointers without refcounts [v6.7,v2,20/23] eventfs: Warn if an eventfs_inode is freed without is_freed being set [v6.7,v2,21/23] eventfs: Restructure eventfs_inode structure to be more condensed [v6.7,v2,22/23] eventfs: Remove fsnotify*() functions from lookup() [v6.7,v2,23/23] eventfs: Keep all directory links at 1

Commit Message

Steven Rostedt Feb. 6, 2024, 11:32 a.m. UTC

  From: Linus Torvalds <torvalds@linux-foundation.org>

The 'eventfs_update_gid()' function is no longer called, so remove it
(and the helper function it uses).

Link: https://lore.kernel.org/all/CAHk-=wj+DsZZ=2iTUkJ-Nojs9fjYMvPs1NuoM3yK7aTDtJfPYQ@mail.gmail.com/

Fixes: 8186fff7ab64 ("tracefs/eventfs: Use root and instance inodes as default ownership")
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
(cherry picked from commit 29142dc92c37d3259a33aef15b03e6ee25b0d188)
---
 fs/tracefs/event_inode.c | 38 --------------------------------------
 fs/tracefs/internal.h    |  1 -
 2 files changed, 39 deletions(-)

diff mbox series

Patch

diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c
index 6b211522a13e..1c3dd0ad4660 100644
--- a/fs/tracefs/event_inode.c
+++ b/fs/tracefs/event_inode.c
@@ -281,44 +281,6 @@  static void update_inode_attr(struct dentry *dentry, struct inode *inode,
 		inode->i_gid = attr->gid;
 }
 
-static void update_gid(struct eventfs_inode *ei, kgid_t gid, int level)
-{
-	struct eventfs_inode *ei_child;
-
-	/* at most we have events/system/event */
-	if (WARN_ON_ONCE(level > 3))
-		return;
-
-	ei->attr.gid = gid;
-
-	if (ei->entry_attrs) {
-		for (int i = 0; i < ei->nr_entries; i++) {
-			ei->entry_attrs[i].gid = gid;
-		}
-	}
-
-	/*
-	 * Only eventfs_inode with dentries are updated, make sure
-	 * all eventfs_inodes are updated. If one of the children
-	 * do not have a dentry, this function must traverse it.
-	 */
-	list_for_each_entry_srcu(ei_child, &ei->children, list,
-				 srcu_read_lock_held(&eventfs_srcu)) {
-		if (!ei_child->dentry)
-			update_gid(ei_child, gid, level + 1);
-	}
-}
-
-void eventfs_update_gid(struct dentry *dentry, kgid_t gid)
-{
-	struct eventfs_inode *ei = dentry->d_fsdata;
-	int idx;
-
-	idx = srcu_read_lock(&eventfs_srcu);
-	update_gid(ei, gid, 0);
-	srcu_read_unlock(&eventfs_srcu, idx);
-}
-
 /**
  * create_file - create a file in the tracefs filesystem
  * @name: the name of the file to create.
diff --git a/fs/tracefs/internal.h b/fs/tracefs/internal.h
index 45397df9bb65..91c2bf0b91d9 100644
--- a/fs/tracefs/internal.h
+++ b/fs/tracefs/internal.h
@@ -82,7 +82,6 @@  struct inode *tracefs_get_inode(struct super_block *sb);
 struct dentry *eventfs_start_creating(const char *name, struct dentry *parent);
 struct dentry *eventfs_failed_creating(struct dentry *dentry);
 struct dentry *eventfs_end_creating(struct dentry *dentry);
-void eventfs_update_gid(struct dentry *dentry, kgid_t gid);
 void eventfs_set_ei_status_free(struct tracefs_inode *ti, struct dentry *dentry);
 
 #endif /* _TRACEFS_INTERNAL_H */