From patchwork Tue Feb 6 08:48:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Muhammad Usama Anjum X-Patchwork-Id: 197260 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp1406935dyb; Tue, 6 Feb 2024 00:56:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IEaHpzRI0VT6yNKA9mk8dSaKMtMDC8ImgBYj5qdjmGdr5Da6DOFSIlYmUWBE5v94OtzpEca X-Received: by 2002:a17:907:77d8:b0:a38:28c0:834a with SMTP id kz24-20020a17090777d800b00a3828c0834amr617915ejc.28.1707209774296; Tue, 06 Feb 2024 00:56:14 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707209774; cv=pass; d=google.com; s=arc-20160816; b=Vo7v78iO/Fy3BdPKF6GofsG8QaiH82TkkNCZlLsHgWOwAYeJEXVzsiEtOKKTvwZGjm wDxqHow4BNP1ye4OQuZCXwG/4Bjb2eFOPS6FjUCDjJyOR791u2ycbBrEHhWEFmSsi4Wo VVu0a/DU+24dvOwiJtZ419ylt+zrhxANUsmW4ZZ6NqESWcDnDn/uNmOSENCWs4lNOSOd PtVmf+/sQiy8Qrif6+l1rXIfnolAYojX0dckfmtWeXRPwPXUWQcnvcL8tT3/sDNr0xih rDgX4oIKRds0t+2lntTQk+iKjbw3XEJ2sVPRA6L2h86I8Wh57+toi2wHHT8YzankvM7l rJTg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=52BOaMVUM1qOw8R0QYiPT4dZBJ9B/kJn4tJ8pYk+AhI=; fh=77+DuGbxylSfxqbdVq+l1pXpOrkOStcR36L/jqDPp80=; b=MhD0/plzwwb2hE79Bnd+gK3p36N++cvvCecbqFCRwBOzKJmHgDtGWubahJdHncsAIC bxJNNLh3a8A4/6W5dIwCcj11KmIMyxoWMqOrUPNQtHCYc0Be+Hm4K42NTA3yjCiGOtce Zohr/XWdrlLMwT0QgmKDxUK5RUkZxS2AGzZpWGhmlg8yUs0NdpIiD7GsZsxNNWkMMkoN 8r8mz3D7RHoQtcflnHJXOhLKiDxwp+CsGYb+iEiugpyDf74tyP7Wgf2czaArOxUUyt9i DTr5DHO8OFgNRRHuuZ8sGWttp+Oq01OEilmtc6SoHIYr6YiGILZFKsM8bvPJDOzZeRjO zf9w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=oHBD9nEY; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-54526-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54526-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com X-Forwarded-Encrypted: i=1; AJvYcCVy6sn1or+SzK+ZfKmE87pTnHS+IgVVpyhgVOqO8xaGPqMwexeaXXaahilCRIDW5HqDZ8yG5/WAkkr0KXEhORbcIPEbpg== Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id e20-20020a170906375400b00a38285ad847si461300ejc.584.2024.02.06.00.56.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 00:56:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-54526-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=oHBD9nEY; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-54526-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54526-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id A25791F27614 for ; Tue, 6 Feb 2024 08:49:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 51F4212C532; Tue, 6 Feb 2024 08:48:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="oHBD9nEY" Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0E2012BEA2 for ; Tue, 6 Feb 2024 08:48:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707209315; cv=none; b=hZBqlVZTMn0kgvsrEFuvfKGff9lJnYbbqU2Zo/xm3saqljqv99JhsVhKBf8SyOyP3ZwXjAGIefbm3Mvn3mu9MgWbRbNm5WUkZD6EWv/t91hZIkNf2ySyzYWpvwsDupvpSr9Yb8GnbeJke+/9h+aT3EqEMUDPN/esJ7udmerP9aU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707209315; c=relaxed/simple; bh=aT/CkiJIYu8ukwP0OeHxZgN3d9mcS6SutCMYSXztOEw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=GzC7gipuKv+VqBLht/1CyfCNNTpZHKELhnL/PTot8ROdu33/8L8n3hbB4i4l1YXOec5kt40YdMTjahenbMs0id9sW3z2HvNeerqvGeiuGorXTQSCIBF6kkdLnLLiaUmrrQBRQpofGauVv6DrI/IkFzCjrK7tjTg5YR43kQuo9LY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=oHBD9nEY; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1707209312; bh=aT/CkiJIYu8ukwP0OeHxZgN3d9mcS6SutCMYSXztOEw=; h=From:To:Cc:Subject:Date:From; b=oHBD9nEYlfXbX0kGB1OD8e3b3FDSusD5ao88V1k54bq/fP1UPoCh4WlCpEj0zDgKI zzDGFy0VDBc4u2FVDOZNkAb/hY9p1xHkLvANakuW7xod4ZTVo/3XacBlPfmn5mXoCn FyjpPLijwAyt/Tts6DGZ6ZsWAx9rx5lDlbJJqzC4U/qruMAvVvAMC161hO0LiREh/c BMwO7r63QTTj4+rJMsnd9J+WeAPDpMkDg7neU1COnIL7aIU7o1pui4lp01LYjVqZ/A hAOqHo2pUaS3loFPYmgb9VBSAD5w7S9UKnoV42sjTDStrz217I5cG2OpDdcS0eQ57Q i1MUmVbSf+QqA== Received: from localhost.localdomain (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id B7C43378000E; Tue, 6 Feb 2024 08:48:29 +0000 (UTC) From: Muhammad Usama Anjum To: Andrew Morton Cc: Paul Gofman , usama.anjum@collabora.com, kernel@collabora.com, =?utf-8?b?TWljaGHFgiBNaXJvc8WCYXc=?= , Andrei Vagin , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm/migrate: preserve exact soft-dirty state Date: Tue, 6 Feb 2024 13:48:01 +0500 Message-ID: <20240206084838.34560-1-usama.anjum@collabora.com> X-Mailer: git-send-email 2.42.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790139196205269870 X-GMAIL-MSGID: 1790139196205269870 From: Paul Gofman pte_mkdirty() sets both _PAGE_DIRTY and _PAGE_SOFT_DIRTY bits. The _PAGE_SOFT_DIRTY can get set even if it wasn't set on original page before migration. This makes non-soft-dirty pages soft-dirty just because of migration/compaction. Clear the _PAGE_SOFT_DIRTY flag if it wasn't set on original page. By definition of soft-dirty feature, there can be spurious soft-dirty pages because of kernel's internal activity such as VMA merging or migration/compaction. This patch is eliminating the spurious soft-dirty pages because of migration/compaction. Cc: Michał Mirosław Cc: Andrei Vagin Signed-off-by: Paul Gofman Signed-off-by: Muhammad Usama Anjum Acked-by: Andrei Vagin --- mm/migrate.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/mm/migrate.c b/mm/migrate.c index cc9f2bcd73b4..05d6ca437321 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -211,14 +211,17 @@ static bool remove_migration_pte(struct folio *folio, folio_get(folio); pte = mk_pte(new, READ_ONCE(vma->vm_page_prot)); old_pte = ptep_get(pvmw.pte); - if (pte_swp_soft_dirty(old_pte)) - pte = pte_mksoft_dirty(pte); entry = pte_to_swp_entry(old_pte); if (!is_migration_entry_young(entry)) pte = pte_mkold(pte); if (folio_test_dirty(folio) && is_migration_entry_dirty(entry)) pte = pte_mkdirty(pte); + if (pte_swp_soft_dirty(old_pte)) + pte = pte_mksoft_dirty(pte); + else + pte = pte_clear_soft_dirty(pte); + if (is_writable_migration_entry(entry)) pte = pte_mkwrite(pte, vma); else if (pte_swp_uffd_wp(old_pte))