diff mbox series

qed: remove duplicated assignment to variable opaque_fid

Message ID 20240205215530.1851115-1-colin.i.king@gmail.com
State New
Headers
Series qed: remove duplicated assignment to variable opaque_fid |

Commit Message

Colin Ian King Feb. 5, 2024, 9:55 p.m. UTC 
  Variable opaque_fid is being assigned twice with the same value
in two identical statements. Remove the redundant first assignment.

Cleans up clang scan build warnin:
drivers/net/ethernet/qlogic/qed/qed_rdma.c:1796:2: warning: Value
stored to 'opaque_fid' is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/net/ethernet/qlogic/qed/qed_rdma.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Simon Horman Feb. 7, 2024, 9:39 a.m. UTC | #1 
On Mon, Feb 05, 2024 at 09:55:30PM +0000, Colin Ian King wrote:
> Variable opaque_fid is being assigned twice with the same value
> in two identical statements. Remove the redundant first assignment.
> 
> Cleans up clang scan build warnin:

warning :)

> drivers/net/ethernet/qlogic/qed/qed_rdma.c:1796:2: warning: Value
> stored to 'opaque_fid' is never read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Reviewed-by: Simon Horman <horms@kernel.org>
patchwork-bot+netdevbpf@kernel.org Feb. 9, 2024, 3:11 a.m. UTC | #2 
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon,  5 Feb 2024 21:55:30 +0000 you wrote:
> Variable opaque_fid is being assigned twice with the same value
> in two identical statements. Remove the redundant first assignment.
> 
> Cleans up clang scan build warnin:
> drivers/net/ethernet/qlogic/qed/qed_rdma.c:1796:2: warning: Value
> stored to 'opaque_fid' is never read [deadcode.DeadStores]
> 
> [...]

Here is the summary with links:
  - qed: remove duplicated assignment to variable opaque_fid
    https://git.kernel.org/netdev/net-next/c/5c80e62a2ac5

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/qlogic/qed/qed_rdma.c b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
index 5a5dbbb8d8aa..9a1660a12c57 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_rdma.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
@@ -1793,8 +1793,6 @@  qed_rdma_create_srq(void *rdma_cxt,
 	if (rc)
 		goto err;
 
-	opaque_fid = p_hwfn->hw_info.opaque_fid;
-
 	opaque_fid = p_hwfn->hw_info.opaque_fid;
 	init_data.opaque_fid = opaque_fid;
 	init_data.comp_mode = QED_SPQ_MODE_EBLOCK;