| Message ID | 20240205180436.1841706-1-colin.i.king@gmail.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel+bounces-53178-ouuuleilei=gmail.com@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id
ma11csp1047192dyb;
Mon, 5 Feb 2024 10:05:02 -0800 (PST)
X-Google-Smtp-Source:
AGHT+IH02hfhG9WYtWD4egw/C0tqeFBmpDxsCoSAURu6AyB5K7nodYC4mX05vjS5gYZrC5AyMac7
X-Received: by 2002:a17:902:e983:b0:1d9:7ab0:5e20 with SMTP id
f3-20020a170902e98300b001d97ab05e20mr242324plb.69.1707156301746;
Mon, 05 Feb 2024 10:05:01 -0800 (PST)
ARC-Seal: i=2; a=rsa-sha256; t=1707156301; cv=pass;
d=google.com; s=arc-20160816;
b=nwv3DUIHYpOF/ndn5CiJwL6JPNFhHnh4YJyggXqP7+qiS43XS1/nVT1YXtsqjyW9iA
Nxc8B9wt0FpzoyV2ay96StpnGGmgGF/veku9GfVRBcja2/8W/xFFv+bMvhH/vsJpnXpS
T8gbkZSRoWu3wjiFCeY1ELPZBd+OEpUvq/1s461BCLVl+IsWfDq7MU+Rb5AudoYMpRlp
3UsY/wd9UnPPIdct+8eCmvg0oAVKrqMYdbLF7rQMQ1UbDZsyiAgyAsXsuQT4xev/Gaoe
ZXvR05BiSzCrmITIO4wyOpR/ygkzBrZbqEKZGwMqn5nWfmUvKDx4/ARww+0lpeuxzn/L
cUdQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=content-transfer-encoding:mime-version:list-unsubscribe
:list-subscribe:list-id:precedence:message-id:date:subject:cc:to
:from:dkim-signature;
bh=HQK/98G9XoX645/LAft2pPXCTjN+BMBYrQ0Nd3/J0IA=;
fh=i8wqoV5CKWQis6rvgjVPGg9YakXFw5zDtoLEFTe4NZo=;
b=v2Wh+xlyfaXsCDu8/I65t5VNXJqlSwyv72q8bnWaI6nGZ17EmEzlK++1lDrZTn4qrA
vBXXuj99RrN8qpxOHQeF18zK+M8uIxDcclOfADhsBol7oXvVZYvE6v9x08yhMINql1l8
amEQek+kozY/Mcgx6dz9/ndlWsfHtf6iT2q89sBxOdYphLp+9HT2rX1k35vzstT3JYNc
u5XprYgnU1FzyZ8Bq3sJ8GHLQCnE8x7zM3LysZp4CuCArfN1L2zOWgeo63+UIFAvVVEm
ATvQb0GJZEpPAHWdL0Z0KqxdFv/fE0hvHKppwrOar3+W8+0aDshvq44jedUCf6UDEK0I
g3Iw==;
dara=google.com
ARC-Authentication-Results: i=2; mx.google.com;
dkim=pass header.i=@gmail.com header.s=20230601 header.b=GYOlBbpI;
arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com
dmarc=pass fromdomain=gmail.com);
spf=pass (google.com: domain of
linux-kernel+bounces-53178-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:45e3:2400::1 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-53178-ouuuleilei=gmail.com@vger.kernel.org";
dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
X-Forwarded-Encrypted: i=1;
AJvYcCVhK/q1VcZhTCSELIlazJDhu2Wwhaea7WKqxsqE5xMW6eDIse2ykw1YEz8TNpDLT3EZAWZi6OVsq7kW/q/jkgwlNPbeOg==
Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org.
[2604:1380:45e3:2400::1])
by mx.google.com with ESMTPS id
u16-20020a170902e5d000b001d9449e0a6bsi184277plf.588.2024.02.05.10.05.01
for <ouuuleilei@gmail.com>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 05 Feb 2024 10:05:01 -0800 (PST)
Received-SPF: pass (google.com: domain of
linux-kernel+bounces-53178-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Authentication-Results: mx.google.com;
dkim=pass header.i=@gmail.com header.s=20230601 header.b=GYOlBbpI;
arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com
dmarc=pass fromdomain=gmail.com);
spf=pass (google.com: domain of
linux-kernel+bounces-53178-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:45e3:2400::1 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-53178-ouuuleilei=gmail.com@vger.kernel.org";
dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org
[52.25.139.140])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4326A282C1D
for <ouuuleilei@gmail.com>; Mon, 5 Feb 2024 18:04:58 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
by smtp.subspace.kernel.org (Postfix) with ESMTP id E4FC947F7E;
Mon, 5 Feb 2024 18:04:43 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
header.b="GYOlBbpI"
Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com
[209.85.128.43])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9A0E47F59;
Mon, 5 Feb 2024 18:04:39 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
arc=none smtp.client-ip=209.85.128.43
ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
t=1707156281; cv=none;
b=C9jLrfbNh9F1ePIfHAAavCPSz62TDvl0R6df4bvRnudJ26OGlUVbGl3e18RbHN8FK6h0H80rtnGrT8+KN9cXwGRNgNwyUV8kp3SZ0PMm2w6A9rkqtgTVInenWs37RAcpQnEbfi08etWGSjZdoHBIMBR3DVwU8stLS/2EhKoODnQ=
ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org;
s=arc-20240116; t=1707156281; c=relaxed/simple;
bh=TMmz9ofcV3Qg3qVRtpdLWdMNQPaRCIuMqEqskELJsXM=;
h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type;
b=si7N0OdLF38cGoucKGXLamit8FrkoiCevTKNImNWDsgR1ZdxJPwA8DBnXToRk16DvPkBv8s9ma4Pi+OJmwi2Msyf++xJK8sryFUtdPKZwf4NXsopFrUYoNMceqaismsrSCTWMx6FVMSt3v93nLA4jPXB+qqyn/cLx25GHf25Jrs=
ARC-Authentication-Results: i=1; smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=gmail.com;
spf=pass smtp.mailfrom=gmail.com;
dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
header.b=GYOlBbpI; arc=none smtp.client-ip=209.85.128.43
Authentication-Results: smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=gmail.com
Received: by mail-wm1-f43.google.com with SMTP id
5b1f17b1804b1-40fb3b5893eso38703345e9.0;
Mon, 05 Feb 2024 10:04:39 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1707156278; x=1707761078;
darn=vger.kernel.org;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=HQK/98G9XoX645/LAft2pPXCTjN+BMBYrQ0Nd3/J0IA=;
b=GYOlBbpIKWSHCKPmAWC0T5QQI7v9ypjxDwjwBXXo3LtkEJKda6vIjva3QRHloDImhe
suGtwligIbp71TNZUgj36jVOddSTtFTZcPLgO6NnKZm8uDOnWYfRmxTv75vwQEUaSwE7
PADrZ8SLsJ5ym5uxFl1tUFm2OA99zmEcNFl/jIfkvz1irzQuv4y36zp1Vae5Pa7kEZ03
HSAR9m6/RyYrm1TqdbX5F4en3fAsnD/xIKIi7vW9nF16Ahog47liJyuUGZhNCIN/THJJ
VA23R/uK2lSTZPMcMLZllbTeENrPONVTMHL8gVAl33LNPWpbtrWqHrV63FvbpMVK1EmE
s87g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1707156278; x=1707761078;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=HQK/98G9XoX645/LAft2pPXCTjN+BMBYrQ0Nd3/J0IA=;
b=NIh9J9J0rUgS8XT/gqpQgS+c+HwVXT59guIltTKOgZoZwzp2fQp1zBqAhqZNTPysIW
cqGEAsdp3jaL7l60S4OF6DDwz4M6Ui/UH1htrwpRNHwzYmqn+0uiDS5Qs/lzINKkobl+
sXkA6bh0gfy3fMUxC17B+N9W3gU37C7agS2J11d3zlUChrh2Ss/pDjacvwMezjr42WXq
lghbLkFxdXt9dFROOtATWsZq6fbMc/QZyKZ2q/TzcGsr6hnaZfIDWngYNUnIfoA5DwgQ
oF02TO3sv5GEADW6XN6MsdDdXdQH6uuI9mDfdNEHtspwnAwfhFcSIQD55aEcBu+5LVLR
wpig==
X-Gm-Message-State: AOJu0YyPIevo3m01jFvezX5dfk2NXARlfSxcHHP5UVkpeyaOBnx5NxY4
jO+DvkiphEwCalP0S9Q8IHpwjJGddkyLEVCSQrotvG82qo03XyoTOIn8jAt3
X-Received: by 2002:a05:600c:3d08:b0:40f:e067:d67e with SMTP id
bh8-20020a05600c3d0800b0040fe067d67emr133989wmb.3.1707156277764;
Mon, 05 Feb 2024 10:04:37 -0800 (PST)
X-Forwarded-Encrypted: i=0;
AJvYcCXO8zB4b/6jxR/B/RwwFZajC38o+8DiwDup2yUu/xCwFlxEsbK3IR8rE7DQYzHB2htR3WpfkEICsjdb2SKdPe/P0EwpFDGngsZr/qzGcmwnTHiE76fKuHfdcP4kPIV6zke88mlmMoKNDes5HkW06CqkFrGcfT3g+FR0X0ZQbX3mvnENBF8mpBA0+ePKArrETHfbpYegGmCu9GPJ9Y6Ucg==
Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net.
[80.193.200.194])
by smtp.gmail.com with ESMTPSA id
l18-20020a05600c1d1200b0040e541ddcb1sm549411wms.33.2024.02.05.10.04.36
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 05 Feb 2024 10:04:37 -0800 (PST)
From: Colin Ian King <colin.i.king@gmail.com>
To: Ian Abbott <abbotti@mev.co.uk>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH][next] comedi: remove redundant assignment to variable range
Date: Mon, 5 Feb 2024 18:04:36 +0000
Message-Id: <20240205180436.1841706-1-colin.i.king@gmail.com>
X-Mailer: git-send-email 2.39.2
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1790083125874093532
X-GMAIL-MSGID: 1790083125874093532
|
| Series |
[next] comedi: remove redundant assignment to variable range
|
|
Commit Message
Colin Ian King
Feb. 5, 2024, 6:04 p.m. UTC
The variable range is being initialized with a value that is never
read, it is being re-assigned later on. The initialization is
redundant and can be removed.
Cleans up clang scan build warning:
drivers/comedi/drivers/das08.c:180:2: warning: Value stored
to 'range' is never read [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/comedi/drivers/das08.c | 1 -
1 file changed, 1 deletion(-)
Comments
On 05/02/2024 18:04, Colin Ian King wrote: > The variable range is being initialized with a value that is never > read, it is being re-assigned later on. The initialization is > redundant and can be removed. > > Cleans up clang scan build warning: > drivers/comedi/drivers/das08.c:180:2: warning: Value stored > to 'range' is never read [deadcode.DeadStores] > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > drivers/comedi/drivers/das08.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/comedi/drivers/das08.c b/drivers/comedi/drivers/das08.c > index 5d5b9174f88a..49944ce1f813 100644 > --- a/drivers/comedi/drivers/das08.c > +++ b/drivers/comedi/drivers/das08.c > @@ -177,7 +177,6 @@ static int das08_ai_insn_read(struct comedi_device *dev, > int ret; > > chan = CR_CHAN(insn->chanspec); > - range = CR_RANGE(insn->chanspec); > > /* clear crap */ > inb(dev->iobase + DAS08_AI_LSB_REG); Thanks. It looks like it gets reassigned to the same value further down, closer to the point where the value is used (within an `if` block), and so it doesn't matter which of the assignments is removed. Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
diff --git a/drivers/comedi/drivers/das08.c b/drivers/comedi/drivers/das08.c index 5d5b9174f88a..49944ce1f813 100644 --- a/drivers/comedi/drivers/das08.c +++ b/drivers/comedi/drivers/das08.c @@ -177,7 +177,6 @@ static int das08_ai_insn_read(struct comedi_device *dev, int ret; chan = CR_CHAN(insn->chanspec); - range = CR_RANGE(insn->chanspec); /* clear crap */ inb(dev->iobase + DAS08_AI_LSB_REG);