net: Change default delay on IP autoconfig to 0ms

Message ID 20240205155717.484198-1-david@davidv.dev
State New
Headers
Series net: Change default delay on IP autoconfig to 0ms |

Commit Message

David Feb. 5, 2024, 3:55 p.m. UTC
  As suggested, I'm updating the default to 0ms. 

This patch depends on 1f0aa0c947eeb4edb60add141a5bc2309f2dc8dd ("
net: make driver settling time configurable").

Signed-off-by: David Ventura <david@davidv.dev>
---
 Documentation/admin-guide/nfs/nfsroot.rst | 2 +-
 net/ipv4/ipconfig.c                       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
  

Comments

Jakub Kicinski Feb. 7, 2024, 3:58 p.m. UTC | #1
On Mon,  5 Feb 2024 16:55:43 +0100 David Ventura wrote:
> As suggested, I'm updating the default to 0ms. 
> 
> This patch depends on 1f0aa0c947eeb4edb60add141a5bc2309f2dc8dd ("
> net: make driver settling time configurable").

Please post a v2, in a new thread, and proper commit description
with a link to the discussion with Andrew.
  

Patch

diff --git a/Documentation/admin-guide/nfs/nfsroot.rst b/Documentation/admin-guide/nfs/nfsroot.rst
index f26f7a342af6..fce610a4ec54 100644
--- a/Documentation/admin-guide/nfs/nfsroot.rst
+++ b/Documentation/admin-guide/nfs/nfsroot.rst
@@ -225,7 +225,7 @@  ip=<client-ip>:<server-ip>:<gw-ip>:<netmask>:<hostname>:<device>:<autoconf>:<dns
 
 ip.dev_wait_ms=<value>
   Set the number of milliseconds to delay after opening the network device
-  which will be autoconfigured. Defaults to 10 milliseconds.
+  which will be autoconfigured. Defaults to 0 milliseconds.
 
 nfsrootdebug
   This parameter enables debugging messages to appear in the kernel
diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
index cbf35163b973..8b7d08649b09 100644
--- a/net/ipv4/ipconfig.c
+++ b/net/ipv4/ipconfig.c
@@ -99,7 +99,7 @@ 
 
 /* Wait for carrier timeout default in seconds */
 static unsigned int carrier_timeout = 120;
-static unsigned int dev_wait_ms = 10;
+static unsigned int dev_wait_ms = 0;
 
 /*
  * Public IP configuration