diff mbox series

ksmbd: free aux buffer if ksmbd_iov_pin_rsp_read fails

Message ID 20240205111917.181490-1-pchelkin@ispras.ru
State New
Headers
Series ksmbd: free aux buffer if ksmbd_iov_pin_rsp_read fails |

Commit Message

Fedor Pchelkin Feb. 5, 2024, 11:19 a.m. UTC 
  ksmbd_iov_pin_rsp_read() doesn't free the provided aux buffer if it
fails. Seems to be the caller's responsibility to clear the buffer in
error case.

Found by Linux Verification Center (linuxtesting.org).

Fixes: e2b76ab8b5c9 ("ksmbd: add support for read compound")
Cc: stable@vger.kernel.org
Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
---
 fs/smb/server/smb2pdu.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Comments

Namjae Jeon Feb. 5, 2024, 11:45 a.m. UTC | #1 
2024-02-05 20:19 GMT+09:00, Fedor Pchelkin <pchelkin@ispras.ru>:
> ksmbd_iov_pin_rsp_read() doesn't free the provided aux buffer if it
> fails. Seems to be the caller's responsibility to clear the buffer in
> error case.
>
> Found by Linux Verification Center (linuxtesting.org).
>
> Fixes: e2b76ab8b5c9 ("ksmbd: add support for read compound")
> Cc: stable@vger.kernel.org
> Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
Applied it to #ksmbd-for-next-next.
Thanks for your patch!
diff mbox series

Patch

diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c
index ba7a72a6a4f4..0c97d3c86072 100644
--- a/fs/smb/server/smb2pdu.c
+++ b/fs/smb/server/smb2pdu.c
@@ -6173,8 +6173,10 @@  static noinline int smb2_read_pipe(struct ksmbd_work *work)
 		err = ksmbd_iov_pin_rsp_read(work, (void *)rsp,
 					     offsetof(struct smb2_read_rsp, Buffer),
 					     aux_payload_buf, nbytes);
-		if (err)
+		if (err) {
+			kvfree(aux_payload_buf);
 			goto out;
+		}
 		kvfree(rpc_resp);
 	} else {
 		err = ksmbd_iov_pin_rsp(work, (void *)rsp,
@@ -6384,8 +6386,10 @@  int smb2_read(struct ksmbd_work *work)
 	err = ksmbd_iov_pin_rsp_read(work, (void *)rsp,
 				     offsetof(struct smb2_read_rsp, Buffer),
 				     aux_payload_buf, nbytes);
-	if (err)
+	if (err) {
+		kvfree(aux_payload_buf);
 		goto out;
+	}
 	ksmbd_fd_put(work, fp);
 	return 0;