diff mbox series

mtd: flashchip: explicitly include <linux/wait.h>

Message ID 20240205100955.149755-1-tudor.ambarus@linaro.org
State New
Headers
Series mtd: flashchip: explicitly include <linux/wait.h> |

Commit Message

Tudor Ambarus Feb. 5, 2024, 10:09 a.m. UTC 
  While reviewing the hyperbus sfdp proposal the following problem was
noticed:

In file included from ./include/linux/mtd/gen_probe.h:10,
                 from drivers/mtd/hyperbus/hyperbus-sfdp.c:6:
/include/linux/mtd/flashchip.h:77:9: error: unknown type name ‘wait_queue_head_t’
   77 |         wait_queue_head_t wq; /* Wait on here when we're waiting for the chip
      |         ^~~~~~~~~~~~~~~~~

It is good practice to directly include all headers used, it avoids
implicit dependencies and spurious breakage if someone rearranges
headers and causes the implicit include to vanish.

Explicitly include <linux/wait.h> in include/linux/mtd/flashchip.

Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
---
 include/linux/mtd/flashchip.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Miquel Raynal Feb. 5, 2024, 2:26 p.m. UTC | #1 
On Mon, 2024-02-05 at 10:09:55 UTC, Tudor Ambarus wrote:
> While reviewing the hyperbus sfdp proposal the following problem was
> noticed:
> 
> In file included from ./include/linux/mtd/gen_probe.h:10,
>                  from drivers/mtd/hyperbus/hyperbus-sfdp.c:6:
> ./include/linux/mtd/flashchip.h:77:9: error: unknown type name ‘wait_queue_head_t’
>    77 |         wait_queue_head_t wq; /* Wait on here when we're waiting for the chip
>       |         ^~~~~~~~~~~~~~~~~
> 
> It is good practice to directly include all headers used, it avoids
> implicit dependencies and spurious breakage if someone rearranges
> headers and causes the implicit include to vanish.
> 
> Explicitly include <linux/wait.h> in include/linux/mtd/flashchip.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.

Miquel
diff mbox series

Patch

diff --git a/include/linux/mtd/flashchip.h b/include/linux/mtd/flashchip.h
index c04f690871ca..9798c1a1d3b6 100644
--- a/include/linux/mtd/flashchip.h
+++ b/include/linux/mtd/flashchip.h
@@ -13,6 +13,7 @@ 
  */
 #include <linux/sched.h>
 #include <linux/mutex.h>
+#include <linux/wait.h>
 
 typedef enum {
 	FL_READY,