From patchwork Sun Feb 4 01:16:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 196393 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp148338dyb; Sat, 3 Feb 2024 17:23:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IFdAFVVGB77nHK4tsMmXLs4TQJEOgpQEXA7cZC5Jsg2vZNQhhW1Ex4e5OTB6AjipnRj8ln3 X-Received: by 2002:a17:90a:8049:b0:296:4170:aaf8 with SMTP id e9-20020a17090a804900b002964170aaf8mr3534401pjw.18.1707009809149; Sat, 03 Feb 2024 17:23:29 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707009809; cv=pass; d=google.com; s=arc-20160816; b=lut5eTTrxg7HyZwjow+9kdQqKyebfhuLJ2m9yVPf6doZ8m9xInunmzDUKOonCTbsKJ lwEErOxgkz9RKu27lSCkwS+HbqittROqxr7nSdSdtvKOxAt/IslvK/qRtQHD3js8vAbt TOIZk+SAdwxq7ICdB206lmyP59Z9+0RXf7zQrBOUnpw98AoyUE8Yzp0eENkuxnnaP08B EE5hFCtgl3yHzrH+WnLEOtyWrlJg6nECxI++poUKWTk/B9vnvPojcQuWRa/MUEnvIXHJ 0cBz+lgnAD5mDicMerAOApPRmqUkF3YAfTH1yeYOSEJzjcc3H3j230Sp7uDFupQ5LVi7 KGlg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:subject:cc:to:from:date:user-agent:message-id; bh=GdTlwYEOaQ93M+seSEUVljEDzKoBPS0AJLTWFZWlso4=; fh=v0elI7fExnC9k8+xun8UV/DEQsMwBUfg/4y5/rn2Cn0=; b=DrsSxvqoHqnMBTuD++y2V2Jq2rcr2VIcD6Trs3EZZ/OL4JZ/QthUvQXJ8gJQAhcgrw TJKrHfEhETAtfz/ckWdTnPB44z1fdwimVri4sYjoInppIASqbyh6GaZCUIQ3zge+DOEk nCB0oiJ6h2kynFesrnWmm/Oe0KHL6UaPMLZzZvNmNhNaKI6iQoMLbKgk0HUT5tLM9+Dc c+FD2MGLnc17YUtQKBuIWiL7WMv0ODIyq8X3LU9tInQw9heV17XbCvzCREjZFPh7X07W VPcjE6mzRYYEx6qkmItWHCR29dzdkFQziciR+c1FBUmUlDzrfMwghmCUrS6oO8I9HrFa Eonw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-51358-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-51358-ouuuleilei=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=1; AJvYcCVKm/SGM9/9BId35JEJbcZR16UflKXrXsKTy0CKGe2kS/anC/czpcXZDbJajJMD86z7it6ekJ7YNneBjRuv0KloDOl8Bw== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id z19-20020a17090ad79300b002909c51fb3csi2232320pju.62.2024.02.03.17.23.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Feb 2024 17:23:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-51358-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-51358-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-51358-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id BA7DF282986 for ; Sun, 4 Feb 2024 01:23:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F159418AE0; Sun, 4 Feb 2024 01:18:12 +0000 (UTC) Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5200B10A25; Sun, 4 Feb 2024 01:18:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707009488; cv=none; b=RR89i/l9BtgJrS9raimPAbs2C1DgU4pAqYOsu+4/hS5nRVIflkKYH4vOEAf5zG/IgtZOluC51nX3zknnt+wFjaRrXbtbL5E4ZkXjaMBSv3dZQTxKpMqFIU38T6F45aj3xId4abcsRj8LxR+bZmf907EelX6wDRF3c4Cv1SRFVXU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707009488; c=relaxed/simple; bh=c2ljJPiZws6OX2OlljjxZ50rg8MQ1U9fnX0GsF88OI4=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=TVNyQHvMqmgO1uK6SMHMhwt7xBWthSBKgO8nM/Zq54OIkDIOPNfsNnMVn2ShIRFpMBjCezCTiu0LbifiqH048yHkau2coiAA/R8XrKHX5ZhI9p+JPi5ThUyH9aAsQdNwpfOdjrQLdzRSWlFadI1qeTRQyIUdo1juTLPGUlEchJU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5298C43141; Sun, 4 Feb 2024 01:18:07 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.97) (envelope-from ) id 1rWR9S-00000006OvN-2bzX; Sat, 03 Feb 2024 20:18:30 -0500 Message-ID: <20240204011830.479095089@goodmis.org> User-Agent: quilt/0.67 Date: Sat, 03 Feb 2024 20:16:37 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Linus Torvalds , Greg Kroah-Hartman , Sasha Levin , Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Christian Brauner , Al Viro , Ajay Kaher , Al Viro Subject: [v6.7][PATCH 22/23] eventfs: Remove fsnotify*() functions from lookup() References: <20240204011615.703023949@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789929517642421137 X-GMAIL-MSGID: 1789929517642421137 From: "Steven Rostedt (Google)" The dentries and inodes are created when referenced in the lookup code. There's no reason to call fsnotify_*() functions when they are created by a reference. It doesn't make any sense. Link: https://lore.kernel.org/linux-trace-kernel/20240201002719.GS2087318@ZenIV/ Link: https://lore.kernel.org/linux-trace-kernel/20240201161617.166973329@goodmis.org Cc: stable@vger.kernel.org Cc: Linus Torvalds Cc: Masami Hiramatsu Cc: Mark Rutland Cc: Mathieu Desnoyers Cc: Christian Brauner Cc: Al Viro Cc: Ajay Kaher Fixes: a376007917776 ("eventfs: Implement functions to create files and dirs when accessed"); Suggested-by: Al Viro Signed-off-by: Steven Rostedt (Google) --- fs/tracefs/event_inode.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c index ca7daee7c811..9e031e5a2713 100644 --- a/fs/tracefs/event_inode.c +++ b/fs/tracefs/event_inode.c @@ -366,7 +366,6 @@ static struct dentry *lookup_file(struct eventfs_inode *parent_ei, dentry->d_fsdata = get_ei(parent_ei); d_add(dentry, inode); - fsnotify_create(dentry->d_parent->d_inode, dentry); return NULL; }; @@ -408,7 +407,6 @@ static struct dentry *lookup_dir_entry(struct dentry *dentry, inc_nlink(inode); d_add(dentry, inode); inc_nlink(dentry->d_parent->d_inode); - fsnotify_mkdir(dentry->d_parent->d_inode, dentry); return NULL; }