diff mbox series

[v6.7,17/23] eventfs: Remove unused d_parent pointer field

Message ID	20240204011829.656627126@goodmis.org
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel+bounces-51352-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Message-ID: <20240204011829.656627126@goodmis.org> User-Agent: quilt/0.67 Date: Sat, 03 Feb 2024 20:16:32 -0500 From: Steven Rostedt <rostedt@goodmis.org> To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Linus Torvalds <torvalds@linux-foundation.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sasha Levin <sashal@kernel.org>, Masami Hiramatsu <mhiramat@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Mathieu Desnoyers <mathieu.desnoyers@efficios.com>, Andrew Morton <akpm@linux-foundation.org>, Christian Brauner <brauner@kernel.org>, Al Viro <viro@ZenIV.linux.org.uk>, Ajay Kaher <ajay.kaher@broadcom.com> Subject: [v6.7][PATCH 17/23] eventfs: Remove unused d_parent pointer field References: <20240204011615.703023949@goodmis.org> Precedence: bulk MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX
Series	eventfs: Linus's updates for 6.7 \| [v6.7,00/23] eventfs: Linus's updates for 6.7 [v6.7,01/23] eventfs: Remove "lookup" parameter from create_dir/file_dentry() [v6.7,02/23] eventfs: Stop using dcache_readdir() for getdents() [v6.7,03/23] tracefs/eventfs: Use root and instance inodes as default ownership [v6.7,04/23] eventfs: Have eventfs_iterate() stop immediately if ei->is_freed is set [v6.7,05/23] eventfs: Do ctx->pos update for all iterations in eventfs_iterate() [v6.7,06/23] eventfs: Read ei->entries before ei->children in eventfs_iterate() [v6.7,07/23] eventfs: Shortcut eventfs_iterate() by skipping entries already read [v6.7,08/23] eventfs: Have the inodes all for files and directories all be the same [v6.7,09/23] eventfs: Do not create dentries nor inodes in iterate_shared [v6.7,10/23] eventfs: Use kcalloc() instead of kzalloc() [v6.7,11/23] eventfs: Save directory inodes in the eventfs_inode structure [v6.7,12/23] tracefs: remove stale update_gid code [v6.7,13/23] tracefs: Zero out the tracefs_inode when allocating it [v6.7,15/23] tracefs: Avoid using the ei->dentry pointer unnecessarily [v6.7,16/23] tracefs: dentry lookup crapectomy [v6.7,17/23] eventfs: Remove unused d_parent pointer field [v6.7,18/23] eventfs: Clean up dentry ops and add revalidate function [v6.7,19/23] eventfs: Get rid of dentry pointers without refcounts [v6.7,20/23] eventfs: Warn if an eventfs_inode is freed without is_freed being set [v6.7,21/23] eventfs: Restructure eventfs_inode structure to be more condensed [v6.7,22/23] eventfs: Remove fsnotify*() functions from lookup() [v6.7,23/23] eventfs: Keep all directory links at 1

Commit Message

Steven Rostedt Feb. 4, 2024, 1:16 a.m. UTC

  From: Linus Torvalds <torvalds@linux-foundation.org>

It's never used

Link: https://lore.kernel.org/linux-trace-kernel/202401291043.e62e89dc-oliver.sang@intel.com/
Link: https://lore.kernel.org/linux-trace-kernel/20240131185512.961772428@goodmis.org

Cc: stable@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Christian Brauner <brauner@kernel.org>
Cc: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Ajay Kaher <ajay.kaher@broadcom.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fixes: c1504e510238 ("eventfs: Implement eventfs dir creation functions")
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 fs/tracefs/event_inode.c | 4 +---
 fs/tracefs/internal.h    | 2 --
 2 files changed, 1 insertion(+), 5 deletions(-)

diff mbox series

Patch

diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c
index 04c2ab90f93e..16ca8d9759b1 100644
--- a/fs/tracefs/event_inode.c
+++ b/fs/tracefs/event_inode.c
@@ -680,10 +680,8 @@  struct eventfs_inode *eventfs_create_dir(const char *name, struct eventfs_inode
 	INIT_LIST_HEAD(&ei->list);
 
 	mutex_lock(&eventfs_mutex);
-	if (!parent->is_freed) {
+	if (!parent->is_freed)
 		list_add_tail(&ei->list, &parent->children);
-		ei->d_parent = parent->dentry;
-	}
 	mutex_unlock(&eventfs_mutex);
 
 	/* Was the parent freed? */
diff --git a/fs/tracefs/internal.h b/fs/tracefs/internal.h
index 09037e2c173d..932733a2696a 100644
--- a/fs/tracefs/internal.h
+++ b/fs/tracefs/internal.h
@@ -36,7 +36,6 @@  struct eventfs_attr {
  * @name:	the name of the directory to create
  * @children:	link list into the child eventfs_inode
  * @dentry:     the dentry of the directory
- * @d_parent:   pointer to the parent's dentry
  * @d_children: The array of dentries to represent the files when created
  * @entry_attrs: Saved mode and ownership of the @d_children
  * @attr:	Saved mode and ownership of eventfs_inode itself
@@ -51,7 +50,6 @@  struct eventfs_inode {
 	const char			*name;
 	struct list_head		children;
 	struct dentry			*dentry; /* Check is_freed to access */
-	struct dentry			*d_parent;
 	struct dentry			**d_children;
 	struct eventfs_attr		*entry_attrs;
 	struct eventfs_attr		attr;