From patchwork Sun Feb 4 01:16:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 196390 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp147986dyb; Sat, 3 Feb 2024 17:22:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IHUCrCqTE/imKhpQVRK+9CAc/+2ezEshrtSgwfSbs9KxqK4LWfl2GMfLLqW1QLR+40akvKX X-Received: by 2002:a05:620a:c17:b0:784:af9:6fa9 with SMTP id l23-20020a05620a0c1700b007840af96fa9mr8260700qki.78.1707009723440; Sat, 03 Feb 2024 17:22:03 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707009723; cv=pass; d=google.com; s=arc-20160816; b=lBorJL/bhUtw2kY5OW84Oqoteab3vKl5M7reYAqD5mRpdgd4GptGm+cd7ohd3SqCvc rRZixvEhQBhMpvwkW4UUiFKWMxEJTeWmMh3dQh+uXJSX7qJxKJ2JK1vBg7PxQyMKlwXb HcmmobtIqXe2tF8Sqt7LQ5WSoutEqdWg3PKSX4AkeUCwZPyumDXOG1SR07H8jGpY6Cvg 1GyE5BCJOhh64UH28GHeJavul6uypjCnb8n4Nwf4pkwoYMliFThsJq8bFvsqcuklQli1 FuWkZHFdBDJWrRGw79fvuH6TU+sIHf0Kqg29UvJqJV6SD0W8nubVxj8Q/ROAUorTu9GH BZ4A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:subject:cc:to:from:date:user-agent:message-id; bh=Y0oO9OYv4fsUuM0r75f6NybcP+SEzVd4nX4k5C6cREM=; fh=APpePMExRUn7uLVWZW3BwtR9nObY8Cf9bmjDzr2ywBc=; b=tkKXC6X1L+nCQ4gqlXEM0X/uiwEnMvf1awXs8S4ogpcvURfonjuUJezdNUv8xg4s+7 1SKGFYIOlowYyGKKyMHts7RqC2PlPCDXebzR7UtFWRRIwD9O8xRlsQZZI0GgHrEpeK39 a5k6wCe0YJPleAvTQHqmdrk6Udgf0UgpxFIR9QLSR20TJFybVKXpBQJmy7LFZrL4kCFQ Rj9DhGeaQoR9ptmXvxQqao000ECg0Bj8SHRZlDmwBVT3XKirxYI7GgLfZZIlq6budZb2 ykyVF47VYasdrdI6gCevVJYCJ5RdQCBI22IEpJVR78LupI5/gFvyFCxiR2q2ICQDYISp V2OQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-51349-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-51349-ouuuleilei=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=1; AJvYcCXKrTy2tjyOOsVPAQb1KgMk2rmECfKdaT5Poo6fWzbhndruxAWrNiLQ4ZODsBJvlrB+Kblza2vf2iwHtuctdNkK8tS1JA== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id d17-20020a05620a241100b007855ec2861dsi3813993qkn.338.2024.02.03.17.22.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Feb 2024 17:22:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-51349-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-51349-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-51349-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 4043E1C229AA for ; Sun, 4 Feb 2024 01:22:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EC4F3168DF; Sun, 4 Feb 2024 01:18:10 +0000 (UTC) Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D9CFB651; Sun, 4 Feb 2024 01:18:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707009487; cv=none; b=T214Iq8Y8ycUi3nZW4CPehSz+olYrgxiedbl4tEyNVqkHc2fg+DGUGq3g9nWx0RcIcGzqPbrP0mg6/zagaUJ6sMZb2KTwaVzitOoHBrYPkPu2XxFK3qE2HGcWf2vh3zRtPzBk71lJkTOBCM8vN6Oea2wlsZL1cXoXjJCqgC42I8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707009487; c=relaxed/simple; bh=RnbwjrjDZZt5dBQ8lSVav9CcZQtdfsC0kXd6oQD/gQw=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=DEyjiCbAG8wFfMawl4qqd/UAILFK2WYb9CZoLrvH56Cttg4GmoPYdf/wrzqHC2ZENh9URxK9aDZpvULB1VkjQNMCc5O8kW5tH2dugwV1gklUVsYL6YDaSVSMH2SluQFHD0V8QhtBps4wXIhA6ahLvHvP+qd74Ko0NNhB0ByVDu4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4EE90C3279D; Sun, 4 Feb 2024 01:18:06 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.97) (envelope-from ) id 1rWR9Q-00000006OqM-497i; Sat, 03 Feb 2024 20:18:28 -0500 Message-ID: <20240204011828.840729219@goodmis.org> User-Agent: quilt/0.67 Date: Sat, 03 Feb 2024 20:16:27 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Linus Torvalds , Greg Kroah-Hartman , Sasha Levin , Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton Subject: [v6.7][PATCH 12/23] tracefs: remove stale update_gid code References: <20240204011615.703023949@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789929428142774704 X-GMAIL-MSGID: 1789929428142774704 From: Linus Torvalds The 'eventfs_update_gid()' function is no longer called, so remove it (and the helper function it uses). Link: https://lore.kernel.org/all/CAHk-=wj+DsZZ=2iTUkJ-Nojs9fjYMvPs1NuoM3yK7aTDtJfPYQ@mail.gmail.com/ Fixes: 8186fff7ab64 ("tracefs/eventfs: Use root and instance inodes as default ownership") Signed-off-by: Linus Torvalds Signed-off-by: Steven Rostedt (Google) --- fs/tracefs/event_inode.c | 38 -------------------------------------- fs/tracefs/internal.h | 1 - 2 files changed, 39 deletions(-) diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c index 6b211522a13e..1c3dd0ad4660 100644 --- a/fs/tracefs/event_inode.c +++ b/fs/tracefs/event_inode.c @@ -281,44 +281,6 @@ static void update_inode_attr(struct dentry *dentry, struct inode *inode, inode->i_gid = attr->gid; } -static void update_gid(struct eventfs_inode *ei, kgid_t gid, int level) -{ - struct eventfs_inode *ei_child; - - /* at most we have events/system/event */ - if (WARN_ON_ONCE(level > 3)) - return; - - ei->attr.gid = gid; - - if (ei->entry_attrs) { - for (int i = 0; i < ei->nr_entries; i++) { - ei->entry_attrs[i].gid = gid; - } - } - - /* - * Only eventfs_inode with dentries are updated, make sure - * all eventfs_inodes are updated. If one of the children - * do not have a dentry, this function must traverse it. - */ - list_for_each_entry_srcu(ei_child, &ei->children, list, - srcu_read_lock_held(&eventfs_srcu)) { - if (!ei_child->dentry) - update_gid(ei_child, gid, level + 1); - } -} - -void eventfs_update_gid(struct dentry *dentry, kgid_t gid) -{ - struct eventfs_inode *ei = dentry->d_fsdata; - int idx; - - idx = srcu_read_lock(&eventfs_srcu); - update_gid(ei, gid, 0); - srcu_read_unlock(&eventfs_srcu, idx); -} - /** * create_file - create a file in the tracefs filesystem * @name: the name of the file to create. diff --git a/fs/tracefs/internal.h b/fs/tracefs/internal.h index 45397df9bb65..91c2bf0b91d9 100644 --- a/fs/tracefs/internal.h +++ b/fs/tracefs/internal.h @@ -82,7 +82,6 @@ struct inode *tracefs_get_inode(struct super_block *sb); struct dentry *eventfs_start_creating(const char *name, struct dentry *parent); struct dentry *eventfs_failed_creating(struct dentry *dentry); struct dentry *eventfs_end_creating(struct dentry *dentry); -void eventfs_update_gid(struct dentry *dentry, kgid_t gid); void eventfs_set_ei_status_free(struct tracefs_inode *ti, struct dentry *dentry); #endif /* _TRACEFS_INTERNAL_H */