diff mbox series

w1: make w1_bus_type const

Message ID 20240204-bus_cleanup-w1-v1-1-a0f4c84d7db3@marliere.net
State New
Headers
Series w1: make w1_bus_type const |

Commit Message

Ricardo B. Marliere Feb. 4, 2024, 8:55 p.m. UTC 
  Now that the driver core can properly handle constant struct bus_type,
move the w1_bus_type variable to be a constant structure as well,
placing it into read-only memory which can not be modified at runtime.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
 drivers/w1/w1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


---
base-commit: 41b9fb381a486360b2daaec0c7480f8e3ff72bc7
change-id: 20240204-bus_cleanup-w1-e46a15c8237f

Best regards,

Comments

Krzysztof Kozlowski Feb. 5, 2024, 7:34 a.m. UTC | #1 
On 04/02/2024 21:55, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,

Does "Now" means some dependency on other patches?

> move the w1_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.

Best regards,
Krzysztof
Ricardo B. Marliere Feb. 5, 2024, 12:08 p.m. UTC | #2 
On  5 Feb 08:34, Krzysztof Kozlowski wrote:
> On 04/02/2024 21:55, Ricardo B. Marliere wrote:
> > Now that the driver core can properly handle constant struct bus_type,
> 
> Does "Now" means some dependency on other patches?

Hi Krzysztof!

Please check:
https://lore.kernel.org/all/1305850262-9575-5-git-send-email-gregkh@suse.de/

You can apply as is.

Thanks for reviewing,
-	Ricardo


> 
> > move the w1_bus_type variable to be a constant structure as well,
> > placing it into read-only memory which can not be modified at runtime.
> 
> Best regards,
> Krzysztof
>
Krzysztof Kozlowski Feb. 5, 2024, 12:30 p.m. UTC | #3 
On Sun, 04 Feb 2024 17:55:22 -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the w1_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
> 
> 

Applied, thanks!

[1/1] w1: make w1_bus_type const
      https://git.kernel.org/krzk/linux-w1/c/8650843ca42a7fd8255f4dcddbaa20393e01fe11

Best regards,
Greg KH Feb. 5, 2024, 12:46 p.m. UTC | #4 
On Sun, Feb 04, 2024 at 05:55:22PM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the w1_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
> ---
>  drivers/w1/w1.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg KH Feb. 5, 2024, 7:08 p.m. UTC | #5 
On Mon, Feb 05, 2024 at 09:08:20AM -0300, Ricardo B. Marliere wrote:
> On  5 Feb 08:34, Krzysztof Kozlowski wrote:
> > On 04/02/2024 21:55, Ricardo B. Marliere wrote:
> > > Now that the driver core can properly handle constant struct bus_type,
> > 
> > Does "Now" means some dependency on other patches?
> 
> Hi Krzysztof!
> 
> Please check:
> https://lore.kernel.org/all/1305850262-9575-5-git-send-email-gregkh@suse.de/

Sorry, no, that is for device_type, not bus_type.  bus_type didn't
become able to be const until 6.4 or so.

thanks,

greg k-h
Ricardo B. Marliere Feb. 5, 2024, 8:12 p.m. UTC | #6 
On  5 Feb 19:08, Greg Kroah-Hartman wrote:
> On Mon, Feb 05, 2024 at 09:08:20AM -0300, Ricardo B. Marliere wrote:
> > On  5 Feb 08:34, Krzysztof Kozlowski wrote:
> > > On 04/02/2024 21:55, Ricardo B. Marliere wrote:
> > > > Now that the driver core can properly handle constant struct bus_type,
> > > 
> > > Does "Now" means some dependency on other patches?
> > 
> > Hi Krzysztof!
> > 
> > Please check:
> > https://lore.kernel.org/all/1305850262-9575-5-git-send-email-gregkh@suse.de/
> 
> Sorry, no, that is for device_type, not bus_type.  bus_type didn't
> become able to be const until 6.4 or so.

Ah yes, sorry. The correct link should be:
https://lore.kernel.org/all/20230313182918.1312597-35-gregkh@linuxfoundation.org/

> 
> thanks,
> 
> greg k-h
diff mbox series

Patch

diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index 5353cbd75126..afb1cc4606c5 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -167,7 +167,7 @@  static struct w1_family w1_default_family = {
 
 static int w1_uevent(const struct device *dev, struct kobj_uevent_env *env);
 
-static struct bus_type w1_bus_type = {
+static const struct bus_type w1_bus_type = {
 	.name = "w1",
 	.uevent = w1_uevent,
 };