diff mbox series

memstick: core: make memstick_bus_type const

Message ID 20240204-bus_cleanup-memstick-v1-1-14809d4405d8@marliere.net
State New
Headers
Series memstick: core: make memstick_bus_type const |

Commit Message

Ricardo B. Marliere Feb. 4, 2024, 8:05 p.m. UTC 
  Now that the driver core can properly handle constant struct bus_type,
move the memstick_bus_type variable to be a constant structure as well,
placing it into read-only memory which can not be modified at runtime.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
 drivers/memstick/core/memstick.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


---
base-commit: 4e99ffb173faaf38f010acb369bff57a20e9e531
change-id: 20240204-bus_cleanup-memstick-071b3564d808

Best regards,

Comments

Greg KH Feb. 5, 2024, 12:48 p.m. UTC | #1 
On Sun, Feb 04, 2024 at 05:05:58PM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the memstick_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ulf Hansson Feb. 5, 2024, 5:28 p.m. UTC | #2 
On Sun, 4 Feb 2024 at 21:05, Ricardo B. Marliere <ricardo@marliere.net> wrote:
>
> Now that the driver core can properly handle constant struct bus_type,
> move the memstick_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/memstick/core/memstick.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/memstick/core/memstick.c b/drivers/memstick/core/memstick.c
> index bbfaf6536903..23fea51ecbdd 100644
> --- a/drivers/memstick/core/memstick.c
> +++ b/drivers/memstick/core/memstick.c
> @@ -164,7 +164,7 @@ static struct attribute *memstick_dev_attrs[] = {
>  };
>  ATTRIBUTE_GROUPS(memstick_dev);
>
> -static struct bus_type memstick_bus_type = {
> +static const struct bus_type memstick_bus_type = {
>         .name           = "memstick",
>         .dev_groups     = memstick_dev_groups,
>         .match          = memstick_bus_match,
>
> ---
> base-commit: 4e99ffb173faaf38f010acb369bff57a20e9e531
> change-id: 20240204-bus_cleanup-memstick-071b3564d808
>
> Best regards,
> --
> Ricardo B. Marliere <ricardo@marliere.net>
>
diff mbox series

Patch

diff --git a/drivers/memstick/core/memstick.c b/drivers/memstick/core/memstick.c
index bbfaf6536903..23fea51ecbdd 100644
--- a/drivers/memstick/core/memstick.c
+++ b/drivers/memstick/core/memstick.c
@@ -164,7 +164,7 @@  static struct attribute *memstick_dev_attrs[] = {
 };
 ATTRIBUTE_GROUPS(memstick_dev);
 
-static struct bus_type memstick_bus_type = {
+static const struct bus_type memstick_bus_type = {
 	.name           = "memstick",
 	.dev_groups	= memstick_dev_groups,
 	.match          = memstick_bus_match,