diff mbox series

arm: s3c64xx: make s3c64xx_subsys const

Message ID 20240204-bus_cleanup-arm-v1-1-41d651dd8411@marliere.net
State New
Headers
Series arm: s3c64xx: make s3c64xx_subsys const |

Commit Message

Ricardo B. Marliere Feb. 4, 2024, 2:46 p.m. UTC 
  Now that the driver core can properly handle constant struct bus_type,
move the s3c64xx_subsys variable to be a constant structure as well,
placing it into read-only memory which can not be modified at runtime.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
 arch/arm/mach-s3c/s3c64xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


---
base-commit: 8f5b7dbc644d6217a2fd35cb82594b215818eb16
change-id: 20240204-bus_cleanup-arm-391704e66efc

Best regards,

Comments

Greg KH Feb. 4, 2024, 2:52 p.m. UTC | #1 
On Sun, Feb 04, 2024 at 11:46:21AM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the s3c64xx_subsys variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
> ---
>  arch/arm/mach-s3c/s3c64xx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Krzysztof Kozlowski Feb. 5, 2024, 7:35 a.m. UTC | #2 
On 04/02/2024 15:46, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,

Is there any dependency?

> move the s3c64xx_subsys variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
> 


Best regards,
Krzysztof
Krzysztof Kozlowski Feb. 5, 2024, 12:32 p.m. UTC | #3 
On Sun, 04 Feb 2024 11:46:21 -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the s3c64xx_subsys variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
> 
> 

Applied, thanks!

[1/1] arm: s3c64xx: make s3c64xx_subsys const
      https://git.kernel.org/krzk/linux/c/db085a6c66337799ad5983c5c6d4b1d8386f4256

Best regards,
diff mbox series

Patch

diff --git a/arch/arm/mach-s3c/s3c64xx.c b/arch/arm/mach-s3c/s3c64xx.c
index 9f9717874d67..6c70ea7f2931 100644
--- a/arch/arm/mach-s3c/s3c64xx.c
+++ b/arch/arm/mach-s3c/s3c64xx.c
@@ -149,7 +149,7 @@  static struct map_desc s3c_iodesc[] __initdata = {
 	},
 };
 
-static struct bus_type s3c64xx_subsys = {
+static const struct bus_type s3c64xx_subsys = {
 	.name		= "s3c64xx-core",
 	.dev_name	= "s3c64xx-core",
 };