[PATCH-wq,v2,1/5] workqueue: Skip __WQ_DESTROYING workqueues when updating global unbound cpumask

Message ID 20240203154334.791910-2-longman@redhat.com
State New
Headers
Series workqueue: Enable unbound cpumask update on ordered workqueues |

Commit Message

Waiman Long Feb. 3, 2024, 3:43 p.m. UTC
  Skip updating workqueues with __WQ_DESTROYING bit set when updating
global unbound cpumask to avoid unnecessary work and other complications.

Signed-off-by: Waiman Long <longman@redhat.com>
---
 kernel/workqueue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Tejun Heo Feb. 5, 2024, 6 p.m. UTC | #1
Hello,

On Sat, Feb 03, 2024 at 10:43:30AM -0500, Waiman Long wrote:
> Skip updating workqueues with __WQ_DESTROYING bit set when updating
> global unbound cpumask to avoid unnecessary work and other complications.
> 
> Signed-off-by: Waiman Long <longman@redhat.com>

Applied to wq/for-6.9.

Thanks.
  

Patch

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index ffb625db9771..7ef393f4012e 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -6313,7 +6313,7 @@  static int workqueue_apply_unbound_cpumask(const cpumask_var_t unbound_cpumask)
 	lockdep_assert_held(&wq_pool_mutex);
 
 	list_for_each_entry(wq, &workqueues, list) {
-		if (!(wq->flags & WQ_UNBOUND))
+		if (!(wq->flags & WQ_UNBOUND) || (wq->flags & __WQ_DESTROYING))
 			continue;
 
 		/* creating multiple pwqs breaks ordering guarantee */