diff mbox series

[1/3] dt-bindings: arm: qcom: Document rb5gen2-hdk board

Message ID 20240202133638.4720-2-quic_wasimn@quicinc.com
State New
Headers
Series arm64: qcom: add support for QCS8550 RB5gen2 HDK board |

Commit Message

Wasim Nazir Feb. 2, 2024, 1:36 p.m. UTC 
  Document board bindings for Rb5 gen2 hardware development kit.
Rb5gen2-HDK is using Rb5 gen2 SOM which is based on QCS8550 SoC.
RB5gen2-HDK is development kit used for IOT solutions.

Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com>

--
2.43.0

Comments

Krzysztof Kozlowski Feb. 2, 2024, 2:34 p.m. UTC | #1 
On 02/02/2024 14:36, Wasim Nazir wrote:
> Document board bindings for Rb5 gen2 hardware development kit.
> Rb5gen2-HDK is using Rb5 gen2 SOM which is based on QCS8550 SoC.
> RB5gen2-HDK is development kit used for IOT solutions.
> 
> Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com>
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 9cee874a8eae..ce5b5dfe0e46 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -104,6 +104,7 @@ description: |
>          qcp
>          qrd
>          rb2
> +        rb5gen2-hdk

I think we decided to stop growing this, especially that "rb5gen2-hdk"
does not look generic type of a board.

> --
> 2.43.0
> 

Best regards,
Krzysztof
Dmitry Baryshkov Feb. 2, 2024, 2:51 p.m. UTC | #2 
On Fri, 2 Feb 2024 at 15:37, Wasim Nazir <quic_wasimn@quicinc.com> wrote:
>
> Document board bindings for Rb5 gen2 hardware development kit.
> Rb5gen2-HDK is using Rb5 gen2 SOM which is based on QCS8550 SoC.
> RB5gen2-HDK is development kit used for IOT solutions.

What is the actual marketing name for the SoM and the carrier board?
The RB5gen2-HDK doesn't follow the previous example of the RB* boards
and doesn't sound in tune with the RB3gen2 submission.
Could you please sync up internally and come up with two similar names
for the platforms with similar purpose?

>
> Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com>
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 9cee874a8eae..ce5b5dfe0e46 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -104,6 +104,7 @@ description: |
>          qcp
>          qrd
>          rb2
> +        rb5gen2-hdk
>          ride
>          sbc
>          x100
> @@ -915,6 +916,14 @@ properties:
>            - const: qcom,qcm8550
>            - const: qcom,sm8550
>
> +      - items:
> +          - enum:
> +              - qcom,qcs8550-rb5gen2-hdk
> +          - const: qcom,qcs8550-rb5gen2
> +          - const: qcom,qcs8550
> +          - const: qcom,qcm8550
> +          - const: qcom,sm8550
> +
>        - items:
>            - enum:
>                - qcom,sa8155p-adp
> --
> 2.43.0
>
>
Wasim Nazir Feb. 27, 2024, 6:46 a.m. UTC | #3 
On 2/2/2024 8:04 PM, Krzysztof Kozlowski wrote:
> On 02/02/2024 14:36, Wasim Nazir wrote:
>> Document board bindings for Rb5 gen2 hardware development kit.
>> Rb5gen2-HDK is using Rb5 gen2 SOM which is based on QCS8550 SoC.
>> RB5gen2-HDK is development kit used for IOT solutions.
>>
>> Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com>
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index 9cee874a8eae..ce5b5dfe0e46 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -104,6 +104,7 @@ description: |
>>           qcp
>>           qrd
>>           rb2
>> +        rb5gen2-hdk
> 
> I think we decided to stop growing this, especially that "rb5gen2-hdk"
> does not look generic type of a board.
> 
Will remove this in next patch version.

>> --
>> 2.43.0
>>
> 
> Best regards,
> Krzysztof
> 

Thanks & regards,
Wasim
Wasim Nazir Feb. 27, 2024, 6:52 a.m. UTC | #4 
On 2/2/2024 8:21 PM, Dmitry Baryshkov wrote:
> On Fri, 2 Feb 2024 at 15:37, Wasim Nazir <quic_wasimn@quicinc.com> wrote:
>>
>> Document board bindings for Rb5 gen2 hardware development kit.
>> Rb5gen2-HDK is using Rb5 gen2 SOM which is based on QCS8550 SoC.
>> RB5gen2-HDK is development kit used for IOT solutions.
> 
> What is the actual marketing name for the SoM and the carrier board?
> The RB5gen2-HDK doesn't follow the previous example of the RB* boards
> and doesn't sound in tune with the RB3gen2 submission.
> Could you please sync up internally and come up with two similar names
> for the platforms with similar purpose?
> 
Discussed internally and we concluded on these official names, will 
update accordingly in next patch.

SOM: qcs8550-rb5gen2-som.dtsi
Board: qcs8550-rb5gen2.dts

>>
>> Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com>
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index 9cee874a8eae..ce5b5dfe0e46 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -104,6 +104,7 @@ description: |
>>           qcp
>>           qrd
>>           rb2
>> +        rb5gen2-hdk
>>           ride
>>           sbc
>>           x100
>> @@ -915,6 +916,14 @@ properties:
>>             - const: qcom,qcm8550
>>             - const: qcom,sm8550
>>
>> +      - items:
>> +          - enum:
>> +              - qcom,qcs8550-rb5gen2-hdk
>> +          - const: qcom,qcs8550-rb5gen2
>> +          - const: qcom,qcs8550
>> +          - const: qcom,qcm8550
>> +          - const: qcom,sm8550
>> +
>>         - items:
>>             - enum:
>>                 - qcom,sa8155p-adp
>> --
>> 2.43.0
>>
>>
> 
> 

Thanks & Regards,
Wasim
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 9cee874a8eae..ce5b5dfe0e46 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -104,6 +104,7 @@  description: |
         qcp
         qrd
         rb2
+        rb5gen2-hdk
         ride
         sbc
         x100
@@ -915,6 +916,14 @@  properties:
           - const: qcom,qcm8550
           - const: qcom,sm8550

+      - items:
+          - enum:
+              - qcom,qcs8550-rb5gen2-hdk
+          - const: qcom,qcs8550-rb5gen2
+          - const: qcom,qcs8550
+          - const: qcom,qcm8550
+          - const: qcom,sm8550
+
       - items:
           - enum:
               - qcom,sa8155p-adp