diff mbox series

[v1,2/2] of: property: Improve finding the supplier of a remote-endpoint property

Message ID 20240202101326.876070-3-saravanak@google.com
State New
Headers
Series Improve remote-endpoint parsing |

Commit Message

Saravana Kannan Feb. 2, 2024, 10:13 a.m. UTC 
  After commit 4a032827daa8 ("of: property: Simplify of_link_to_phandle()"),
remote-endpoint properties created a fwnode link from the consumer device
to the supplier endpoint. This is a tiny bit inefficient (not buggy) when
trying to create device links or detecting cycles. So, improve this the
same way we improved finding the consumer of a remote-endpoint property.

Fixes: 4a032827daa8 ("of: property: Simplify of_link_to_phandle()")
Signed-off-by: Saravana Kannan <saravanak@google.com>
---
 drivers/of/property.c | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/of/property.c b/drivers/of/property.c
index ba374a1f2072..6c168446b647 100644
--- a/drivers/of/property.c
+++ b/drivers/of/property.c
@@ -1232,7 +1232,6 @@  DEFINE_SIMPLE_PROP(pinctrl5, "pinctrl-5", NULL)
 DEFINE_SIMPLE_PROP(pinctrl6, "pinctrl-6", NULL)
 DEFINE_SIMPLE_PROP(pinctrl7, "pinctrl-7", NULL)
 DEFINE_SIMPLE_PROP(pinctrl8, "pinctrl-8", NULL)
-DEFINE_SIMPLE_PROP(remote_endpoint, "remote-endpoint", NULL)
 DEFINE_SIMPLE_PROP(pwms, "pwms", "#pwm-cells")
 DEFINE_SIMPLE_PROP(resets, "resets", "#reset-cells")
 DEFINE_SIMPLE_PROP(leds, "leds", NULL)
@@ -1303,6 +1302,24 @@  static struct device_node *get_remote_endpoint_dev(struct device_node *np)
 	return to_of_node(fwnode_graph_get_port_parent(of_fwnode_handle(np)));
 }
 
+static struct device_node *parse_remote_endpoint(struct device_node *np,
+						 const char *prop_name,
+						 int index)
+{
+	struct device_node *endpoint, *sup;
+
+	if (strcmp(prop_name, "remote-endpoint"))
+		return NULL;
+
+	endpoint = of_parse_phandle(np, prop_name, index);
+	if (!endpoint)
+		return NULL;
+
+	sup = get_remote_endpoint_dev(endpoint);
+	of_node_put(endpoint);
+	return sup;
+}
+
 static const struct supplier_bindings of_supplier_bindings[] = {
 	{ .parse_prop = parse_clocks, },
 	{ .parse_prop = parse_interconnects, },