From patchwork Thu Feb 1 20:12:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 195450 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2719:b0:106:209c:c626 with SMTP id hl25csp423611dyb; Thu, 1 Feb 2024 12:13:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IFD6YbtTM2iqlbgONGp0JhdtmGBMzfoj4GZCjp6BXsVaoAIIPRtLW8KuIY/Z2nYFytO348L X-Received: by 2002:a17:903:280d:b0:1d8:e05d:7a16 with SMTP id kp13-20020a170903280d00b001d8e05d7a16mr3135753plb.56.1706818423181; Thu, 01 Feb 2024 12:13:43 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706818423; cv=pass; d=google.com; s=arc-20160816; b=ti6KUn6+UeHFCQN9fPs4jo2lY1STDdnROwnKQmIknBrx1yPAURlSZCt96t0HXlMD27 nU91V6dkaE/is132exOLt1ljrZAhjTAcJQZk80CBWHRo5CzbPpnDnoWEfAh836QFW5QB AQ2p9tIqLgUghrvG4LFsEr6Cv/pUcYGucTjm0Ozlh5XkVfNC2rHexHlafFF+t2W9f3Qs rKpyA1EBRpgyBKEeo2jOq0JuXiAQHe+oyidjOrxVBzgRnJ5VxxrLxzFCCjuP7AvkhsAn Npmtze48IwsKTiQO8ot6ZXaDwsv1vr/CP5vw9Eh5Zcq1Sqn+cELbr2QDdiV1XbUdUyvY OQHQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=R7QEV01xCBNWzJgsFvAy5/1O3rW/XxKsJIx3OsRL5eg=; fh=pspni5UEnfSyWBNbmBRr5NQfqo/EXUKA6AsbTEAm0h4=; b=NtpfuhVmIXpyWpLglLUG7Uov4C4DJCD1lfgWBZc/nESJl8SQbEgfNrlC+9qFUIYso+ BLJoZ7PJVvJBNCrVURjjr0Fi9o58SRYhlxCwXJXdrmTjA2Kmn5+QycDFwsR8SBcWTa7V ZSrlnrABtWfmBnamkY9yi6SEeN/4onu9rREXJF4Hqp2FVL1HFMnT5Npz1FaM0hjr/zl7 Jgc9vZqo45WKAuj2VG2uSJTUmF/aSXdDq7lC6UfFJB3xTOFn4teMNLq415B2qGuTR+6r YEKHSDNAOmWmo8b/y4dGr8z9nEnh0rz+I6befx+cCTZJ9fKC+mDwfibdjGaCOq0UuBQ/ tDBg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=kMohdYAY; arc=pass (i=1 spf=pass spfdomain=baylibre.com dkim=pass dkdomain=baylibre-com.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-48805-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-48805-ouuuleilei=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=1; AJvYcCUNY4zvKPAEhc3FaZcNaJe8Ry+BE2zjF9vQxUXfcyY7u34+Y25k/tpvVfEJqstZRcPtiQPqaOGQ3iP1O1u+vOwjxIp3RA== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id iy5-20020a170903130500b001d8d747a082si365239plb.71.2024.02.01.12.13.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Feb 2024 12:13:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-48805-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=kMohdYAY; arc=pass (i=1 spf=pass spfdomain=baylibre.com dkim=pass dkdomain=baylibre-com.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-48805-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-48805-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id EB75128C725 for ; Thu, 1 Feb 2024 20:13:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D4A0F85645; Thu, 1 Feb 2024 20:13:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="kMohdYAY" Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AACD08528E for ; Thu, 1 Feb 2024 20:13:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706818404; cv=none; b=hZy7g0DmOxKWexZrdQfxzIxvoLGvnRkKpQTLiE0QeH7OkEYkmnGFCZUpSdLE/6uMFcoBi4MCmIYft50O4PYk6ZzJZ+swbskalcndNl2CqMQteToATuvUyY2ieyxlBcvBN8HgrN3qOKsUmHvymtftgNQO+lt/iOQNlBBYAa36BP8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706818404; c=relaxed/simple; bh=SaYp12yVhP5xqyfZ63zxjEKPgF9qCcamsC7VKIEPxjA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=D/K+gH1Sm9jG+XnthQZpc5NxOI4KPZSmpnHIbMAA8t+dG/hJsG6Y9YHO7f44oFT7ROIGOPrwjJgTdgNKXkqq2T4zNPiQM2KVCjiGEzxGeUFaMtUcpaeQ1EJLcfX9HTjgjV8AKBhNk6zaWEJuG/nGrBBXN8N4a+13QtYE7f0A/PA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=kMohdYAY; arc=none smtp.client-ip=209.85.210.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-6e11283948eso666793a34.3 for ; Thu, 01 Feb 2024 12:13:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1706818400; x=1707423200; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=R7QEV01xCBNWzJgsFvAy5/1O3rW/XxKsJIx3OsRL5eg=; b=kMohdYAYzDNWeOlMt/5fNf1WaOjuYJsSqZSEjfpxQmIfwtYB1ZmfaVChdWrgleZmP4 Nukn3dMKIdLCoc3RisUrvxP2FK9RHYWQB3U2f1kObz6ADyEQDsXvvBFvUP1nDLkE79Xp RW/VOTOkECabTR2wsl1QSUNXDPjvg4F8u1GOFAAH9Rl8GlUixZQVIgm2RyRLH7E1jogo gVfjKNsCNitGSiCF7zoCxq1owPol7lPeAv0lQRJuhmuH/n/nWkqb4WwNfMyEe1kZp1Fk RdzpkuW3D0SzxYf9klkyuqP81I1iu9NcK7JPr4jfaiXNmVXFAaWhNDOeFV3VNKDHAymT LY7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706818400; x=1707423200; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R7QEV01xCBNWzJgsFvAy5/1O3rW/XxKsJIx3OsRL5eg=; b=tV3ChceqSEaXJw1R0WFcuhMUhnHOK/T4OroMTwtdOAatP3UFQBLBOiESQFOAM9WVZn F92S0IrQ68GEiJNfsY8K1iLNMjRX2OBTZXqECKvayBhA8g1yIKKmOFdtOvX9vxDHv9p/ kQX2b5q2bce4nFB0866otrBM/lxN4HddQTo6fBkTIOXXa6aYq00+pv37SzwaFHpjDi4+ 8KS27MCnF8+3lZMzjGPUDEZXWsVAeib/9V/mpjhl5FimeuJrhElUG3OViYPXXjfqgfaH GOS2U9ezBOe/hvqxAnZuofqsl/k4Ee/r02K9X4PRfPtgyY6PoCw0FgNj5/m8DAyc2Taf 73bg== X-Gm-Message-State: AOJu0YzipV/vYCKXjqL/oGz6NFNjPmaXqI6yAQfABL3QiPS3tLuKETAQ 1N7sBAvGtSKvWjK2p0adcgMrd5bAWi99/YV9XVsGoY/uNdra4jN/5a4aKXTgIec= X-Received: by 2002:a9d:63da:0:b0:6e2:78db:c405 with SMTP id e26-20020a9d63da000000b006e278dbc405mr1831965otl.21.1706818399695; Thu, 01 Feb 2024 12:13:19 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCU8yBM3TZmRzH+7atNVE1qB1Ckhad3RV1uP0C2+FQQ1kx05pv9bnOOX6YjqB1Ovc23NOF8DIvDZhD4F3ZE5eNJZ/pDxZyIQVDDYYrdlhYdtwvxoFYyS2bW83swGY6A//inIJeTBq0uVuc7vvmpk87i55X/VMYXy6tJmXkR6aOSxhrrJgYgkmkEFQwDvtotIqeWxsTPBQcA/TolKetlOrnR9zw== Received: from freyr.lechnology.com (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id k11-20020a056830150b00b006e11c86f1aesm89239otp.60.2024.02.01.12.13.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Feb 2024 12:13:19 -0800 (PST) From: David Lechner To: Kalle Valo Cc: David Lechner , Ajay Singh , Claudiu Beznea , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] wifi: wilc1000: remove setting msg.spi Date: Thu, 1 Feb 2024 14:12:47 -0600 Message-ID: <20240201201248.2334798-2-dlechner@baylibre.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789728834525102333 X-GMAIL-MSGID: 1789728834525102333 Calling spi_sync() unconditionally sets the spi field of struct spi_message. Therefore setting msg.spi = spi before calling spi_sync() has no effect and can be removed. (spi_message_add_tail() does not access this field.) Signed-off-by: David Lechner --- v2 changes: * fixed incomplete commit message Link to v1: https://patchwork.kernel.org/project/linux-wireless/patch/20240123212135.2607178-1-dlechner@baylibre.com/ drivers/net/wireless/microchip/wilc1000/spi.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/wireless/microchip/wilc1000/spi.c b/drivers/net/wireless/microchip/wilc1000/spi.c index 77b4cdff73c3..7eb0f8a421a3 100644 --- a/drivers/net/wireless/microchip/wilc1000/spi.c +++ b/drivers/net/wireless/microchip/wilc1000/spi.c @@ -300,7 +300,6 @@ static int wilc_spi_tx(struct wilc *wilc, u8 *b, u32 len) memset(&msg, 0, sizeof(msg)); spi_message_init(&msg); - msg.spi = spi; spi_message_add_tail(&tr, &msg); ret = spi_sync(spi, &msg); @@ -343,7 +342,6 @@ static int wilc_spi_rx(struct wilc *wilc, u8 *rb, u32 rlen) memset(&msg, 0, sizeof(msg)); spi_message_init(&msg); - msg.spi = spi; spi_message_add_tail(&tr, &msg); ret = spi_sync(spi, &msg); @@ -381,8 +379,6 @@ static int wilc_spi_tx_rx(struct wilc *wilc, u8 *wb, u8 *rb, u32 rlen) memset(&msg, 0, sizeof(msg)); spi_message_init(&msg); - msg.spi = spi; - spi_message_add_tail(&tr, &msg); ret = spi_sync(spi, &msg); if (ret < 0)