From patchwork Thu Feb 1 11:54:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: alexs@kernel.org X-Patchwork-Id: 195249 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2719:b0:106:209c:c626 with SMTP id hl25csp91858dyb; Thu, 1 Feb 2024 03:52:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IEczjnWwXgy/C1MlANlEYjvrqfL1TmIBE/MUNghlHGbLppXgrlvP2PO9MWIKPHAkg51QAFR X-Received: by 2002:a17:906:1956:b0:a35:84fa:6d85 with SMTP id b22-20020a170906195600b00a3584fa6d85mr3045427eje.72.1706788347180; Thu, 01 Feb 2024 03:52:27 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706788347; cv=pass; d=google.com; s=arc-20160816; b=URkm0GfDFqAik3v8EuVffLkyO1A0qQETIk1ipf3g620lqtui9pba9U69XHpeaZRwBg N3/FljkwkyzMrsE4v0qbLkoE3Wd/JS5M4SKybDRK6g7RUklwwD86NF/wLIgDwLRHfhFu ZVXaYHWQxqRgTiEWDwF3xzpI9d3r7eny0rKxHmtJuxf8SXSt4lw/5oVSAHAaepvGFlkB 7IUCFgrCNph164CuAr8+x/WRJa3isg/w6LT0niJH0QaPCuBJn9qroJ4yMTonIgLQcYMF 5r4SXcgJPoaFt6f1hoQqxaayRnrqB1HOb8RWK42o67X3OxD2PyhQGyabGjMqexj6pmPM dOUg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=rovnZYMgdqdgO5q7kI7J3tmOYFmuTAdfJJw/mzec5tk=; fh=I2KJYv1GcBpKRgDJOLBA/xpdABjx+5AqvIGTHonka3E=; b=v90ePAycGWNxsrLltRZYbevabGdspW7YTdO+5ZhpJOBfmsKHm3SVQ9dcnnYFNSeGNu BY346fGByxgMX1hURgf3wPis8i9Z2Y3tjgfM785hWnu3k3QlKJwZ7o43kBZQL2DsNIqT 5ldTT2Q+LhFZylwN4EWNTd/ekME9acXlRwBHEQjEO99vUGGpqr7dW1ipW92YCPJng7RO 3E1F4QBZXWRHrV2DBEY3rwDQO/RYjzEP0DL2EU5PuwzXXDKgz9F9BJEQA92yb/Hfu+sB n61KxepHVnX1v0WcUkFl5BYKDlMrmTwJFEQk/GBgBqfnkGLgBpiwcXPxIr/a5jvbdXyG Fxfw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=j+KXnWMX; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-48037-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-48037-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCVZBuj0CpWHR4iaEwGEuW57dBYjk85iCcGQj1KxUiap2zfleXZXtd2ndcPiLfolKAJsGHgOjjPo9ei2za/Kz4byyRaBgg== Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id bg11-20020a170906a04b00b00a35b26330acsi4179357ejb.924.2024.02.01.03.52.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Feb 2024 03:52:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-48037-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=j+KXnWMX; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-48037-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-48037-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B79A81F224DE for ; Thu, 1 Feb 2024 11:52:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1B84C15DBA0; Thu, 1 Feb 2024 11:52:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="j+KXnWMX" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C0D315D5BE for ; Thu, 1 Feb 2024 11:52:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706788320; cv=none; b=n7FNZ5ZDv2kE8jYYD1Y8UaEBCtJG82fqWHqgyqDaftRKjC/GtQ4z2i+PCfQWMGcTsQ6nBV2DuAwPmCg/aMVf72wLD+8+ircGpqEjVa2NrI49EZM5dEA642+whmgkUv8K2TjKJYbDnmE0r8+xDcrCH1eRjksS+meBTxDvBE8Lnx4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706788320; c=relaxed/simple; bh=ju/4UGtzVW6SMMVqyOTJ6eGP1qKCB+pqoyI2kbcnF5w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=otUe8GJ4a9SCqaJnihai60aUt4i6F93PH8YM18grSvyx35IFnjV4TnZb+rCnvBCpFBn6wqGCPojj09o9KzP30HJqlUv/X3vNGNWbNL0alxfjuI7vJVS2iw6n1iflrELoa033zTBLZFMbypdaO4BEVqnMBBkMXDwSzokUVdDR278= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=j+KXnWMX; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id CBE76C433F1; Thu, 1 Feb 2024 11:51:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706788319; bh=ju/4UGtzVW6SMMVqyOTJ6eGP1qKCB+pqoyI2kbcnF5w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=j+KXnWMXwhwHFTKJt6QVUJNK6XtR8bwisq9pN4aKgCFMi8QvURWfxy7fv5OVpv923 mpKvjbVUd6HL5Max7LczCta8jXD2UJl0fruvMQsTNUvBZ8zxcC3YbQe40xHf7yojaT SBRPSqFCedZtI94XKAyVRrt4Yq1n/+ZLBixZOCqah2q3lq4PTXvOM/M//SyEbdY+66 4cyD83JcN++6cKgsvw34J0fW13E2k7TPVYEI/H/U58ClB4JgDVb5uuDmHPbsVKi3Jn ycxyLj9tbJVeyHkqfZ82CFStW4/H2l8RLB58DX2oh4XOsTJC+C9hnOsy2SvAYxsx8w 2TkFTxQjlqkHw== From: alexs@kernel.org To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Daniel Bristot de Oliveira , Valentin Schneider , linux-kernel@vger.kernel.org, ricardo.neri-calderon@linux.intel.com, sshegde@linux.ibm.com Cc: Alex Shi Subject: [PATCH v3 2/4] sched/fair: remove unused parameters Date: Thu, 1 Feb 2024 19:54:45 +0800 Message-ID: <20240201115447.522627-2-alexs@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240201115447.522627-1-alexs@kernel.org> References: <20240201115447.522627-1-alexs@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789697298016210428 X-GMAIL-MSGID: 1789697298016210428 From: Alex Shi sds isn't used in function sched_asym(), so remove it to cleanup code. Signed-off-by: Alex Shi Reviewed-by: Ricardo Neri To: Valentin Schneider To: Vincent Guittot To: Juri Lelli To: Peter Zijlstra To: Ingo Molnar Reviewed-by: Valentin Schneider --- kernel/sched/fair.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 46ba8329b10a..8d70417f5125 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -9750,7 +9750,6 @@ static bool sched_use_asym_prio(struct sched_domain *sd, int cpu) /** * sched_asym - Check if the destination CPU can do asym_packing load balance * @env: The load balancing environment - * @sds: Load-balancing data with statistics of the local group * @sgs: Load-balancing statistics of the candidate busiest group * @group: The candidate busiest group * @@ -9769,8 +9768,7 @@ static bool sched_use_asym_prio(struct sched_domain *sd, int cpu) * otherwise. */ static inline bool -sched_asym(struct lb_env *env, struct sd_lb_stats *sds, struct sg_lb_stats *sgs, - struct sched_group *group) +sched_asym(struct lb_env *env, struct sg_lb_stats *sgs, struct sched_group *group) { /* Ensure that the whole local core is idle, if applicable. */ if (!sched_use_asym_prio(env->sd, env->dst_cpu)) @@ -9941,7 +9939,7 @@ static inline void update_sg_lb_stats(struct lb_env *env, /* Check if dst CPU is idle and preferred to this group */ if (!local_group && env->sd->flags & SD_ASYM_PACKING && env->idle != CPU_NOT_IDLE && sgs->sum_h_nr_running && - sched_asym(env, sds, sgs, group)) { + sched_asym(env, sgs, group)) { sgs->group_asym_packing = 1; }