iio: accel: Fix a compilation problem

Message ID 20240131225246.14169-1-mario.limonciello@amd.com
State New
Headers
Series iio: accel: Fix a compilation problem |

Commit Message

Mario Limonciello Jan. 31, 2024, 10:52 p.m. UTC
  The kernel fails when compiling without `CONFIG_REGMAP_I2C` but with
`CONFIG_BMA400`.
```
ld: drivers/iio/accel/bma400_i2c.o: in function `bma400_i2c_probe':
bma400_i2c.c:(.text+0x23): undefined reference to `__devm_regmap_init_i2c'
```

This was caught with one of the kconfigs used by the LKP robot for a
separate issue.

Link: https://download.01.org/0day-ci/archive/20240131/202401311634.FE5CBVwe-lkp@intel.com/config
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 drivers/iio/accel/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
  

Comments

Jonathan Cameron Feb. 4, 2024, 3:16 p.m. UTC | #1
On Wed, 31 Jan 2024 16:52:46 -0600
Mario Limonciello <mario.limonciello@amd.com> wrote:

> The kernel fails when compiling without `CONFIG_REGMAP_I2C` but with
> `CONFIG_BMA400`.
> ```
> ld: drivers/iio/accel/bma400_i2c.o: in function `bma400_i2c_probe':
> bma400_i2c.c:(.text+0x23): undefined reference to `__devm_regmap_init_i2c'
> ```
> 
> This was caught with one of the kconfigs used by the LKP robot for a
> separate issue.
> 
> Link: https://download.01.org/0day-ci/archive/20240131/202401311634.FE5CBVwe-lkp@intel.com/config
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

Good catch.  Ideally would have a fixes tag but it's a bit complex in this
case as they two parts landed in different series.
I've added both tags and marked it for stable.

Fixes: 465c811f1f20 ("iio: accel: Add driver for the BMA400")
Fixes: 9bea10642396 ("iio: accel: bma400: add support for bma400 spi")

> ---
>  drivers/iio/accel/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iio/accel/Kconfig b/drivers/iio/accel/Kconfig
> index 91adcac875a4..c9d7afe489e8 100644
> --- a/drivers/iio/accel/Kconfig
> +++ b/drivers/iio/accel/Kconfig
> @@ -219,10 +219,12 @@ config BMA400
>  
>  config BMA400_I2C
>  	tristate
> +	select REGMAP_I2C
>  	depends on BMA400
>  
>  config BMA400_SPI
>  	tristate
> +	select REGMAP_SPI
>  	depends on BMA400
>  
>  config BMC150_ACCEL
  

Patch

diff --git a/drivers/iio/accel/Kconfig b/drivers/iio/accel/Kconfig
index 91adcac875a4..c9d7afe489e8 100644
--- a/drivers/iio/accel/Kconfig
+++ b/drivers/iio/accel/Kconfig
@@ -219,10 +219,12 @@  config BMA400
 
 config BMA400_I2C
 	tristate
+	select REGMAP_I2C
 	depends on BMA400
 
 config BMA400_SPI
 	tristate
+	select REGMAP_SPI
 	depends on BMA400
 
 config BMC150_ACCEL