diff mbox series

[v1,1/4] dt-bindings: vendor-prefixes: add LG Electronics, Inc. prefix

Message ID 20240131105153.8070-2-clamor95@gmail.com
State New
Headers
Series Tegra30: add support for LG tegra based phones |

Commit Message

Svyatoslav Ryhel Jan. 31, 2024, 10:51 a.m. UTC 
  Add missing LG Electronics, Inc. prefix used by some older devices.

Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Conor Dooley Jan. 31, 2024, 3:28 p.m. UTC | #1 
On Wed, Jan 31, 2024 at 12:51:50PM +0200, Svyatoslav Ryhel wrote:
> Add missing LG Electronics, Inc. prefix used by some older devices.

Is it? You're only adding these devices now as far as I can see.

> 
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> ---
>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 309b94c328c8..b94ac977acb5 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -767,6 +767,8 @@ patternProperties:
>      description: LG Corporation
>    "^lgphilips,.*":
>      description: LG Display
> +  "^lge,.*":
> +    description: LG Electronics, Inc.
>    "^libretech,.*":
>      description: Shenzhen Libre Technology Co., Ltd
>    "^licheepi,.*":
> -- 
> 2.40.1
>
Svyatoslav Ryhel Jan. 31, 2024, 3:30 p.m. UTC | #2 
31 січня 2024 р. 17:28:49 GMT+02:00, Conor Dooley <conor@kernel.org> написав(-ла):
>On Wed, Jan 31, 2024 at 12:51:50PM +0200, Svyatoslav Ryhel wrote:
>> Add missing LG Electronics, Inc. prefix used by some older devices.
>
>Is it? You're only adding these devices now as far as I can see.
>

Hammerhead (LG Nexus 5)

>> 
>> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
>> ---
>>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
>> index 309b94c328c8..b94ac977acb5 100644
>> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
>> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
>> @@ -767,6 +767,8 @@ patternProperties:
>>      description: LG Corporation
>>    "^lgphilips,.*":
>>      description: LG Display
>> +  "^lge,.*":
>> +    description: LG Electronics, Inc.
>>    "^libretech,.*":
>>      description: Shenzhen Libre Technology Co., Ltd
>>    "^licheepi,.*":
>> -- 
>> 2.40.1
>>
Conor Dooley Jan. 31, 2024, 4:02 p.m. UTC | #3 
On Wed, Jan 31, 2024 at 05:30:58PM +0200, Svyatoslav wrote:
> 
> 
> 31 січня 2024 р. 17:28:49 GMT+02:00, Conor Dooley <conor@kernel.org> написав(-ла):
> >On Wed, Jan 31, 2024 at 12:51:50PM +0200, Svyatoslav Ryhel wrote:
> >> Add missing LG Electronics, Inc. prefix used by some older devices.
> >
> >Is it? You're only adding these devices now as far as I can see.
> >
> 
> Hammerhead (LG Nexus 5)

I have absolutely no idea what this means. Please link me the in-tree
devicetree of the user (or the patchset adding it).

Thanks,
Conor

> 
> >> 
> >> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> >> ---
> >>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> >>  1 file changed, 2 insertions(+)
> >> 
> >> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> >> index 309b94c328c8..b94ac977acb5 100644
> >> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> >> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> >> @@ -767,6 +767,8 @@ patternProperties:
> >>      description: LG Corporation
> >>    "^lgphilips,.*":
> >>      description: LG Display
> >> +  "^lge,.*":
> >> +    description: LG Electronics, Inc.
> >>    "^libretech,.*":
> >>      description: Shenzhen Libre Technology Co., Ltd
> >>    "^licheepi,.*":
> >> -- 
> >> 2.40.1
> >>
Svyatoslav Ryhel Jan. 31, 2024, 4:06 p.m. UTC | #4 
31 січня 2024 р. 18:02:31 GMT+02:00, Conor Dooley <conor@kernel.org> написав(-ла):
>On Wed, Jan 31, 2024 at 05:30:58PM +0200, Svyatoslav wrote:
>> 
>> 
>> 31 січня 2024 р. 17:28:49 GMT+02:00, Conor Dooley <conor@kernel.org> написав(-ла):
>> >On Wed, Jan 31, 2024 at 12:51:50PM +0200, Svyatoslav Ryhel wrote:
>> >> Add missing LG Electronics, Inc. prefix used by some older devices.
>> >
>> >Is it? You're only adding these devices now as far as I can see.
>> >
>> 
>> Hammerhead (LG Nexus 5)
>
>I have absolutely no idea what this means. Please link me the in-tree
>devicetree of the user (or the patchset adding it).
>
>Thanks,
>Conor
>

Sure, here you go
<https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts?h=linux-6.4.y#n11>

So devices I have sent are not the first.

>> 
>> >> 
>> >> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
>> >> ---
>> >>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>> >>  1 file changed, 2 insertions(+)
>> >> 
>> >> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
>> >> index 309b94c328c8..b94ac977acb5 100644
>> >> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
>> >> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
>> >> @@ -767,6 +767,8 @@ patternProperties:
>> >>      description: LG Corporation
>> >>    "^lgphilips,.*":
>> >>      description: LG Display
>> >> +  "^lge,.*":
>> >> +    description: LG Electronics, Inc.
>> >>    "^libretech,.*":
>> >>      description: Shenzhen Libre Technology Co., Ltd
>> >>    "^licheepi,.*":
>> >> -- 
>> >> 2.40.1
>> >>
Conor Dooley Jan. 31, 2024, 4:10 p.m. UTC | #5 
On Wed, Jan 31, 2024 at 06:06:58PM +0200, Svyatoslav wrote:
> 
> 
> 31 січня 2024 р. 18:02:31 GMT+02:00, Conor Dooley <conor@kernel.org> написав(-ла):
> >On Wed, Jan 31, 2024 at 05:30:58PM +0200, Svyatoslav wrote:
> >> 
> >> 
> >> 31 січня 2024 р. 17:28:49 GMT+02:00, Conor Dooley <conor@kernel.org> написав(-ла):
> >> >On Wed, Jan 31, 2024 at 12:51:50PM +0200, Svyatoslav Ryhel wrote:
> >> >> Add missing LG Electronics, Inc. prefix used by some older devices.
> >> >
> >> >Is it? You're only adding these devices now as far as I can see.
> >> >
> >> 
> >> Hammerhead (LG Nexus 5)
> >
> >I have absolutely no idea what this means. Please link me the in-tree
> >devicetree of the user (or the patchset adding it).
> >
> >Thanks,
> >Conor
> >
> 
> Sure, here you go
> <https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts?h=linux-6.4.y#n11>
> 
> So devices I have sent are not the first.

Thanks.

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.
Krzysztof Kozlowski Feb. 1, 2024, 8:48 a.m. UTC | #6 
On 31/01/2024 11:51, Svyatoslav Ryhel wrote:
> Add missing LG Electronics, Inc. prefix used by some older devices.
> 
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> ---

NAK, same reasons as before:

https://lore.kernel.org/all/9942f964-442e-e782-3926-6d7d1123418a@canonical.com/

Best regards,
Krzysztof
Krzysztof Kozlowski Feb. 1, 2024, 8:48 a.m. UTC | #7 
On 31/01/2024 17:06, Svyatoslav wrote:
> 
> 
> 31 січня 2024 р. 18:02:31 GMT+02:00, Conor Dooley <conor@kernel.org> написав(-ла):
>> On Wed, Jan 31, 2024 at 05:30:58PM +0200, Svyatoslav wrote:
>>>
>>>
>>> 31 січня 2024 р. 17:28:49 GMT+02:00, Conor Dooley <conor@kernel.org> написав(-ла):
>>>> On Wed, Jan 31, 2024 at 12:51:50PM +0200, Svyatoslav Ryhel wrote:
>>>>> Add missing LG Electronics, Inc. prefix used by some older devices.
>>>>
>>>> Is it? You're only adding these devices now as far as I can see.
>>>>
>>>
>>> Hammerhead (LG Nexus 5)
>>
>> I have absolutely no idea what this means. Please link me the in-tree
>> devicetree of the user (or the patchset adding it).
>>
>> Thanks,
>> Conor
>>
> 
> Sure, here you go
> <https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts?h=linux-6.4.y#n11>
> 
> So devices I have sent are not the first.

Please look for existing work doing the same...

Best regards,
Krzysztof
Rob Herring Feb. 1, 2024, 10:48 p.m. UTC | #8 
On Thu, Feb 01, 2024 at 09:48:28AM +0100, Krzysztof Kozlowski wrote:
> On 31/01/2024 17:06, Svyatoslav wrote:
> > 
> > 
> > 31 січня 2024 р. 18:02:31 GMT+02:00, Conor Dooley <conor@kernel.org> написав(-ла):
> >> On Wed, Jan 31, 2024 at 05:30:58PM +0200, Svyatoslav wrote:
> >>>
> >>>
> >>> 31 січня 2024 р. 17:28:49 GMT+02:00, Conor Dooley <conor@kernel.org> написав(-ла):
> >>>> On Wed, Jan 31, 2024 at 12:51:50PM +0200, Svyatoslav Ryhel wrote:
> >>>>> Add missing LG Electronics, Inc. prefix used by some older devices.
> >>>>
> >>>> Is it? You're only adding these devices now as far as I can see.
> >>>>
> >>>
> >>> Hammerhead (LG Nexus 5)
> >>
> >> I have absolutely no idea what this means. Please link me the in-tree
> >> devicetree of the user (or the patchset adding it).
> >>
> >> Thanks,
> >> Conor
> >>
> > 
> > Sure, here you go
> > <https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts?h=linux-6.4.y#n11>
> > 
> > So devices I have sent are not the first.
> 
> Please look for existing work doing the same...

Took me a minute to parse this.

I believe what Krzysztof means is look at the link he posted and follow 
the suggestion there. Fix the one case, lge,hammerhead, to use 'lg'.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 309b94c328c8..b94ac977acb5 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -767,6 +767,8 @@  patternProperties:
     description: LG Corporation
   "^lgphilips,.*":
     description: LG Display
+  "^lge,.*":
+    description: LG Electronics, Inc.
   "^libretech,.*":
     description: Shenzhen Libre Technology Co., Ltd
   "^licheepi,.*":