From patchwork Wed Jan 31 06:30:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Rogers X-Patchwork-Id: 194510 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2087:b0:106:209c:c626 with SMTP id gs7csp1707553dyb; Tue, 30 Jan 2024 22:41:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IERy10j899yRVbGEsqWOi++N9COIB6dGq3KIEroPH2wxMUdxmmFx9FEmufHpa1csZE4DRAc X-Received: by 2002:a17:906:190a:b0:a28:2165:7c74 with SMTP id a10-20020a170906190a00b00a2821657c74mr417620eje.13.1706683274289; Tue, 30 Jan 2024 22:41:14 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706683274; cv=pass; d=google.com; s=arc-20160816; b=0snMCT2C7nFsVKL5rFJfcBXW+MxvXkYpRP99o6TsriYwhENsQQVcuU7+UomKRgf3r3 o/T5mjMK4daWqf7utZwgfCKvvuDJOMU2u881yPwAZNpygtMrhsJTA/GoDKYHS/oQR7j2 lV1efHxFY1aybnGFW9ywm8ZPz4i2twlb90GfsJwiPFRFpmpjomuvkaODSrmPU0HhhQo5 Bz9TdHzVOc6TFtwNcXIKZLVdplv0OJAJMUXmyOVaZvW8AKq6AVL9+MRq2UAR1BLAc2wc DUKcxw8P4IqitSQ+2KL0Fss+2zwRimwY1CZk1YV9qcnaRfvG1PNQFfRaiee6L3+ofo3W NXcg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=to:from:subject:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:message-id:date:dkim-signature; bh=TRAmZ7zfR7GIpS+aIsz6syaxM6Q4TrPavG5oF05xWJs=; fh=jOkz5JBH2qY8qKQKpH7pqXl7ntJs6ItNmi4HLSJDkCk=; b=BCBAA+QXOcwn7jOfPBfLupHR8VtHlJQWltQXYvssy9aFRTIbQ66BuBmtBAc8sbdHbo /AUwDjyT/c9LmmC0ACQYFRaliF/SaCpDnylu345LntCNkBH0qbe1ESHhid9s2NbgzYR2 S4hJ8GKuiIv5FNEKBBmY0xQCwAm/irYQYueTrBl9z3iZHW493bRoLXj6Ik25cmTHyVF4 nGcYawAHCS+q36SLP7lh7A1EcYgnL3Z1Vz0EdgHdnORkQ2lXGuir6t7im9hCR64/xVql C0OnwEXRaw/NR8mFJ8qjOUMzGG1DP7Jaxgg6fvreapAzmg955PWBayF6tLmI+coVRo6W 6Jnw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=lEY1N22a; arc=pass (i=1 spf=pass spfdomain=flex--irogers.bounces.google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-45836-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-45836-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com X-Forwarded-Encrypted: i=1; AJvYcCUvn8sIV7StNwa7R3NBX0/25P8ZNnEPH2us/UCJJTmbUG38BtRSEg/2zX5t0vHd6ppqdmogtoIKoMI+jUvW9x0nZjJpGA== Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id lc8-20020a170906f90800b00a368492bf32si90065ejb.974.2024.01.30.22.41.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 22:41:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-45836-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=lEY1N22a; arc=pass (i=1 spf=pass spfdomain=flex--irogers.bounces.google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-45836-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-45836-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id A05BF1F29629 for ; Wed, 31 Jan 2024 06:31:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3CCF64D5A6; Wed, 31 Jan 2024 06:31:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="lEY1N22a" Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 380594CB4B for ; Wed, 31 Jan 2024 06:31:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706682664; cv=none; b=Cjcq2SmCNS/XA95gfPyhSHYM8FP8I7mNqTRCF8q2WfYEaUiFAip4TyGzwp58VT7dlAHByFE6ihESPOMa3X9YIBtkxgPQQeHBppvbP/D+D/1ouMJmdgx1yASpH7wOO46yOrWhH2F8ne5Db1Ek7hEkRy80hv9daho4+/4PlfDYZRQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706682664; c=relaxed/simple; bh=u2dme1MUFaWQF1BSStVrUjjYLnHIqMsZ+Wjfwetyd+o=; h=Date:Message-Id:Mime-Version:Subject:From:To:Content-Type; b=ASjI7oXFDIw1Yxw2hCTH7OWtfatYRopSrPcXnWVa3I21dK6xrT49yCEFc/VHmRoVqs9PFDstu5SWhXGRWzLWf5Md2lSapRp64DGVgrqJLY7POh+4eRvivDS/YY+BKwoaF501DIlvJYf2JCSBiJue/AnilghXrPDCcnC1+y9bePE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=lEY1N22a; arc=none smtp.client-ip=209.85.128.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-6040ffa60ddso2077417b3.2 for ; Tue, 30 Jan 2024 22:31:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706682661; x=1707287461; darn=vger.kernel.org; h=to:from:subject:mime-version:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=TRAmZ7zfR7GIpS+aIsz6syaxM6Q4TrPavG5oF05xWJs=; b=lEY1N22aJJjhJRhsVvGAVQPEvDbXmvRSX97spBk7Kb2HByaW1DeNHA3PKNI49OeAvV nuF3qFqv+xfoQmEsMnaJLSr0I51Xk3m6lUtvepUFZdeL5YWiJFgj6idkZSau7c2dJ3wv tQhUiIvoiy7ST5arM0rukkJQpspxEo/vjviYkqFTXAl8QFHMSKidDA2bv1utAWEs/b02 oUl7FaKzrA5I7PTQcZZK6Qf7cDzqPW5yYOLgfA8klQ+AG/xmEPQeagIf+4fbmx9iaLL6 dWj6pqNIc3iloB8cvSU4Ua85fYXDoVtEAq+QDmuAeZywfmnOLvRD4p2U9eh9R1XWWKPX YeBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706682661; x=1707287461; h=to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=TRAmZ7zfR7GIpS+aIsz6syaxM6Q4TrPavG5oF05xWJs=; b=XIcSHmPhaxzNFWYMSYayznhuOh7htaicjk4vjrxwl0BWPYSm/iJ79RoX9r9a2Zw8QM n5gSrRI8mrzTKNVrLZ3QClNoj808AOFESiTiOAYaZco/E41bu37VxsVBYVtid0pjIUG4 bybm/FqTVd0dNgGoJ37CK33uGhLgAhajnKwUUBgzORt4GxiVLvN+mCynO627W8U3xFfT xFgi81GXpJfsQ/5adsc4vSBkI2SqmfN1WZjdsywSBRvyuj73VtFfBtALisyr3JMwQhtO tWMWlJXORQcDIS3uBK7DKy4dGe9E1MMMSPqoPFno2/LRPUSzLuficwUH4OgAbKkU7BaT Wq5A== X-Gm-Message-State: AOJu0YwUgHAME35e12iwp0zLVQD/FS/7puAenw42j/wre8OrT49GCmvm 5TtVBsA3zgVxBkKvPU+1KM5qfdJTwfS7sPaWpm8IfR8GHZIOIfDtGKl0Rs2XV8ZYx23o5S7BS1P Sudl61g== X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:d0ab:43c6:7969:62ab]) (user=irogers job=sendgmr) by 2002:a81:9946:0:b0:604:45a:6740 with SMTP id q67-20020a819946000000b00604045a6740mr134886ywg.2.1706682661259; Tue, 30 Jan 2024 22:31:01 -0800 (PST) Date: Tue, 30 Jan 2024 22:30:46 -0800 Message-Id: <20240131063048.492010-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog Subject: [PATCH v1 1/2] perf tsc: Add missing newlines to debug statements From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , James Clark , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, tchen168@asu.edu, Michael Petlan X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789587121029017468 X-GMAIL-MSGID: 1789587121029017468 It is assumed that debug statements always print a newline, fix two missing ones. Signed-off-by: Ian Rogers --- This patch was inspired by bad debug output in: https://lore.kernel.org/linux-perf-users/CAGjhMsg_bVKJ_zfsLUR32+oZwGDr3OiBHV_BJ3QtFjyKAs7Sgg@mail.gmail.com/ --- tools/perf/arch/x86/util/tsc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/arch/x86/util/tsc.c b/tools/perf/arch/x86/util/tsc.c index 9b99f48b923c..e2d6cfe21057 100644 --- a/tools/perf/arch/x86/util/tsc.c +++ b/tools/perf/arch/x86/util/tsc.c @@ -33,7 +33,7 @@ static double cpuinfo_tsc_freq(void) cpuinfo = fopen("/proc/cpuinfo", "r"); if (!cpuinfo) { - pr_err("Failed to read /proc/cpuinfo for TSC frequency"); + pr_err("Failed to read /proc/cpuinfo for TSC frequency\n"); return NAN; } while (getline(&line, &len, cpuinfo) > 0) { @@ -48,7 +48,7 @@ static double cpuinfo_tsc_freq(void) } out: if (fpclassify(result) == FP_ZERO) - pr_err("Failed to find TSC frequency in /proc/cpuinfo"); + pr_err("Failed to find TSC frequency in /proc/cpuinfo\n"); free(line); fclose(cpuinfo);