diff mbox series

ASoC: sh: rz-ssi: Fix error message print

Message ID 20240130150822.327434-1-prabhakar.mahadev-lad.rj@bp.renesas.com
State New
Headers
Series ASoC: sh: rz-ssi: Fix error message print |

Commit Message

Lad, Prabhakar Jan. 30, 2024, 3:08 p.m. UTC 
  From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

The devm_request_irq() call is done for "dma_rt" interrupt but the error
message printed "dma_tx" interrupt on failure, fix this by updating
dma_tx -> dma_rt in dev_err_probe() message. While at it aligned the code.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 sound/soc/sh/rz-ssi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Geert Uytterhoeven Jan. 30, 2024, 3:23 p.m. UTC | #1 
On Tue, Jan 30, 2024 at 4:08 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> The devm_request_irq() call is done for "dma_rt" interrupt but the error
> message printed "dma_tx" interrupt on failure, fix this by updating
> dma_tx -> dma_rt in dev_err_probe() message. While at it aligned the code.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Fixes: 38c042b59af0248a ("ASoC: sh: rz-ssi: Update interrupt handling
for half duplex channels")
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert
Mark Brown Jan. 30, 2024, 5:17 p.m. UTC | #2 
On Tue, 30 Jan 2024 15:08:22 +0000, Prabhakar wrote:
> The devm_request_irq() call is done for "dma_rt" interrupt but the error
> message printed "dma_tx" interrupt on failure, fix this by updating
> dma_tx -> dma_rt in dev_err_probe() message. While at it aligned the code.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: sh: rz-ssi: Fix error message print
      commit: 9a6d7c4fb2801b675a9c31a7ceb78c84b8c439bc

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/sound/soc/sh/rz-ssi.c b/sound/soc/sh/rz-ssi.c
index 14cf1a41fb0d..9d103646973a 100644
--- a/sound/soc/sh/rz-ssi.c
+++ b/sound/soc/sh/rz-ssi.c
@@ -1015,7 +1015,7 @@  static int rz_ssi_probe(struct platform_device *pdev)
 					       dev_name(&pdev->dev), ssi);
 			if (ret < 0)
 				return dev_err_probe(&pdev->dev, ret,
-						"irq request error (dma_tx)\n");
+						     "irq request error (dma_rt)\n");
 		} else {
 			if (ssi->irq_tx < 0)
 				return ssi->irq_tx;