From patchwork Tue Jan 30 13:17:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: alexs@kernel.org X-Patchwork-Id: 194174 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2087:b0:106:209c:c626 with SMTP id gs7csp1212829dyb; Tue, 30 Jan 2024 05:19:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IFDCabqE6+/ujh6Sf7oeuT4Eqg7ffcWQj5/XwHeteZEgoj5gYu670IqWckDFpdK/17K/aXR X-Received: by 2002:a17:902:6b03:b0:1d8:cbcf:2150 with SMTP id o3-20020a1709026b0300b001d8cbcf2150mr4286797plk.81.1706620746125; Tue, 30 Jan 2024 05:19:06 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706620746; cv=pass; d=google.com; s=arc-20160816; b=IxDp0hIfLOOR0MNx4GAnL2rX2jdmxiOHO7kfc2RXc/n+isLx5YEJ9bmPPPrEoE5c3k 6WpxtfUYWa0Tk8A3UBS9cXHkQDyubJZ/HahpxNMaeoeoouSNi+qjTtKkrGaxJXapq/Im MrUq3oxLUMYf+gZLgD5508WDZcasp6e4vFC/E3kvFPq6cbdPj6BBClKl/wDRwIfIuE29 J5iV3uXrO8LWnjWHoEDdmriuLX+hkb5M0V72Py4aZpaTRq7QIVaFtBPyUI74Hxvfu5lJ Gf2FvP22V3PQPC+LNjAitzU5IfhMvSsI/BOG+kB3N8nw6KpRDOpIofSC5/ueaBpHBjX6 uaXQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=rovnZYMgdqdgO5q7kI7J3tmOYFmuTAdfJJw/mzec5tk=; fh=CH0OO+rsEMoKRW5HY96+2DQ466rE9ttKX9bm1c+/3Ro=; b=JcmZK7CGeNSedQP8f9c3ede9UMtitZOBD2SDWUfrbcVCl62MkLav1TgN5pMfUPIhWa 2P+NRIzhU/ROO/f9PNIrecye3hNJ46jW8osqd9Ij7szU1L/EPYeBcji1Tjshr7roHdgI 45gK6rMRTpUbzhH15qi9fFw7fhZxx9Fa6iayZYdAKlw8aPANQIBLP16UHN70BMwB3iGp RpwJNNr57ckS3jGyJz0xAzpTMfhaAt5TKU/jg1TThl1H/wHdwRitOGmL6iW61GW5c5x0 MO3YEWB6Zl/e/pYsoBat571NhB4umbgU5TppwGnLkbomKnD6VWqGG7lQ5oETsMfUJM4b s9Hg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=m+rSmKXL; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-44682-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-44682-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id s133-20020a632c8b000000b005d39e412039si7309558pgs.8.2024.01.30.05.19.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 05:19:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-44682-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=m+rSmKXL; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-44682-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-44682-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 16D0B2905E4 for ; Tue, 30 Jan 2024 13:14:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 572586D1C3; Tue, 30 Jan 2024 13:14:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="m+rSmKXL" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B65406BB5E for ; Tue, 30 Jan 2024 13:14:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706620459; cv=none; b=fpKcYFwcR5LWsmDGjEBKaNl7GCDkUP+LLyiZAxUCe4cqa/9fDlBjsxoj0VqWrVi5t62Im+bzAbneFFi7mDCxJzFdSTcv49fGWBUnxZp6KgV163NijuXBwGdgbEzJWei7Aatj6Rof/PreBOHMRTcQ0p7iuvUs8ApFR9JBfHrkpuc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706620459; c=relaxed/simple; bh=ju/4UGtzVW6SMMVqyOTJ6eGP1qKCB+pqoyI2kbcnF5w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ONHjn4+l6AEpkgkCJI5Ks9RPx9d4gjoCxc6tp1mJDuZ2D3a8uzrqloL8EkSHhmncEO6TupISlY1fwuGJBz1AyOcRQ98TadZKRjL888TaE4tj+ZX/BhmOWMwfj5tT5IeunYe5qnfYB/jJQWg4sJ2gzVhfgd3DAWTvFVdn1Hzykd8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=m+rSmKXL; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 492A9C43390; Tue, 30 Jan 2024 13:14:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706620459; bh=ju/4UGtzVW6SMMVqyOTJ6eGP1qKCB+pqoyI2kbcnF5w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=m+rSmKXLmTHihSSFyJ4yx5grOtzvxCwZlnzkXT6/iEIPoynRQj+uDJ8exj9aZSIXo gd8YhhYRov+kTJhXjm1pDqTZtOHfgVUudtzlqDorAWeGvWHgX8O7qGkrxrwlF4+JSg q6ahcfZ9EtXpX55r/h3oYBzuEVWDhNYoyaZ0C9XeIFEfq+QeXIKM0jbobVtN8fBrnX cjlpxu0254qHcJ3DWA/uyaB1g0vxpOtHOqZnHEdHTFgI+y8Gq1ADKXiNhQImoXY1nF Cx73dgHIv2wIt18YvX5h3+OUSk9c3KIk8SFZ5XTdtc6K0RlOWdAIQ4ZzRjQByfU/KH 20sKkZBjHz0eg== From: alexs@kernel.org To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Daniel Bristot de Oliveira , Valentin Schneider , linux-kernel@vger.kernel.org, ricardo.neri-calderon@linux.intel.com, sshegde@linux.ibm.com Cc: Alex Shi Subject: [PATCH v2 2/6] sched/fair: remove unused parameters Date: Tue, 30 Jan 2024 21:17:04 +0800 Message-ID: <20240130131708.429425-2-alexs@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240130131708.429425-1-alexs@kernel.org> References: <20240130131708.429425-1-alexs@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789521555526333488 X-GMAIL-MSGID: 1789521555526333488 From: Alex Shi sds isn't used in function sched_asym(), so remove it to cleanup code. Signed-off-by: Alex Shi Reviewed-by: Ricardo Neri To: Valentin Schneider To: Vincent Guittot To: Juri Lelli To: Peter Zijlstra To: Ingo Molnar --- kernel/sched/fair.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 46ba8329b10a..8d70417f5125 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -9750,7 +9750,6 @@ static bool sched_use_asym_prio(struct sched_domain *sd, int cpu) /** * sched_asym - Check if the destination CPU can do asym_packing load balance * @env: The load balancing environment - * @sds: Load-balancing data with statistics of the local group * @sgs: Load-balancing statistics of the candidate busiest group * @group: The candidate busiest group * @@ -9769,8 +9768,7 @@ static bool sched_use_asym_prio(struct sched_domain *sd, int cpu) * otherwise. */ static inline bool -sched_asym(struct lb_env *env, struct sd_lb_stats *sds, struct sg_lb_stats *sgs, - struct sched_group *group) +sched_asym(struct lb_env *env, struct sg_lb_stats *sgs, struct sched_group *group) { /* Ensure that the whole local core is idle, if applicable. */ if (!sched_use_asym_prio(env->sd, env->dst_cpu)) @@ -9941,7 +9939,7 @@ static inline void update_sg_lb_stats(struct lb_env *env, /* Check if dst CPU is idle and preferred to this group */ if (!local_group && env->sd->flags & SD_ASYM_PACKING && env->idle != CPU_NOT_IDLE && sgs->sum_h_nr_running && - sched_asym(env, sds, sgs, group)) { + sched_asym(env, sgs, group)) { sgs->group_asym_packing = 1; }