Message ID | 20240130095222.11177-1-wsa+renesas@sang-engineering.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-44320-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2087:b0:106:209c:c626 with SMTP id gs7csp1117965dyb; Tue, 30 Jan 2024 02:20:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IHeY4tJWhjx/VJJYYEqD+LOn+plBmV47EJBZ9r8xN6MkMocIgRNn8REjVHGV3mjbhOv29Ot X-Received: by 2002:a05:6a20:a397:b0:19c:61b9:d9bb with SMTP id w23-20020a056a20a39700b0019c61b9d9bbmr3713976pzk.8.1706610023915; Tue, 30 Jan 2024 02:20:23 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706610023; cv=pass; d=google.com; s=arc-20160816; b=wGlskP90yQimfkDol0HA8eY6xC3gMc+AmrpOhSBoTKW7fzWTQixRHB36eLx9NKDoO8 MCon5blUH5YYtSrdwPXMqwigX4msGiH9ibynKjMN3FYnqxBMdn+XqusLl2FyxCWBo2K1 LNTSPofL+iAVi/ro/M0yPdrjIc3HhZ/F9s940lFmRu+BGA6rW1lRax2MNmqCIlOGiut8 qQPT3s0JOfSB7VUS9aaMruUyD3UwSX5t0BxQ2Vquc9hMtQYOh//xqNRep6QuadbsFXpw pL0pwfg6JhsPeH3ZpTvq8xdA7x6hT2oMQti0G2a04YQD0W/gsVyyNLUNqienmWsQ1lKT ZIqw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=eMpBOKcHgjOgUu6e0neo1Xoqw8sM/5NUtcgLJ0eoc9w=; fh=tLh6qpaJUlBxT6nqff9PdLnu+gcpblsu+qfj4xYXAts=; b=j2a4P1IqeD/HLqJZiNalI003HUfAW0XQlR6j02Ss8MNzdT6LoLzJFJei4v6vNmhIic xeBFmb5IcIcgGfbBYEFsY2uxTT38tWEFRoMG4DorUYXrRh6G+QGUnuRfi4qkPVz/M+/3 o5TVMv0OwZdLOLORma8n+XUipI4+lk9ScOhTpvm6KzND3q++Iwvcp6BvlLor9XdA6lta VHHuOYPUCFiZdNuzNFllq5N00h/mMzkkWy7JPTG5TbmflWa78Bb15OH8A5R1LVyKhAXT w/1uxVmHLZfIHXQCUH5kF6qWnxkiDkXVEeHLIa4H8LHml+UX5t3bAdpo6vnRV5OXsvfD R+3Q== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@sang-engineering.com header.s=k1 header.b=TcpH6VlP; arc=pass (i=1 spf=pass spfdomain=sang-engineering.com dkim=pass dkdomain=sang-engineering.com); spf=pass (google.com: domain of linux-kernel+bounces-44320-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-44320-ouuuleilei=gmail.com@vger.kernel.org" Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id l74-20020a633e4d000000b005cdb499ac69si7372693pga.53.2024.01.30.02.20.23 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 02:20:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-44320-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@sang-engineering.com header.s=k1 header.b=TcpH6VlP; arc=pass (i=1 spf=pass spfdomain=sang-engineering.com dkim=pass dkdomain=sang-engineering.com); spf=pass (google.com: domain of linux-kernel+bounces-44320-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-44320-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 2A156B3155D for <ouuuleilei@gmail.com>; Tue, 30 Jan 2024 09:56:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DEE5E66B58; Tue, 30 Jan 2024 09:52:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="TcpH6VlP" Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E195664A7 for <linux-kernel@vger.kernel.org>; Tue, 30 Jan 2024 09:52:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706608351; cv=none; b=fhqrqCg9ncXGOqabz+dJB1ozDE9B0aoC3kitZR7NDwbiKn5rVbyeNYujTejqQ8ab6dfkJ/a9dmC78LfEJjvriOWyeSp+NXIIIp7c5ePmUTAXN2AToo1C5rYiSgDneSHTFjHMD5w5jjBWhHZJ4YaBF5t8Lv0ic0/XMX5WgP85WFw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706608351; c=relaxed/simple; bh=g5rkrsUczvT98u64IjHetISOxo+BA6WM15O5Bq18z8g=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=st/LDS2znZmkppGub6JzyF7SsCGhBncHMZ8XNUjCCU0gqQQcHd9g8XnKZGlhaZAWzBGYTEjmgptDCGlmfWXRCPSvtqrcmsVmC3G19L6r4tSBWzf517vHVza4gQMSCqgdjRKSKDmJgSTNAnEaGRIFyJ0nX3u+SRFspVH73G0hfkw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=TcpH6VlP; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; s=k1; bh=eMpBOKcHgjOgUu 6e0neo1Xoqw8sM/5NUtcgLJ0eoc9w=; b=TcpH6VlPrVDpYNb89HzqoMZMVwpoPp ByXNStY2Nw+iq2OQokAZfA0LfEF/FsCJJ56MBIwXxliwrkEHJeM8ImdK5WMaf8ca EqNbRRdr+OqhBOZbD1GpPfIzIZeaK7t03XR+4kMNq6W04vhnLtFTBWggvRIns4qo gKk90EhhBm4QaHjGvby4bkbccsWbMwy1MjBo5XZID1bk0oNa8bjFZfDNZcyNDX6K COmnxNzCjSv5tPPuLhetN0puHmLqOw936p8f41CqLOkQS56T4UNnH23H96xXFp+7 u8TvrtEqnXBRvcWEJkagetICxazv1W8gvXvSR/qfCkTLt3GRovl38MAg== Received: (qmail 2786307 invoked from network); 30 Jan 2024 10:52:26 +0100 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 30 Jan 2024 10:52:26 +0100 X-UD-Smtp-Session: l3s3148p1@vQM5uCYQZOdehhtJ From: Wolfram Sang <wsa+renesas@sang-engineering.com> To: linux-renesas-soc@vger.kernel.org Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>, Geert Uytterhoeven <geert+renesas@glider.be>, Magnus Damm <magnus.damm@gmail.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] arm64: dts: renesas: ulcb-kf: document a problemw with old firmware Date: Tue, 30 Jan 2024 10:52:22 +0100 Message-Id: <20240130095222.11177-1-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789510312263184346 X-GMAIL-MSGID: 1789510312263184346 |
Series |
arm64: dts: renesas: ulcb-kf: document a problemw with old firmware
|
|
Commit Message
Wolfram Sang
Jan. 30, 2024, 9:52 a.m. UTC
Old firmware set the GPIO to output, so no interrupts could be read.
Newer firmware does this correctly. The exact version could not be
determined, sadly.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 1 +
1 file changed, 1 insertion(+)
Comments
Hi Wolfram, On Tue, Jan 30, 2024 at 10:52 AM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > Old firmware set the GPIO to output, so no interrupts could be read. > Newer firmware does this correctly. The exact version could not be > determined, sadly. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi > +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi > @@ -324,6 +324,7 @@ gpio_exp_77: gpio@77 { > reg = <0x77>; > gpio-controller; > #gpio-cells = <2>; > + /* If these interrupts don't work, please update your firmware */ > interrupt-controller; > interrupt-parent = <&gpio5>; > interrupts = <9 IRQ_TYPE_EDGE_FALLING>; I'd rather not add such comments (especially +6y after the fact), as this is the standard operating procedure in case something doesn't work. Do you think we should sprinkle the following, too?? /* If secondary CPUs don't work, please update your firmware */ /* If cpuidle crashes, please update your firmware */ /* If watchdog restart doesn't work, please update your firmware */ /* If PSCI reboot doesn't work, please update your firmware */ Gr{oetje,eeting}s, Geert
Hi Geert, > I'd rather not add such comments (especially +6y after the fact), as > this is the standard operating procedure in case something doesn't work. Okay, can be argued. > /* If secondary CPUs don't work, please update your firmware */ > /* If cpuidle crashes, please update your firmware */ > /* If watchdog restart doesn't work, please update your firmware */ > /* If PSCI reboot doesn't work, please update your firmware */ Actually, I wouldn't mind. It documents that we *know* updating firmware helps in this particular case. But as said, I can see your point as well. Let's drop this patch. Happy hacking, Wolfram
diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi index 84b0976503b7..45e55ce760d1 100644 --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi @@ -324,6 +324,7 @@ gpio_exp_77: gpio@77 { reg = <0x77>; gpio-controller; #gpio-cells = <2>; + /* If these interrupts don't work, please update your firmware */ interrupt-controller; interrupt-parent = <&gpio5>; interrupts = <9 IRQ_TYPE_EDGE_FALLING>;