From patchwork Tue Jan 30 07:47:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Bitao Hu X-Patchwork-Id: 193871 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2087:b0:106:209c:c626 with SMTP id gs7csp1058903dyb; Mon, 29 Jan 2024 23:48:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IEcR2hFgbcC32bk5d7MyKbdHkRmtog4179vJo/2xFC5dDtujNk2g85Eit7W2s3ZBh+wI4Za X-Received: by 2002:a05:622a:116:b0:42a:a0b4:b32f with SMTP id u22-20020a05622a011600b0042aa0b4b32fmr4616975qtw.132.1706600937022; Mon, 29 Jan 2024 23:48:57 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706600936; cv=pass; d=google.com; s=arc-20160816; b=A7yj0MKcHngbTOMFmfMJwajuovKc5Ui710G7pxEFNhiuA0YL335ng7x3l1u4jGNRm1 vvvgJrDSIxk/RYepojasPvtA0sOjSM6sObGgh6CyVr4z70DZgBNt4UJhTCWFAAAJrmH/ 5B5PHKybA63z8q9kmboGJl9kCuuoTf5/LfGKco9gCAMv+98BvSDVnKXNrQY11QiPPLfG raRSm7raAT0wtjQMNGdMpshb2AgPDPnvIZd3DC6j0rpB75+OPkCb/YN52nDOsqw7rmk+ Ljm+Qvdqsg8IPDVQ8bh8iEJ4EwOCVRsxlDP+oqRv5vw40FDNkfyBssIw3GxF6wAvXqxK Diew== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=FoXv3w40wsSUWTbNLnNIoOwk9fD4Xnl+gY/XoASdjQI=; fh=iwSnT5NYnDHQTJ12VpDVBCo/Xa2twiuP43PvK1ma9TE=; b=B6A3ot6HDfJyFbfr8X3PWsUolg4v/D36p50PbVHI45ZFrG/3cDOTDMfzUcylcFmosS j5ccCUQxjfWsPmDV9+nlfUiP+m0CeWPmIzbtf2/8fQ75mMsHbNFEbZIqaV7rhfpfe8E3 ah/8IonQLcZbsAPS190hhG9Pm4EUHQ8t8wSn76VASjzoEcew7uRlgUYwFoBZsAwXkP3z jnNMdO/g4rqUe/miOFkFP0GwVS3305DKg+W2Nc1YL4ooXP+3x5bGdeQXyUEIHjCSRv/c 13HkrCOMY5mcRo1h0hNKnKqFof5qGvGzzdEQoXuJqSbpCxgvXdBsfenJawEB+naePssf WFaA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.alibaba.com header.s=default header.b=fjFncHmm; arc=pass (i=1 spf=pass spfdomain=linux.alibaba.com dkim=pass dkdomain=linux.alibaba.com dmarc=pass fromdomain=linux.alibaba.com); spf=pass (google.com: domain of linux-kernel+bounces-44066-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-44066-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.alibaba.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id w17-20020ac87e91000000b0042bd20d1b93si82606qtj.391.2024.01.29.23.48.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 23:48:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-44066-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.alibaba.com header.s=default header.b=fjFncHmm; arc=pass (i=1 spf=pass spfdomain=linux.alibaba.com dkim=pass dkdomain=linux.alibaba.com dmarc=pass fromdomain=linux.alibaba.com); spf=pass (google.com: domain of linux-kernel+bounces-44066-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-44066-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.alibaba.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id B28B31C23224 for ; Tue, 30 Jan 2024 07:48:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E5EDC58200; Tue, 30 Jan 2024 07:48:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="fjFncHmm" Received: from out30-97.freemail.mail.aliyun.com (out30-97.freemail.mail.aliyun.com [115.124.30.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EA0C5472A for ; Tue, 30 Jan 2024 07:47:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.97 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706600880; cv=none; b=jty0k5UEaa3ril52VcLgmPSA2Vs77gCXplImCClWMK0EQlHpF+1DTGEa1m8rc/hF0V/IwIn7tZdZ5mQfQ3dZf5SFUF8oeJ0Ho0BoAPolVYv04lV5SjBB/n0qWWu5fthi7uKcqnE0y3Sx/LTQulFTuHK9Qwcrt0CgbR4A/gwqhQ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706600880; c=relaxed/simple; bh=WNc1vqtl8qrc5VHlrt8bIH1/roSANP20mJxgjJlkyPQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=QgSVylLnLSKSzYzqtDlsmZQAdTVlNnM1sUKZmeIrEi+8PCLfHaqXapYno3JfYJlFwDxZkZQOEzBZ9iVYRHEaLgo71bymxzzsKMlSWt7/yIzEFqJRYBSMscZku97XR83KqCA6Notnd6CwuJYuaXEmI6ghWgCJXxAPeeKfKI+l93c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=fjFncHmm; arc=none smtp.client-ip=115.124.30.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1706600874; h=From:To:Subject:Date:Message-Id:MIME-Version:Content-Type; bh=FoXv3w40wsSUWTbNLnNIoOwk9fD4Xnl+gY/XoASdjQI=; b=fjFncHmmpm5PITeCSxorX1obcYsNgA4VNQFfFcoiYv+GFsBUv7TPZlFEitv8oPcFjgr2DKfCL8fLOS0tzEWsS//1IdLs/JBGxXJZyyp/h8W9rALRHeERBVWQjlmauLpU/HVro6wGL/PZo9byNFhGRF0wxcf0XWPtO1qtQY8Dgng= X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R781e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=yaoma@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0W.fTvah_1706600870; Received: from localhost.localdomain(mailfrom:yaoma@linux.alibaba.com fp:SMTPD_---0W.fTvah_1706600870) by smtp.aliyun-inc.com; Tue, 30 Jan 2024 15:47:53 +0800 From: Bitao Hu To: dianders@chromium.org, akpm@linux-foundation.org, pmladek@suse.com, lecopzer.chen@mediatek.com, kernelfans@gmail.com, liusong@linux.alibaba.com Cc: linux-kernel@vger.kernel.org, yaoma@linux.alibaba.com Subject: [PATCHv2 1/2] watchdog/softlockup: low-overhead detection of interrupt storm Date: Tue, 30 Jan 2024 15:47:43 +0800 Message-Id: <20240130074744.45759-2-yaoma@linux.alibaba.com> X-Mailer: git-send-email 2.37.1 (Apple Git-137.1) In-Reply-To: <20240130074744.45759-1-yaoma@linux.alibaba.com> References: <20240130074744.45759-1-yaoma@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789500784557242062 X-GMAIL-MSGID: 1789500784557242062 The following softlockup is caused by interrupt storm, but it cannot be identified from the call tree. Because the call tree is just a snapshot and doesn't fully capture the behavior of the CPU during the soft lockup. watchdog: BUG: soft lockup - CPU#28 stuck for 23s! [fio:83921] ... Call trace: __do_softirq+0xa0/0x37c __irq_exit_rcu+0x108/0x140 irq_exit+0x14/0x20 __handle_domain_irq+0x84/0xe0 gic_handle_irq+0x80/0x108 el0_irq_naked+0x50/0x58 Therefore，I think it is necessary to report CPU utilization during the softlockup_thresh period (report once every sample_period, for a total of 5 reportings), like this: watchdog: BUG: soft lockup - CPU#28 stuck for 23s! [fio:83921] CPU#28 Utilization every 4s during lockup: #1: 0% system, 0% softirq, 100% hardirq, 0% idle #2: 0% system, 0% softirq, 100% hardirq, 0% idle #3: 0% system, 0% softirq, 100% hardirq, 0% idle #4: 0% system, 0% softirq, 100% hardirq, 0% idle #5: 0% system, 0% softirq, 100% hardirq, 0% idle ... This would be helpful in determining whether an interrupt storm has occurred or in identifying the cause of the softlockup. The criteria for determination are as follows: a. If the hardirq utilization is high, then interrupt storm should be considered and the root cause cannot be determined from the call tree. b. If the softirq utilization is high, then we could analyze the call tree but it may cannot reflect the root cause. c. If the system utilization is high, then we could analyze the root cause from the call tree. Signed-off-by: Bitao Hu --- kernel/watchdog.c | 72 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 72 insertions(+) diff --git a/kernel/watchdog.c b/kernel/watchdog.c index 81a8862295d6..0efe9604c3c2 100644 --- a/kernel/watchdog.c +++ b/kernel/watchdog.c @@ -23,6 +23,8 @@ #include #include #include +#include +#include #include #include @@ -441,6 +443,73 @@ static int is_softlockup(unsigned long touch_ts, return 0; } +#ifdef CONFIG_IRQ_TIME_ACCOUNTING +#define NUM_STATS_GROUPS 5 +#define STATS_SYSTEM 0 +#define STATS_SOFTIRQ 1 +#define STATS_HARDIRQ 2 +#define STATS_IDLE 3 +#define NUM_STATS_PER_GROUP 4 +static DEFINE_PER_CPU(u16, cpustat_old[NUM_STATS_PER_GROUP]); +static DEFINE_PER_CPU(u8, cpustat_utilization[NUM_STATS_GROUPS][NUM_STATS_PER_GROUP]); +static DEFINE_PER_CPU(u8, cpustat_tail); +static enum cpu_usage_stat idx_to_stat[NUM_STATS_PER_GROUP] = { + CPUTIME_SYSTEM, CPUTIME_SOFTIRQ, CPUTIME_IRQ, CPUTIME_IDLE +}; + +static void update_cpustat(void) +{ + u8 i; + u16 *old = this_cpu_ptr(cpustat_old); + u8 (*utilization)[NUM_STATS_PER_GROUP] = this_cpu_ptr(cpustat_utilization); + u8 tail = this_cpu_read(cpustat_tail); + struct kernel_cpustat kcpustat; + u64 *cpustat = kcpustat.cpustat; + u16 sample_period_ms = sample_period >> 24LL; /* 2^24ns ~= 16.8ms */ + + kcpustat_cpu_fetch(&kcpustat, smp_processor_id()); + for (i = STATS_SYSTEM; i < NUM_STATS_PER_GROUP; i++) { + /* + * We don't need nanosecond resolution. A granularity of 16ms is + * sufficient for our precision, allowing us to use u16 to store + * cpustats, which will roll over roughly every ~1000 seconds. + * 2^24 ~= 16 * 10^6 + */ + cpustat[idx_to_stat[i]] = lower_16_bits(cpustat[idx_to_stat[i]] >> 24LL); + utilization[tail][i] = 100 * (u16)(cpustat[idx_to_stat[i]] - old[i]) + / sample_period_ms; + old[i] = cpustat[idx_to_stat[i]]; + } + this_cpu_write(cpustat_tail, (tail + 1) % NUM_STATS_GROUPS); +} + +static void print_cpustat(void) +{ + u8 i, j; + u8 (*utilization)[NUM_STATS_PER_GROUP] = this_cpu_ptr(cpustat_utilization); + u8 tail = this_cpu_read(cpustat_tail); + u64 sample_period_second = sample_period; + + do_div(sample_period_second, NSEC_PER_SEC); + /* + * We do not want the "watchdog: " prefix on every line, + * hence we use "printk" instead of "pr_crit". + */ + printk(KERN_CRIT "CPU#%d Utilization every %llus during lockup:\n", + smp_processor_id(), sample_period_second); + for (j = STATS_SYSTEM, i = tail; j < NUM_STATS_GROUPS; + j++, i = (i + 1) % NUM_STATS_GROUPS) { + printk(KERN_CRIT "\t#%d: %3u%% system,\t%3u%% softirq,\t" + "%3u%% hardirq,\t%3u%% idle\n", j+1, + utilization[i][STATS_SYSTEM], utilization[i][STATS_SOFTIRQ], + utilization[i][STATS_HARDIRQ], utilization[i][STATS_IDLE]); + } +} +#else +static inline void update_cpustat(void) { } +static inline void print_cpustat(void) { } +#endif + /* watchdog detector functions */ static DEFINE_PER_CPU(struct completion, softlockup_completion); static DEFINE_PER_CPU(struct cpu_stop_work, softlockup_stop_work); @@ -504,6 +573,8 @@ static enum hrtimer_restart watchdog_timer_fn(struct hrtimer *hrtimer) */ period_ts = READ_ONCE(*this_cpu_ptr(&watchdog_report_ts)); + update_cpustat(); + /* Reset the interval when touched by known problematic code. */ if (period_ts == SOFTLOCKUP_DELAY_REPORT) { if (unlikely(__this_cpu_read(softlockup_touch_sync))) { @@ -539,6 +610,7 @@ static enum hrtimer_restart watchdog_timer_fn(struct hrtimer *hrtimer) pr_emerg("BUG: soft lockup - CPU#%d stuck for %us! [%s:%d]\n", smp_processor_id(), duration, current->comm, task_pid_nr(current)); + print_cpustat(); print_modules(); print_irqtrace_events(current); if (regs)