diff mbox series

[RFC,2/2] arm64: dts: renesas: ulcb-kf: adapt sound 5v regulator to schematics

Message ID 20240129212350.33370-3-wsa+renesas@sang-engineering.com
State New
Headers
Series arm64: dts: renesas: ulcb-kf: adapt regulators to schematics |

Commit Message

Wolfram Sang Jan. 29, 2024, 9:23 p.m. UTC 
  Sound uses the standard 5V supply, so rename the fixed regulator as
such. Also add properties dcoumenting it is always on, also during boot.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---

Or shall we move the regulator to ulcb.dtsi? I tend to leave it here
because 5V are not used on ULCB, but I am open to change it.

 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

Comments

Geert Uytterhoeven Feb. 12, 2024, 1:37 p.m. UTC | #1 
Hi Wolfram,

Thanks for your patch!

On Mon, Jan 29, 2024 at 10:23 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Sound uses the standard 5V supply, so rename the fixed regulator as
> such. Also add properties dcoumenting it is always on, also during boot.

documenting

> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Or shall we move the regulator to ulcb.dtsi? I tend to leave it here
> because 5V are not used on ULCB, but I am open to change it.

I think it's fine to keep it here, as the regulator (U59) that generates
5V from 12V is present on the Kingfisher board.  However, according
to the schematics, 5V is generated by the PMIC on the ULCB too, and
both 5V nets are connected through the board-to-board connectors?

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.9.

Gr{oetje,eeting}s,

                        Geert
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index 6b6a0a8bc1db..84b0976503b7 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -59,11 +59,13 @@  pcie_3v3: regulator-pcie-3v3 {
 		enable-active-high;
 	};
 
-	snd_vcc5v: regulator-snd_vcc5v {
+	reg_5v: regulator-5v {
 		compatible = "regulator-fixed";
-		regulator-name = "snd-vcc5v";
+		regulator-name = "fixed-5V";
 		regulator-min-microvolt = <5000000>;
 		regulator-max-microvolt = <5000000>;
+		regulator-boot-on;
+		regulator-always-on;
 	};
 
 	wlan_en: regulator-wlan_en {
@@ -210,10 +212,10 @@  pcm3168a: audio-codec@44 {
 
 				VDD1-supply = <&reg_3p3v>;
 				VDD2-supply = <&reg_3p3v>;
-				VCCAD1-supply = <&snd_vcc5v>;
-				VCCAD2-supply = <&snd_vcc5v>;
-				VCCDA1-supply = <&snd_vcc5v>;
-				VCCDA2-supply = <&snd_vcc5v>;
+				VCCAD1-supply = <&reg_5v>;
+				VCCAD2-supply = <&reg_5v>;
+				VCCDA1-supply = <&reg_5v>;
+				VCCDA2-supply = <&reg_5v>;
 			};
 
 			gyroscope@6b {