diff mbox series

[RFC,1/2] arm64: dts: renesas: ulcb-kf: adapt 1.8V HDMI regulator to schematics

Message ID 20240129212350.33370-2-wsa+renesas@sang-engineering.com
State New
Headers
Series arm64: dts: renesas: ulcb-kf: adapt regulators to schematics |

Commit Message

Wolfram Sang Jan. 29, 2024, 9:23 p.m. UTC 
  It is named T1.8V in the schematics. Also add properties dcoumenting it
is always on, also during boot.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

Comments

Geert Uytterhoeven Feb. 12, 2024, 1:29 p.m. UTC | #1 
Hi Wolfram,

Thanks for your patch!

On Mon, Jan 29, 2024 at 10:23 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> It is named T1.8V in the schematics. Also add properties dcoumenting it

documenting

> is always on, also during boot.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> @@ -32,11 +32,13 @@ hdmi1_con: endpoint {
>                 };
>         };
>
> -       hdmi_1v8: regulator-hdmi-1v8 {
> +       t1v8: regulator-t1v8 {

"t1p8v"?
Or "reg_t1p8v", as the former is a rather short name, causing conflicts?

>                 compatible = "regulator-fixed";
> -               regulator-name = "hdmi-1v8";
> +               regulator-name = "t1v8";
>                 regulator-min-microvolt = <1800000>;
>                 regulator-max-microvolt = <1800000>;
> +               regulator-boot-on;
> +               regulator-always-on;
>         };
>
>         pcie_1v5: regulator-pcie-1v5 {
> @@ -154,11 +156,11 @@ hdmi@3d {
>
>                                 pd-gpios = <&gpio_exp_75 5 GPIO_ACTIVE_LOW>;
>
> -                               avdd-supply = <&hdmi_1v8>;
> -                               dvdd-supply = <&hdmi_1v8>;
> -                               pvdd-supply = <&hdmi_1v8>;
> +                               avdd-supply = <&t1v8>;
> +                               dvdd-supply = <&t1v8>;
> +                               pvdd-supply = <&t1v8>;
>                                 dvdd-3v-supply = <&reg_3p3v>;
> -                               bgvdd-supply = <&hdmi_1v8>;
> +                               bgvdd-supply = <&t1v8>;
>
>                                 adi,input-depth = <8>;
>                                 adi,input-colorspace = "rgb";

The rest LGTM.

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Wolfram Sang Feb. 12, 2024, 1:42 p.m. UTC | #2 
> > -       hdmi_1v8: regulator-hdmi-1v8 {
> > +       t1v8: regulator-t1v8 {
> 
> "t1p8v"?
> Or "reg_t1p8v", as the former is a rather short name, causing conflicts?

Agreed, I'll take the latter and resend.
Geert Uytterhoeven Feb. 12, 2024, 1:44 p.m. UTC | #3 
Hi Wolfram,

On Mon, Feb 12, 2024 at 2:42 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> > > -       hdmi_1v8: regulator-hdmi-1v8 {
> > > +       t1v8: regulator-t1v8 {
> >
> > "t1p8v"?
> > Or "reg_t1p8v", as the former is a rather short name, causing conflicts?
>
> Agreed, I'll take the latter and resend.

No need for that, I can fix it while applying...
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.9.

Gr{oetje,eeting}s,

                        Geert
Wolfram Sang Feb. 12, 2024, 2:20 p.m. UTC | #4 
> > > "t1p8v"?
> > > Or "reg_t1p8v", as the former is a rather short name, causing conflicts?
> >
> > Agreed, I'll take the latter and resend.
> 
> No need for that, I can fix it while applying...

Cool, thank you!
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index c8dc06f0dfed..6b6a0a8bc1db 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -32,11 +32,13 @@  hdmi1_con: endpoint {
 		};
 	};
 
-	hdmi_1v8: regulator-hdmi-1v8 {
+	t1v8: regulator-t1v8 {
 		compatible = "regulator-fixed";
-		regulator-name = "hdmi-1v8";
+		regulator-name = "t1v8";
 		regulator-min-microvolt = <1800000>;
 		regulator-max-microvolt = <1800000>;
+		regulator-boot-on;
+		regulator-always-on;
 	};
 
 	pcie_1v5: regulator-pcie-1v5 {
@@ -154,11 +156,11 @@  hdmi@3d {
 
 				pd-gpios = <&gpio_exp_75 5 GPIO_ACTIVE_LOW>;
 
-				avdd-supply = <&hdmi_1v8>;
-				dvdd-supply = <&hdmi_1v8>;
-				pvdd-supply = <&hdmi_1v8>;
+				avdd-supply = <&t1v8>;
+				dvdd-supply = <&t1v8>;
+				pvdd-supply = <&t1v8>;
 				dvdd-3v-supply = <&reg_3p3v>;
-				bgvdd-supply = <&hdmi_1v8>;
+				bgvdd-supply = <&t1v8>;
 
 				adi,input-depth = <8>;
 				adi,input-colorspace = "rgb";