Message ID | 20240129-sc7280-venus-bindings-v1-1-20a9ba194c60@fairphone.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-42294-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2087:b0:106:209c:c626 with SMTP id gs7csp415636dyb; Sun, 28 Jan 2024 23:49:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IFqcC9W80suDwlX1L9MvbYTBjaYmrAkRi3/GcC7Bbn4pADjm/ctPbGBIownBxzPFzVjIdFO X-Received: by 2002:a05:620a:1a1a:b0:783:f4fd:d627 with SMTP id bk26-20020a05620a1a1a00b00783f4fdd627mr3176491qkb.89.1706514562681; Sun, 28 Jan 2024 23:49:22 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706514562; cv=pass; d=google.com; s=arc-20160816; b=zleitpNffKeZEM4A4KaF1AJysQ2SFWvOkuQYzvRxvkvVmdkD8iEuuYgqX5/8yJTXND EYDItTALzXIaJ7Zfety5eoCDGIPKcn9WRkmHH2uWR+s+zGI2KEyrgfaNWF5VEp7LaQvo azilk5Qi4fK3r8WWsmBWixh8FNdDp3ZSPTgxOIuMyUEjgbDGMzSjGKwAlnjhyW8GWpeR psOxYzQxXovZ5u4/0Nu1pwx1wp4FU0+M0lg6Tzhkp1qAS/KEmSXH7BojIZEUt0hbOtPS 3gVdjVa3NscfVY6He3+LP3Ua7VkpvgPTai/x5bSVUenVH8u7ILVTSBKgsJqUFRd1JdUi 6z9w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:message-id:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:subject:date :from:dkim-signature; bh=hi3wdBPHy9dOJfUItOIZktdrEsNa9te/nL1WfaDI3y0=; fh=1xcQF/tvquR4vvnZQRR6k/RjffJForppzUPGkYRArUE=; b=HVKEh3uTfqa3h1IymD5Kb3yl0w1Z1FQMMahKoRJQhhllF9i9rWAgNQsm5u6O57OXhz nh1C5Ss2YeR/r6zEtq6qwIkmaiN+xdVBg0ls8SWhFMzIURwRTCkNIeIgQeeHhxul5rwQ Dw62ibQMD+xiRp0iH/Vy9Bwz+cEVm8qXqRaE5pRM+nw4q46hbz15DyIgCQ3XhEoujv9H mMCnNS6amQJCH+UEf3j+Wvt7UWZ/l9Tr1OrnA3B4scK0Ygxi6opP+703/zAtUYCUAWgh JG2x43Y3QaJ31tjbpr8RqE4Iog7RvDCKAkxoWBrf2Yqvn5+a3z+8AQrR0g04b1k8uLbo BA1g== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@fairphone.com header.s=fair header.b=zD0JfOPJ; arc=pass (i=1 spf=pass spfdomain=fairphone.com dkim=pass dkdomain=fairphone.com dmarc=pass fromdomain=fairphone.com); spf=pass (google.com: domain of linux-kernel+bounces-42294-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-42294-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fairphone.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id q13-20020a05620a038d00b00783de2bf730si5994182qkm.498.2024.01.28.23.49.22 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jan 2024 23:49:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-42294-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@fairphone.com header.s=fair header.b=zD0JfOPJ; arc=pass (i=1 spf=pass spfdomain=fairphone.com dkim=pass dkdomain=fairphone.com dmarc=pass fromdomain=fairphone.com); spf=pass (google.com: domain of linux-kernel+bounces-42294-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-42294-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fairphone.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 790391C22C65 for <ouuuleilei@gmail.com>; Mon, 29 Jan 2024 07:49:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 69E034F60E; Mon, 29 Jan 2024 07:49:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="zD0JfOPJ" Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6339D4EB23 for <linux-kernel@vger.kernel.org>; Mon, 29 Jan 2024 07:49:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706514543; cv=none; b=K8ZQkxZEH3oaYQOVcNv6r/SpvpYGD+znuVnIyAH6//dsKZuOYr6tbcNGMKTZphzmpzvLX+qy0XxRcSvU3TzGzDgyXl7RsXdErZmNGCNaLLS2Lu3/ivkmQsv5BXZyWgabRhqj7HvznX7OfvWXSAO7crWO8ZsaOQ50ognsnRFOxt8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706514543; c=relaxed/simple; bh=BKP83D9yJgO7dHlibnyMa09vHevxppr0G+06k+2XFWc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=jF7eEBpU6ZpHQkEgUg2NhMbDQi5DBvytOarDXZOFc/xo4yDOO5urRM9NILn5aySm+UTBvKfI8B0VTFNrrjZV00yZ5XBaPHOcmUHC2VHiGZv+dc/tnBu0dkgIeivR/SpylD4jq+FC03fs5ljvTZST89TviqMyzLuhYm8dgY1FPx4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=zD0JfOPJ; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a35d0764076so37684966b.1 for <linux-kernel@vger.kernel.org>; Sun, 28 Jan 2024 23:49:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1706514539; x=1707119339; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=hi3wdBPHy9dOJfUItOIZktdrEsNa9te/nL1WfaDI3y0=; b=zD0JfOPJHHPGaXfIawDeUuiT7Jl4xsIl3OqLLbJjuY0pY0GjUKidfiElXlN8PB/2tj eSvjXBE/bHQEHKrpvrjTC4OkUif2mFkmV2t/t6xwwedWejM0f8Cfu+TuUHzuPRKr9/9n uOC3185PWvH0pPa8z4NyTF/x1SRhc9e8Ayad204t8CfbvKl/9aSz9rynbDiBsOn6gl+X 9UP3kMwoTrXzFZcPUAu5GH1cxN7ZrbfQHy0N+2j5rx27q5VtrXQokpXf3uCWA0O3I3Xg I3Bi5K1Bm7gF/K5muQ2K5tne61BftSTAqGyJQ+VTCBz9WGduSNkH7XqGXb1w73rsXUb7 x/ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706514539; x=1707119339; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hi3wdBPHy9dOJfUItOIZktdrEsNa9te/nL1WfaDI3y0=; b=iUXIWS5GltVgv3+uBLYk5N0xs2pudIM0laY6Z7gjG4aTMOG25xgZXAmj0peKTlrvhL bSPSQSffuTzeqaErjeaAplVuNIPZ5iTsldLaVsTDePnQOJyF5ew05EBtABAakAnl38qX n6E3D63QbFRCYBS563IYEGL4fNS/RW7XFKFfNhFphW2X94Dmv6MU2bh2VzOezi1BJZv7 FCQIv1JzG+zc0lgXTdxXY+3DMgT+NOFMOgJbqpL/vCXYQElPkZbzD8XR7z3/ZBVMy5F1 wp8EBapkXWdFJsUByzr7LkJ7WrknrO9ccQTT1VPqH8Ugku07L5enCAKoHM3TyhkgLui4 JWwg== X-Gm-Message-State: AOJu0Yy09e5o4x18N/7N7ixUE1q3lIm30rbWQeoCEqsZDNiDiQSnczlY 7/hFQMZVfHdnP/LD561hCObLUJNhRXvYugDlhnMxYWg2SBHGO/n0AxsGwgFg9GQ= X-Received: by 2002:a17:906:a14c:b0:a35:d2f8:4927 with SMTP id bu12-20020a170906a14c00b00a35d2f84927mr590202ejb.70.1706514539677; Sun, 28 Jan 2024 23:48:59 -0800 (PST) Received: from otso.luca.vpn.lucaweiss.eu (dhcp-089-099-055-216.chello.nl. [89.99.55.216]) by smtp.gmail.com with ESMTPSA id l13-20020a1709066b8d00b00a32429e455asm3679881ejr.175.2024.01.28.23.48.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jan 2024 23:48:59 -0800 (PST) From: Luca Weiss <luca.weiss@fairphone.com> Date: Mon, 29 Jan 2024 08:48:54 +0100 Subject: [PATCH] media: dt-bindings: qcom,sc7280-venus: Allow one IOMMU entry Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240129-sc7280-venus-bindings-v1-1-20a9ba194c60@fairphone.com> X-B4-Tracking: v=1; b=H4sIAGVYt2UC/x3MMQqAMAxA0atIZgM1SLVeRRzURs0SpUERxLtbH N/w/wPGSdigKx5IfInJrhlVWcC8jboySswGclS7igLa3FDr8GI9DSfRKLoaevY0huDJRYbcHok Xuf9vP7zvBwnbDmZnAAAA To: Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Stanimir Varbanov <stanimir.k.varbanov@gmail.com>, Vikash Garodia <quic_vgarodia@quicinc.com>, Bryan O'Donoghue <bryan.odonoghue@linaro.org>, Mauro Carvalho Chehab <mchehab@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org> Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Stanimir Varbanov <stanimir.varbanov@linaro.org>, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss <luca.weiss@fairphone.com> X-Mailer: b4 0.12.4 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789410214175226677 X-GMAIL-MSGID: 1789410214175226677 |
Series |
media: dt-bindings: qcom,sc7280-venus: Allow one IOMMU entry
|
|
Commit Message
Luca Weiss
Jan. 29, 2024, 7:48 a.m. UTC
Some SC7280-based boards crash when providing the "secure_non_pixel"
context bank, so allow only one iommu in the bindings also.
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Reference:
https://lore.kernel.org/linux-arm-msm/20231201-sc7280-venus-pas-v3-2-bc132dc5fc30@fairphone.com/
---
Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml | 1 +
1 file changed, 1 insertion(+)
---
base-commit: 596764183be8ebb13352b281a442a1f1151c9b06
change-id: 20240129-sc7280-venus-bindings-6e62a99620de
Best regards,
Comments
On Mon, Jan 29, 2024 at 08:48:54AM +0100, Luca Weiss wrote: > Some SC7280-based boards crash when providing the "secure_non_pixel" > context bank, so allow only one iommu in the bindings also. > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> Do we have any idea why this happens? How is someone supposed to know whether or not their system requires you to only provide one iommu? Yes, a crash might be the obvious answer, but is there a way of knowing without the crashes? Cheers, Conor. > --- > Reference: > https://lore.kernel.org/linux-arm-msm/20231201-sc7280-venus-pas-v3-2-bc132dc5fc30@fairphone.com/ > --- > Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml > index 8f9b6433aeb8..10c334e6b3dc 100644 > --- a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml > @@ -43,6 +43,7 @@ properties: > - const: vcodec_bus > > iommus: > + minItems: 1 > maxItems: 2 > > interconnects: > > --- > base-commit: 596764183be8ebb13352b281a442a1f1151c9b06 > change-id: 20240129-sc7280-venus-bindings-6e62a99620de > > Best regards, > -- > Luca Weiss <luca.weiss@fairphone.com> >
On Mon Jan 29, 2024 at 6:37 PM CET, Conor Dooley wrote: > On Mon, Jan 29, 2024 at 08:48:54AM +0100, Luca Weiss wrote: > > Some SC7280-based boards crash when providing the "secure_non_pixel" > > context bank, so allow only one iommu in the bindings also. > > > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > > Do we have any idea why this happens? How is someone supposed to know > whether or not their system requires you to only provide one iommu? > Yes, a crash might be the obvious answer, but is there a way of knowing > without the crashes? +CC Vikash Garodia Unfortunately I don't really have much more information than this message here: https://lore.kernel.org/linux-arm-msm/ff021f49-f81b-0fd1-bd2c-895dbbb03d56@quicinc.com/ And see also the following replies for a bit more context, like this one: https://lore.kernel.org/linux-arm-msm/a4e8b531-49f9-f4a1-51cb-e422c56281cc@quicinc.com/ Maybe Vikash can add some more info regarding this. Regards Luca > > Cheers, > Conor. > > > --- > > Reference: > > https://lore.kernel.org/linux-arm-msm/20231201-sc7280-venus-pas-v3-2-bc132dc5fc30@fairphone.com/ > > --- > > Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml > > index 8f9b6433aeb8..10c334e6b3dc 100644 > > --- a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml > > +++ b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml > > @@ -43,6 +43,7 @@ properties: > > - const: vcodec_bus > > > > iommus: > > + minItems: 1 > > maxItems: 2 > > > > interconnects: > > > > --- > > base-commit: 596764183be8ebb13352b281a442a1f1151c9b06 > > change-id: 20240129-sc7280-venus-bindings-6e62a99620de > > > > Best regards, > > -- > > Luca Weiss <luca.weiss@fairphone.com> > >
Hello, On 1/30/2024 1:17 PM, Luca Weiss wrote: > On Mon Jan 29, 2024 at 6:37 PM CET, Conor Dooley wrote: >> On Mon, Jan 29, 2024 at 08:48:54AM +0100, Luca Weiss wrote: >>> Some SC7280-based boards crash when providing the "secure_non_pixel" >>> context bank, so allow only one iommu in the bindings also. >>> >>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> >> >> Do we have any idea why this happens? How is someone supposed to know >> whether or not their system requires you to only provide one iommu? >> Yes, a crash might be the obvious answer, but is there a way of knowing >> without the crashes? > > +CC Vikash Garodia > > Unfortunately I don't really have much more information than this > message here: > https://lore.kernel.org/linux-arm-msm/ff021f49-f81b-0fd1-bd2c-895dbbb03d56@quicinc.com/ > > And see also the following replies for a bit more context, like this > one: > https://lore.kernel.org/linux-arm-msm/a4e8b531-49f9-f4a1-51cb-e422c56281cc@quicinc.com/ > > Maybe Vikash can add some more info regarding this. 0x2184 is a secure SID i.e any transactions with that ID would be access controlled by trustzone (TZ). SC7280 (chromebook) was designed without TZ, while some other DT deriving from SC7280 (like qcm6490) might have TZ. Hence it is good to move the iommu entry from SC7280 to chrome-common. Regards, Vikash
On 29/01/2024 08:48, Luca Weiss wrote: > Some SC7280-based boards crash when providing the "secure_non_pixel" > context bank, so allow only one iommu in the bindings also. > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > --- Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml index 8f9b6433aeb8..10c334e6b3dc 100644 --- a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml +++ b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml @@ -43,6 +43,7 @@ properties: - const: vcodec_bus iommus: + minItems: 1 maxItems: 2 interconnects: