From patchwork Mon Jan 29 16:26:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?K=C3=B6ry_Maincent?= X-Patchwork-Id: 193562 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2087:b0:106:209c:c626 with SMTP id gs7csp680129dyb; Mon, 29 Jan 2024 08:27:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IFRbh/o5kQuFAjrgA4v5sSmJ+HSaJhVjqXlfvJoUcWKZAvl+4xXT53a6i7cIHY9T/D9FFiA X-Received: by 2002:a05:6402:5c4:b0:55f:e9f:f594 with SMTP id n4-20020a05640205c400b0055f0e9ff594mr2113099edx.5.1706545645326; Mon, 29 Jan 2024 08:27:25 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706545645; cv=pass; d=google.com; s=arc-20160816; b=zUSVPHN0Gyzj9P88WeGDUcDCYOnXbLyCa5C2hrbK+zHaBbrUvnXae2sPAigYDJU2q0 T2CqcF9Isq5K1nh7Hf6UsGJWXlkEQ1Mbg0wWHVZpIyFF8NIyHkZHG/oao4CLZW1NtqEV dhn8EdqvX62eAMUjoUiLfsGByH6mZMs8Ky/BOZMlxPO7gV2ZG2BuaZCjIZOzcgFFeWsX el/X+RYwSTkExS6dqqnDyczcUmyyoEZ+QY9cD15v9yfDnWdqb1hcaYvyWYc8ffFac+iG uBEcHN8L2eXW1PQpAuOkENqKtMn1/jeMirNEvqlfhuOBOA4tjkxIOuIniGhUaoyvH/Bc 5+Hw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=svngh7gavoOsAoTd14KvI+aVm1JHod9n5Mvh72UXNZY=; fh=oC1+pIJR2tZdBb9Uzp3yLjqrVYle+8srf2TBxoXLW2Q=; b=aseIA58g9jJuL/5l2TA0A5bDdWWk6VmfTN5dXD2B7upsAt/XIFblADTF9HwClwxTqB jWkAxVIu+h7m1fCLFXafdd5KbOrmJQbIyW8ysbV0xTzrqLkEwUBoqOPiMCWurt16UyXq VSMHubezOkQYxL4VS120GL1YgKqltiTeAna4DXaptzb1CoCLaNaKf4ift2SrixepUrQc 2kuEz0c6UE5HGDS243FCqXGZNV6stepFddsmlh7hDEZTXLWnBmTYJV0u06E5DeetFv00 arDMHiVABqwT2VabhAVF8oKklI5vlCHh/Z9VRVptjL1RQEkW6wYldnC5EOXl2XpZ0rvb IZgA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=Kq7zWzyG; arc=pass (i=1 spf=pass spfdomain=bootlin.com dkim=pass dkdomain=bootlin.com dmarc=pass fromdomain=bootlin.com); spf=pass (google.com: domain of linux-kernel+bounces-43076-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-43076-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id m19-20020aa7c493000000b0055f2012149asi353914edq.417.2024.01.29.08.27.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 08:27:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-43076-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=Kq7zWzyG; arc=pass (i=1 spf=pass spfdomain=bootlin.com dkim=pass dkdomain=bootlin.com dmarc=pass fromdomain=bootlin.com); spf=pass (google.com: domain of linux-kernel+bounces-43076-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-43076-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id EAF611F22FED for ; Mon, 29 Jan 2024 16:27:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 878DF155A22; Mon, 29 Jan 2024 16:26:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="Kq7zWzyG" Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00273155A5F; Mon, 29 Jan 2024 16:26:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.196 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706545571; cv=none; b=FWa9TdkEA0fcWG+yiUiYwPmilUBszONfaidY/qCYiOQOdj2YP95GMkb4+6X0hhpHv2ZSYQuYoPsiPIgF/vuqdGQpdmEveuEc+aKUOaDNkQFLTS6WiM0J4wVr8UNA7t16p7RbTSd+DJjiZvYdODc/vRYChzEaY2McoHm+unycnng= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706545571; c=relaxed/simple; bh=fqv4o+qKl3gS1s7xHmfm0lxwsPu6RFBo7Lq+u+UUsxM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jtBVK3VHav3i5dZKK7hLJUDkfY2RgtTYZ3BTl4a4Okhu8B83pHeuA8MKaeI9vBkZqmdTzZq9L4RVQgpJzFP/ToYQtKw1CyZ3kn0aGyVDtMtAwUe36nQ57zoNxeaoOgUBVr4iDGCsS5BUmlA9iHciAvzFAw5GyXfXEIJXZuf9EKI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=Kq7zWzyG; arc=none smtp.client-ip=217.70.183.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id A9A73E0012; Mon, 29 Jan 2024 16:26:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1706545568; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=svngh7gavoOsAoTd14KvI+aVm1JHod9n5Mvh72UXNZY=; b=Kq7zWzyGymSB4C0hKIBsi+TBs4qe86eZC9Mm5XNrRlLN3O7Azi8Tk8JpXUzAzkjHz7+8mG U3vlauIOB3BY+whBKNcymcmD5Webw9voUAqV6BnHjPOaREEVfHRnaykm2+T643SZsMyplK 7+QWojGybHLSpdK0HjTiyyom6WFN/MTQI9fDeu71b4WlPWzAGHM06FRG+IvR5+io+/gQb2 Bz/QuD17zOhtwuCt6t7W97cgMF6MAHEolr+xcxAUipXHJrCWjXz+0OCZN4P+ZxnTGGj4Q4 WpLN2p+Wz9ivU642RHXGUzy6hUn/MdIjtzU+Tus+mMpq3AAks5tGMGMqNDyvWg== From: Kory Maincent Date: Mon, 29 Jan 2024 17:26:00 +0100 Subject: [PATCH v7 4/6] dmaengine: dw-edma: Add HDMA remote interrupt configuration Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240129-b4-feature_hdma_mainline-v7-4-8e8c1acb7a46@bootlin.com> References: <20240129-b4-feature_hdma_mainline-v7-0-8e8c1acb7a46@bootlin.com> In-Reply-To: <20240129-b4-feature_hdma_mainline-v7-0-8e8c1acb7a46@bootlin.com> To: Manivannan Sadhasivam , Gustavo Pimentel , Serge Semin , Vinod Koul , Cai Huoqing Cc: Thomas Petazzoni , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Herve Codina , Kory Maincent , Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-GND-Sasl: kory.maincent@bootlin.com X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789442806828176675 X-GMAIL-MSGID: 1789442806828176675 Only the local interruption was configured, remote interrupt was left behind. This patch fix it by setting stop and abort remote interrupts when the DW_EDMA_CHIP_LOCAL flag is not set. Fixes: e74c39573d35 ("dmaengine: dw-edma: Add support for native HDMA") Signed-off-by: Kory Maincent Reviewed-by: Serge Semin Acked-by: Manivannan Sadhasivam --- drivers/dma/dw-edma/dw-hdma-v0-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw-hdma-v0-core.c index 108f9127aaaa..04b0bcb6ded9 100644 --- a/drivers/dma/dw-edma/dw-hdma-v0-core.c +++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c @@ -237,6 +237,8 @@ static void dw_hdma_v0_core_start(struct dw_edma_chunk *chunk, bool first) tmp = GET_CH_32(dw, chan->dir, chan->id, int_setup) | HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK | HDMA_V0_LOCAL_STOP_INT_EN | HDMA_V0_LOCAL_ABORT_INT_EN; + if (!(dw->chip->flags & DW_EDMA_CHIP_LOCAL)) + tmp |= HDMA_V0_REMOTE_STOP_INT_EN | HDMA_V0_REMOTE_ABORT_INT_EN; SET_CH_32(dw, chan->dir, chan->id, int_setup, tmp); /* Channel control */ SET_CH_32(dw, chan->dir, chan->id, control1, HDMA_V0_LINKLIST_EN);