From patchwork Sun Jan 28 20:45:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aren X-Patchwork-Id: 193173 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2087:b0:106:209c:c626 with SMTP id gs7csp218696dyb; Sun, 28 Jan 2024 12:49:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IGB+Sqk0lI6d7n4YkgRjJw2v9mci/by3KOHlclLMOQJMhXdkZ4oCAo8dlkB01WYzTXj93UL X-Received: by 2002:a05:6870:a11c:b0:218:4171:f0e1 with SMTP id m28-20020a056870a11c00b002184171f0e1mr4053676oae.59.1706474981666; Sun, 28 Jan 2024 12:49:41 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706474981; cv=pass; d=google.com; s=arc-20160816; b=uxNQ6XcDbNkPyUwrFnB8+vcVxtRFCsNi3LpW8s7cM5ZbI074NLtr9EEUDvQ8DgHybM 8+oh0g2gB1TlruWf8hUud8K0d1of8wPFGIMDIaWmsWy/1no8SwzLiTtIWh/KL86AfY3/ 94jAiMKYuG1fhcXpaVbr1F6FxQTuRCnOUtjRo/RyX2S5he5ddmy7dTv3Ec9c5xXthU8E 9iEBf+WZ7/r5b+uxq01xrahkiEPw7DUkNiTIfGH4xqi8fL5EYPmcsTLrISqjaM+DKMGZ /ssTDLwRZliIMsyt675XYVxJ1ZtcLFxj0ERYTmFi1fcZZ/+CY5fQAQr7Lz1xGEUnFmhI XK4g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=dkim-signature:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :in-reply-to:message-id:date:subject:cc:to:from; bh=d/DBwpJ+je99z0h/gXOCUsLpwa/Zbmn1hRkJbFumB7A=; fh=vogt2Ndq24/cMfcnX2+D+YjJWcEOQng4OQGQG6hZSjo=; b=Yl19tcYNPp7gndHReEgkvZpuJ4/AVePsiFBqhf+i5TMZ53tGlKwY5PHd0KHWy+tL2c HHsadTfExm/ARxBf4HNF/4w2lDzDH0ILaZwPNBYef+bzBGggxG/thVr1rYoyqOJwluTD 173Op/0JlwcvWCN/4kosg82O276c0yM2UQyqCIEcf/b36Xwi21LSugJDIvVRc78J6osh b4hsx2qb/sNVUKKfyk3aUPi4AHeS4vt1CdBWRGwEthYI1fXXl8MqMK10xqsyqS/Gx0iq lWq7KLFz9y6fPe5noWIAUiwAYuShLBW+aDPfnsNpXO7p8zkf1jh4OqW+Hh4JsFcwn8SR oqEQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@peacevolution.org header.s=dkim header.b=LCKLWsPl; arc=pass (i=1 spf=pass spfdomain=peacevolution.org dkim=pass dkdomain=peacevolution.org dmarc=pass fromdomain=peacevolution.org); spf=pass (google.com: domain of linux-kernel+bounces-41951-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-41951-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=peacevolution.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id cl2-20020a056a02098200b005d23a86b256si4655451pgb.688.2024.01.28.12.49.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jan 2024 12:49:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-41951-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@peacevolution.org header.s=dkim header.b=LCKLWsPl; arc=pass (i=1 spf=pass spfdomain=peacevolution.org dkim=pass dkdomain=peacevolution.org dmarc=pass fromdomain=peacevolution.org); spf=pass (google.com: domain of linux-kernel+bounces-41951-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-41951-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=peacevolution.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 6A1992831AE for ; Sun, 28 Jan 2024 20:49:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BC0C942059; Sun, 28 Jan 2024 20:48:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=peacevolution.org header.i=@peacevolution.org header.b="LCKLWsPl" Received: from a.peacevolution.org (a.peacevolution.org [206.189.193.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8CB33D568; Sun, 28 Jan 2024 20:48:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=206.189.193.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706474932; cv=none; b=okGhcue5hG0yueaezKnh0BqhNSMRs2PUEa0GFzhGfQOxPQuzc6KXxc1VXESqT8VaLxiQidz3VSNrJGav2F/Hf4orXc7l7GrwosEakVorVGnM1XPD5ps0FMsQ5wcunksgnqxviaceQHxl7G+Sw3nQYxXN/UKPqudQU7wreEejSyI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706474932; c=relaxed/simple; bh=0llpIrBcrSsgkq+tDt1UudYHAWxp0O8mGXQOF1XSgn0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VOFuyXajjpI9cES4T0zLQasnOgyrkULcFwVe5ivt21yCcPbzRoKzNTbaGUHyeFMsxj3RAuZ/XH0hzh1L3gPHcARMMw+0hFKRQWvK/pSgB+GlBgx9KRuD5y4q1J36Zg7mhCG50AUt0S16Oz9gPGUQWBh6hdIFocvHfLHSLsVRCXo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peacevolution.org; spf=pass smtp.mailfrom=peacevolution.org; dkim=pass (1024-bit key) header.d=peacevolution.org header.i=@peacevolution.org header.b=LCKLWsPl; arc=none smtp.client-ip=206.189.193.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peacevolution.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=peacevolution.org Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by a.peacevolution.org (Postfix) with ESMTPA id F2CFE46366; Sun, 28 Jan 2024 20:48:48 +0000 (UTC) From: Aren Moynihan To: linux-kernel@vger.kernel.org Cc: Miles Alan , Ondrej Jirman , Aren Moynihan , Chen-Yu Tsai , Conor Dooley , Jernej Skrabec , Krzysztof Kozlowski , Rob Herring , Samuel Holland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: [PATCH 4/4] arm64: dts: sun50i-a64-pinephone: change led type to status Date: Sun, 28 Jan 2024 15:45:10 -0500 Message-ID: <20240128204740.2355092-4-aren@peacevolution.org> In-Reply-To: <20240128204740.2355092-1-aren@peacevolution.org> References: <20240128204740.2355092-1-aren@peacevolution.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Authentication-Results: auth=pass smtp.auth=aren@peacevolution.org smtp.mailfrom=aren@peacevolution.org X-Spam-Level: **** X-Spamd-Bar: ++++ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=peacevolution.org; s=dkim; t=1706474929; h=from:subject:date:message-id:to:cc:mime-version:content-transfer-encoding:in-reply-to:references; bh=d/DBwpJ+je99z0h/gXOCUsLpwa/Zbmn1hRkJbFumB7A=; b=LCKLWsPlqvRQtiFZG1vk9RGo0PpHdusVxfhM+KBizv3IAzHDsEBOKiiqeQm2cRJysOQFlj yPD70phfaq/ONb8DwmyRcEqXprMWwQOEdEHKTscwSMPBAhH8XM4LwjOs+hHD/8GPzG1smq Sh/bcnY8qMKjVHRvgiSCewPgy+j4XG4= X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789368710493808064 X-GMAIL-MSGID: 1789368710493808064 The status function is described in the documentation as being a rgb led used for system notifications on phones[1][2]. This is exactly what this led is used for on the PinePhone, so using status is probably more accurate than indicator. 1: Documentation/leds/well-known-leds.txt 2: include/dt-bindings/leds/common.h Signed-off-by: Aren Moynihan --- I can't find any documentation describing the indicator function, so it's definitely less specific than status, but besides that I'm not sure how it compares. Please ignore this patch if it's not useful and/or just causing churn. arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi index 6eab61a12cd8..4f39cfeb13ec 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi @@ -40,21 +40,21 @@ leds { compatible = "gpio-leds"; led0: led-0 { - function = LED_FUNCTION_INDICATOR; + function = LED_FUNCTION_STATUS; color = ; gpios = <&pio 3 20 GPIO_ACTIVE_HIGH>; /* PD20 */ retain-state-suspended; }; led1: led-1 { - function = LED_FUNCTION_INDICATOR; + function = LED_FUNCTION_STATUS; color = ; gpios = <&pio 3 18 GPIO_ACTIVE_HIGH>; /* PD18 */ retain-state-suspended; }; led2: led-2 { - function = LED_FUNCTION_INDICATOR; + function = LED_FUNCTION_STATUS; color = ; gpios = <&pio 3 19 GPIO_ACTIVE_HIGH>; /* PD19 */ retain-state-suspended; @@ -64,7 +64,7 @@ led2: led-2 { multi-led { compatible = "leds-group-multicolor"; color = ; - function = LED_FUNCTION_INDICATOR; + function = LED_FUNCTION_STATUS; leds = <&led0>, <&led1>, <&led2>; };