[net-next] net: lan966x: debugfs: Fix showing the port keyset

Message ID 20240128195134.3600629-1-horatiu.vultur@microchip.com
State New
Headers
Series [net-next] net: lan966x: debugfs: Fix showing the port keyset |

Commit Message

Horatiu Vultur Jan. 28, 2024, 7:51 p.m. UTC
  On lan966x, it is possible to use debugfs to print different information
about the VCAPs. Information like, if it is enabled, how the ports are
configured, print the actual rules. The issue is that when printing how
the ports are configured for IS1 lookups, it was parsing the wrong
register to get this information. The fix consists in reading the
correct register that contains this information.

Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
---
 drivers/net/ethernet/microchip/lan966x/lan966x_vcap_debugfs.c | 2 ++
 1 file changed, 2 insertions(+)
  

Comments

patchwork-bot+netdevbpf@kernel.org Jan. 31, 2024, 1:40 p.m. UTC | #1
Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Sun, 28 Jan 2024 20:51:34 +0100 you wrote:
> On lan966x, it is possible to use debugfs to print different information
> about the VCAPs. Information like, if it is enabled, how the ports are
> configured, print the actual rules. The issue is that when printing how
> the ports are configured for IS1 lookups, it was parsing the wrong
> register to get this information. The fix consists in reading the
> correct register that contains this information.
> 
> [...]

Here is the summary with links:
  - [net-next] net: lan966x: debugfs: Fix showing the port keyset
    https://git.kernel.org/netdev/net-next/c/e746094b1bb0

You are awesome, thank you!
  

Patch

diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_vcap_debugfs.c b/drivers/net/ethernet/microchip/lan966x/lan966x_vcap_debugfs.c
index ac525ff1503e6..3a01e13bd10b7 100644
--- a/drivers/net/ethernet/microchip/lan966x/lan966x_vcap_debugfs.c
+++ b/drivers/net/ethernet/microchip/lan966x/lan966x_vcap_debugfs.c
@@ -25,6 +25,8 @@  static void lan966x_vcap_is1_port_keys(struct lan966x_port *port,
 	for (int l = 0; l < admin->lookups; ++l) {
 		out->prf(out->dst, "\n    Lookup %d: ", l);
 
+		val = lan_rd(lan966x, ANA_VCAP_S1_CFG(port->chip_port, l));
+
 		out->prf(out->dst, "\n      other: ");
 		switch (ANA_VCAP_S1_CFG_KEY_OTHER_CFG_GET(val)) {
 		case VCAP_IS1_PS_OTHER_NORMAL: