diff mbox series

[v2,3/4] dt-bindings: arm: qcom: Add Samsung Galaxy S5 China (kltechn)

Message ID 20240127172155.63624-4-i@rong.moe
State New
Headers
Series ARM: dts: qcom: msm8974: Add Samsung Galaxy S5 China support |

Commit Message

Rong Zhang Jan. 27, 2024, 5:21 p.m. UTC 
  Document Samsung Galaxy S5 China (kltechn) as a klte variant based on
msm8974pro. Also including "samsung,klte" in the compatible chain as
kltechn works fine with the klte DTB except for LEDs and WiFi missing.

Signed-off-by: Rong Zhang <i@rong.moe>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Krzysztof Kozlowski Jan. 29, 2024, 8:20 a.m. UTC | #1 
On 27/01/2024 18:21, Rong Zhang wrote:
> Document Samsung Galaxy S5 China (kltechn) as a klte variant based on
> msm8974pro. Also including "samsung,klte" in the compatible chain as
> kltechn works fine with the klte DTB except for LEDs and WiFi missing.
> 
> Signed-off-by: Rong Zhang <i@rong.moe>
> ---

This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.

Best regards,
Krzysztof
Rong Zhang Jan. 29, 2024, 8:40 a.m. UTC | #2 
On Mon, 2024-01-29 at 09:20 +0100, Krzysztof Kozlowski wrote:
> On 27/01/2024 18:21, Rong Zhang wrote:
> > Document Samsung Galaxy S5 China (kltechn) as a klte variant based on
> > msm8974pro. Also including "samsung,klte" in the compatible chain as
> > kltechn works fine with the klte DTB except for LEDs and WiFi missing.
> > 
> > Signed-off-by: Rong Zhang <i@rong.moe>
> > ---
> 
> This is a friendly reminder during the review process.
> 
> It looks like you received a tag and forgot to add it.
> 
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions, under or above your Signed-off-by tag. Tag is "received", when
> provided in a message replied to you on the mailing list. Tools like b4
> can help here. However, there's no need to repost patches *only* to add
> the tags. The upstream maintainer will do that for tags received on the
> version they apply.
> 
> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

Sorry for forgetting that. I will check more precisely the next time.

> If a tag was not added on purpose, please state why and what changed.

I meant not to add your Acked-by because the dt-binding has changed
into a different form to make it consistent with the kltechn DTS. I
should have stated it but hopefully it's not too late to ask if the new
dt-binding is still eligible to receive your ACK.


Thanks,
Rong
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 1a5fb889a444..4979ccae2b64 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -227,6 +227,13 @@  properties:
           - const: qcom,msm8974pro
           - const: qcom,msm8974
 
+      - items:
+          - enum:
+              - samsung,kltechn
+          - const: samsung,klte
+          - const: qcom,msm8974pro
+          - const: qcom,msm8974
+
       - items:
           - const: qcom,msm8916-mtp
           - const: qcom,msm8916-mtp/1