From patchwork Sat Jan 27 07:47:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yu Kuai X-Patchwork-Id: 192981 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2395:b0:106:343:edcb with SMTP id gw21csp366508dyb; Fri, 26 Jan 2024 23:56:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IFzcclfmGc26fC8h0CHoEOnGJl9DD7/2+X57bVPifrz2Q04D+524lelpQ9pFsCfAjGIS+Vy X-Received: by 2002:a05:6402:35c4:b0:55d:20f2:11c9 with SMTP id z4-20020a05640235c400b0055d20f211c9mr553930edc.25.1706342175749; Fri, 26 Jan 2024 23:56:15 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706342175; cv=pass; d=google.com; s=arc-20160816; b=e89Y4zWaizSu4xwGI8MfbfnHaF8NgPZM7w5B0vTNUYkdrS/cNgbyeukwSDOmx1lFS5 9z7FJTaNUeZLhCibkdl+Vi1sV18xlkOJ+Rq3H34oitveqAfysHfI/vFG5nwr3hqN5WUt XYGJJ43lfhXYvVd3kaP0Fqsj0Lo08zYFYLtEzqCHU7GEZc+16JWHzj5swUzzMkGNet9M L5yTcbv3k0uepoUP+WpOWb9Pxw2NEIYs9P3L84wsHdfqm5ESu14/Rsefu8llMDRAS5Fg 9MGdte2N4vFBY1VNNk5PUhIjegz6YH+DDtzmwhLcF5pf5/MGbcxLXyXQ4grj6fSnUgtL bMIA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=2PLuUPSEGkCExEuQnmS0iMG66HGiFKczIcjG7JoyIGg=; fh=FtirvJJ13L8gehLQ375a0lCTkAroffAi0JfnF40Fa78=; b=Jt7HwrI+zUwgtwyQA+xkjU/Kz8NoxEgzl8bU0hJGofCO4I2LUpWl7sYVa8HuXrdWFk TjBsDG+DA5HMy2SyFrSmAvStVOA3BacUs9zIsXd4a2hVmU53nfKSxd8H21QVLAyrxUJv nmfXU4vJ2y7NuWDnrX93Wzwl9DnvMzSUfZkchPqs/mCRP5bCP3t8aeIgr1Wi+OoyLhlv wrW/U2KxNHwsxqFVuc2zs7koIbNHIM+k1myr2mFADd9bFoVZKCC2QBAKFy9ljpUFM8zg d45wA/rJ+olZJZAfw80dh6Xf4ScfnB5rWeEzQ246mAKy8KK+KwTMh/xd9tuChUBFF65p He2A== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=huaweicloud.com); spf=pass (google.com: domain of linux-kernel+bounces-41103-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-41103-ouuuleilei=gmail.com@vger.kernel.org" Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id eo8-20020a056402530800b0055845379c80si1556789edb.115.2024.01.26.23.56.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 23:56:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-41103-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=huaweicloud.com); spf=pass (google.com: domain of linux-kernel+bounces-41103-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-41103-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id BBC4E1F220A0 for ; Sat, 27 Jan 2024 07:56:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C3EFC2942F; Sat, 27 Jan 2024 07:52:39 +0000 (UTC) Received: from dggsgout12.his.huawei.com (unknown [45.249.212.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BB3E24B5F; Sat, 27 Jan 2024 07:52:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706341958; cv=none; b=I2sBARf3LNwb7YdhAaA9MQu+bieuPSWl4alk5kBPxuAf3y51BP6UxurRIq5x8s4YohvAS48MTpD9ALotZZNLYL9v3JoZSC6uNQsWa8XpjS15HM4r8vqPpLaBXFH23SsD0h/U36x30T7Ski5I8JxVMK6Sr1mKk+KUANXNlwaL/ts= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706341958; c=relaxed/simple; bh=jdkIPGev0C5+tMmvWTmPjir2mBpBE6qhDyE0vWrNCf0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jy8ZwEEby+YgtHPALk9NTNhvh74yPe9VE4TKP0PqNgRy3K4TjYpOWoVcQ9snQu5zlDBDjJlJtcbB1iCtBhu2ny0unDkC8oHPc9itwvFJtfTL2m/cHTvwym5trTO3gnBpNmOjfjBnUc/Mt5L2UH0bFqU0ResUbCGVcVrvO69c1RQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.163.216]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4TMRcF0k7nz4f3kFH; Sat, 27 Jan 2024 15:52:29 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.112]) by mail.maildlp.com (Postfix) with ESMTP id 1D1E51A017A; Sat, 27 Jan 2024 15:52:33 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.104.67]) by APP1 (Coremail) with SMTP id cCh0CgDHlxAetrRlWjeACA--.31980S16; Sat, 27 Jan 2024 15:52:32 +0800 (CST) From: Yu Kuai To: mpatocka@redhat.com, heinzm@redhat.com, xni@redhat.com, agk@redhat.com, snitzer@kernel.org, dm-devel@lists.linux.dev, song@kernel.org, yukuai3@huawei.com, jbrassow@f14.redhat.com, neilb@suse.de, shli@fb.com, akpm@osdl.org Cc: linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, yukuai1@huaweicloud.com, yi.zhang@huawei.com, yangerkun@huawei.com Subject: [PATCH v3 12/12] dm-raid: fix lockdep waring in "pers->hot_add_disk" Date: Sat, 27 Jan 2024 15:47:54 +0800 Message-Id: <20240127074754.2380890-13-yukuai1@huaweicloud.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240127074754.2380890-1-yukuai1@huaweicloud.com> References: <20240127074754.2380890-1-yukuai1@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-CM-TRANSID: cCh0CgDHlxAetrRlWjeACA--.31980S16 X-Coremail-Antispam: 1UD129KBjvJXoW7Cr45Jw1UZF45JF13GFW5GFg_yoW8Jw4Up3 ZrK343Kw4DJr48Za1qvw1q9a45Jan8K3ySyrZxG395ZFy7ZrZI9ws8Ga1agFWDAFZ3ta98 AFW3J398W3Z8K37anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUPI14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2048vs2IY020E87I2jVAFwI0_JF0E3s1l82xGYI kIc2x26xkF7I0E14v26ryj6s0DM28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2 z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j6F 4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oVCq 3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7 IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4U M4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02628vn2 kIc2xKxwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E 14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_GFv_WrylIx kGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVW8JVW5JwCI42IY6xIIjxv20xvEc7CjxVAF wI0_Gr1j6F4UJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Gr 0_Cr1lIxAIcVC2z280aVCY1x0267AKxVW8Jr0_Cr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUQ SdkUUUUU= X-CM-SenderInfo: 51xn3trlr6x35dzhxuhorxvhhfrp/ X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789229453130892519 X-GMAIL-MSGID: 1789229453130892519 From: Yu Kuai The lockdep assert is added by commit a448af25becf ("md/raid10: remove rcu protection to access rdev from conf") in print_conf(). And I didn't notice that dm-raid is calling "pers->hot_add_disk" without holding 'reconfig_mutex'. "pers->hot_add_disk" read and write many fields that is protected by 'reconfig_mutex', and raid_resume() already grab the lock in other contex. Hence fix this problem by protecting "pers->host_add_disk" with the lock. Fixes: 9092c02d9435 ("DM RAID: Add ability to restore transiently failed devices on resume") Fixes: a448af25becf ("md/raid10: remove rcu protection to access rdev from conf") Signed-off-by: Yu Kuai --- drivers/md/dm-raid.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index ede2e4574ee5..ed8c28952b14 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -4075,7 +4075,9 @@ static void raid_resume(struct dm_target *ti) * Take this opportunity to check whether any failed * devices are reachable again. */ + mddev_lock_nointr(mddev); attempt_restore_of_faulty_devices(rs); + mddev_unlock(mddev); } if (test_and_clear_bit(RT_FLAG_RS_SUSPENDED, &rs->runtime_flags)) {