From patchwork Sat Jan 27 00:35:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 192926 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2395:b0:106:343:edcb with SMTP id gw21csp236803dyb; Fri, 26 Jan 2024 16:38:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IG3xxzqrAyy8pFAp2iq27Y61dLUUP4XlC9slm+9fzJCd065wK4t3l7mXdegXVy47ccEg13F X-Received: by 2002:a17:906:4719:b0:a31:117b:8b54 with SMTP id y25-20020a170906471900b00a31117b8b54mr597878ejq.15.1706315912353; Fri, 26 Jan 2024 16:38:32 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706315912; cv=pass; d=google.com; s=arc-20160816; b=tSDazTLlkcJOMzwUPTiC5Z6xjzVw+rKW1ix6IoqcT5QnOwPCJkXdWKPmgP8XcfNXUo uThwLSK2ZPnjupZVnmPdBDi3pEe+SXx7HHUrqCU8FHSMF/12Khvn/PmmQHQ5Cz5EyK44 RaOUVFCUUao4UYNWPjntgZZT1cRW7pdeAhycqynHT+645qKKM7zQX28z/8ClEtWB8ce0 8YvwhXqjpQ4CDDkLXZqTegz/xInh56WjIwUZLf7LP5f3dXYd65yZJAIbDASqY03Q1+A2 /9DKIVCpRy4zDVIh1GW44y4laLz1qh9thd8zfIgBqczpSvPoN0KqNG4iOlq5sG/jGAIp 8phQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=FJ73thBf2vHveKg87OgpLBqSvGw1l2TtG/ztHfLjlvM=; fh=WrhIizNXy+YZmlhXQ3CjStW2Q+f/L9mPBsAa/xOhbRk=; b=v7UIIMLnlnYrv1ipxKr/NM+JTHHA28IZmM48AY+FxAKRnaitke/3E+buee1zZcJIKA qcIb9rTxWafBa42YskCZcL8L1Sp12Pb8vZ2fUWiUJWWrzoFj7AxwcG7BjBC92A18t++F mT8F+i+IWFQfqDUf1iS1t8Pu7J0vKpCpw3OCS7ACsNfV3NAERnSCQ2PhvT3JoZ/MM98e SCYQDeB3hGuQOQC+WZhmelD3sc6aSvfipaue4modtU9B/EMAFDFlxGq7W7caKQidSE2H QBpt60Hq++j2djpph9p86ypzudlRFxekSD1c2V29FJu7yC66TjdUO+frJ7HaNNpP4oJQ iIdg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lefWfPh9; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-40941-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-40941-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id q13-20020a170906b28d00b00a34a1cc2a27si1070807ejz.360.2024.01.26.16.38.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 16:38:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-40941-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lefWfPh9; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-40941-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-40941-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id EF3C31F2629C for ; Sat, 27 Jan 2024 00:38:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 18FBFC127; Sat, 27 Jan 2024 00:37:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lefWfPh9" Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE00CEB8 for ; Sat, 27 Jan 2024 00:37:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706315830; cv=none; b=jd6l0EE+rEP/IihqzDh5G0V5aS8jYWRpPhGqixRsuOFVGfSkt37gxHF62qNP3QoUQHqbEbNro2cPqpit//DvSPEoJIIFbePsntKS6Dnys2Xu+cQwurou2hk+W0E30AGShgR0OPtYL9kXDELpV7MJpHGlA4DD+vd43xBbXZ8t1/M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706315830; c=relaxed/simple; bh=/GiPFN5+QIgnjdQBA8vewMsdqYN795L0TQdClULeVuM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Iu+aqsusMxl8k0xF3IHhrHPxeycBTpimT7x2qNL3fr8Uu0RIug1xVpWIAiqXqYmx+RtNXRh8iCZN7u55VyAtod9PkVh7Bx/Nu1jxrV2DB8e4EA9PjIvVvjNidMxq/PttqZbjfxyOHuOves4dvl76iYVQmF3E76J+5JWwrx/GFR4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lefWfPh9; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a2f22bfb4e6so177121266b.0 for ; Fri, 26 Jan 2024 16:37:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706315826; x=1706920626; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FJ73thBf2vHveKg87OgpLBqSvGw1l2TtG/ztHfLjlvM=; b=lefWfPh9GJ/MjcuUN9BLLLcXibRBb96oAnzt1TY9nJ1kZ5oH/4K2PR12QnRGcCAdYb W7PvQrENEd0ZgVeDQS1lAbfrPK3EPpLorTp/0uuqjTVj6fJh+aq1OYykrXXoUVDKz0Ye YX3JsMziNduUB9xj5IirWfX4Ek2iTb32e2rkTnxnmOu/60HwuQkvMFa6wCQ0JGSDzHhN yd0GJ4078Bv1vmfkywqrd0sFlPeRl7RjDml3LwOk2PeBXz9TOQjDMaw7eX/5hK9TeDr9 WvTohVDWERztZwTFcH9/flZZ9iWXIAVdTA9YPOY4NwaXU9J0uQZDJKhfr8dhlF0ZqFqJ i5vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706315826; x=1706920626; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FJ73thBf2vHveKg87OgpLBqSvGw1l2TtG/ztHfLjlvM=; b=pGCg4gapkSvNA6evcfAOEQN08vgrCU3YvJ0IHXhebQBV57v25AekDmk4QsyS8TRlhS 5YGjWfPTBIJ6SMGTSwczTAcH4aqEHgmePN+XOUDVuARQtwXjOSV288KlziRSNQT4EqdD XjOwg5SFhL5FGG0DqZWEBgtp9AYuSu9uWAHFg5fuaR1lKyNNEfzio0Be2pihcghitD/6 z4BniIGlnb17aMdaxnwYksMpR/+PxBzl0CxZQMWHD8eds95mFTYBhiij1KhIaOUVEQPa Zd8QKHGENfDUvfhSLK1hWHE6wrQByUS9xtvM1+Sp6V6Mph9LzH1tkh2HvS/6P2H1RCgU /FSw== X-Gm-Message-State: AOJu0YzptITKyTA7fxx/v5XdwMRI99I3A7bCFQ0yuson/7xg3+wtCX46 PWP+M8mksytu3SYa2sEHiwwJjQ9Jhv/Yte5PyNexgM0zoBQigoITx83UvlEKrp4= X-Received: by 2002:a17:906:8308:b0:a31:3745:33fb with SMTP id j8-20020a170906830800b00a31374533fbmr530874ejx.51.1706315826128; Fri, 26 Jan 2024 16:37:06 -0800 (PST) Received: from puffmais.c.googlers.com.com (229.112.91.34.bc.googleusercontent.com. [34.91.112.229]) by smtp.gmail.com with ESMTPSA id vi1-20020a170907d40100b00a2f48a43c3esm1152235ejc.7.2024.01.26.16.37.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 16:37:05 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= To: peter.griffin@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, tudor.ambarus@linaro.org, willmcvicker@google.com, semen.protsenko@linaro.org, alim.akhtar@samsung.com, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 3/5] arm64: dts: exynos: gs101: use correct clocks for usi8 Date: Sat, 27 Jan 2024 00:35:52 +0000 Message-ID: <20240127003607.501086-4-andre.draszik@linaro.org> X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog In-Reply-To: <20240127003607.501086-1-andre.draszik@linaro.org> References: <20240127003607.501086-1-andre.draszik@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789201914214876304 X-GMAIL-MSGID: 1789201914214876304 Wrong pclk clocks have been used in this usi8 instance here. For USI and I2C, we need the ipclk and pclk, where pclk is the bus clock. Without it, nothing can work. It is unclear what exactly is using USI8_USI_CLK, but it is not required for the IP to be operational at this stage, while pclk is. This also brings the DT in line with the clock names expected by the usi and i2c drivers. Update the DTSI accordingly. Fixes: 6d44d1a1fb62 ("arm64: dts: exynos: gs101: define USI8 with I2C configuration") Signed-off-by: André Draszik Reviewed-by: Sam Protsenko Reviewed-by: Tudor Ambarus Tested-by: Tudor Ambarus --- arch/arm64/boot/dts/exynos/google/gs101.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi index bc251e565be6..e5b665be2d62 100644 --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi @@ -380,7 +380,7 @@ usi8: usi@109700c0 { ranges; #address-cells = <1>; #size-cells = <1>; - clocks = <&cmu_peric0 CLK_GOUT_PERIC0_CLK_PERIC0_USI8_USI_CLK>, + clocks = <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_7>, <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_7>; clock-names = "pclk", "ipclk"; samsung,sysreg = <&sysreg_peric0 0x101c>; @@ -397,7 +397,7 @@ hsi2c_8: i2c@10970000 { pinctrl-names = "default"; pinctrl-0 = <&hsi2c8_bus>; clocks = <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_7>, - <&cmu_peric0 CLK_GOUT_PERIC0_CLK_PERIC0_USI8_USI_CLK>; + <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_7>; clock-names = "hsi2c", "hsi2c_pclk"; status = "disabled"; };