From patchwork Fri Jan 26 15:19:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chao Yu X-Patchwork-Id: 192650 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:fa17:b0:106:343:edcb with SMTP id ju23csp4459dyc; Fri, 26 Jan 2024 07:20:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IHEOt7EPTwCvj6nhxnxD5VkGVLXmFF3R4OPbFXTRD0lkY3uo3Y2uy8ARQ+IrYduUv5tvwNM X-Received: by 2002:a05:6a21:6da0:b0:19c:8620:81e with SMTP id wl32-20020a056a216da000b0019c8620081emr1646035pzb.54.1706282450532; Fri, 26 Jan 2024 07:20:50 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706282450; cv=pass; d=google.com; s=arc-20160816; b=a+rh1q+NmM4EaMAZZh/ypjDXgafeVZuzTtkk2j7Llfn9DA/ly30lzCGDUavYuE2Sbj yHDD7c+xHO4J7HT85AyZm1GCc/BepnO9/uaqBB/WAKOSOpL57vcB5/vJIL/NNaoG8C2m 9QvZcPI30IykPjp3AXHhsL16wWcB9hQsqHgeIRZtRQdUhogcP0KfR6K7mkb6RPdlLPpV d0BzmsSKRKpuG6tMGsrpN5lK3tjlGJIYQERKpu1fhnk9Y9TZEZdPRP5F+hixqAuY+kTn JyEvCN9dsYKg/AJ5TR5ev/tcwiAJe3+hGtc4tLQu4asi9f42WCfoEvNP/7vpRL67C7FC uBRw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=SSGu4NLDD5D2HenSgEFat3Ig4z9NZ5ue9NpxxKrKMg4=; fh=X1/oBJvTGJUQ0YtRp03u+3tPfRw/dXXALWynfOSlfQQ=; b=RpWllflREyT+yKGenZWtaV2O/TzJmhvM4Zikfsch0cJfHuUxAfO19TxzXha2C6w8a7 CZfOXT9tK/Bx0yTRPmFwmOImV59f3rpIp84mVRpF2w74aSbjoB4T0C0KV0Pxzz1u+cQs 9U2bQuRYtkyBivEu1mmMnhBZ15NIeWXoTIGhmnqnSl7cf48DcBHXIAlJoWyJ0HxaJ+FX spz9zaXoyXF/g9fatPY3VPj8tUh8xTHOw5Hd8+IRT0Asp4Z+ckN/FPsaawhQUCmxqmrs c+7vTyuKT3kM3yhYqQf1E0yozFSKNcftvZh1QpRf6Pr72BWkFT+Mr8VYmMhcHzaJyHnn zh4A== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="o/lKFtS3"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-40259-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-40259-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id u69-20020a638548000000b005cdf7b74d05si1253607pgd.291.2024.01.26.07.20.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 07:20:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-40259-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="o/lKFtS3"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-40259-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-40259-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D4805282D70 for ; Fri, 26 Jan 2024 15:20:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EF1BB1DA22; Fri, 26 Jan 2024 15:19:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="o/lKFtS3" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4033B1D526 for ; Fri, 26 Jan 2024 15:19:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706282394; cv=none; b=f1aAmN/u1LXpvqaCE0ZUNit24G3CdH5MuB8Np5FgqGBSZmnowOxvQMW7roXUrIsbov0Oid1Zfo8eP/CrJTy4tj+IqJc7Tvw6LX69loHGzQWDeFTckhHtwsSyD//CphzN7X0Jt1DeJO8RzVP/oDvqdIVqxjvu+gGUD+TVmUdQuHg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706282394; c=relaxed/simple; bh=ZtyUk0RkyPEdvpNQ+7kxFdt/jzM49VUpcfVYCbc7d8E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CDj1QtY3sqMxs+izZ8ILR5AaN4NetqiVleIt67xntig4e8NdvKNMTI3N1RILB7l1z14mlrMQQO/FlqwcVl6KZWs94JXv8+LhPMvx1UGI4GC6hWG3472mRMw6DGZ23r80QLGjFVl4kZjm2lr2tDjD4gRVy0pqab8DLr0lAj/viK0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=o/lKFtS3; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56B34C43399; Fri, 26 Jan 2024 15:19:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706282393; bh=ZtyUk0RkyPEdvpNQ+7kxFdt/jzM49VUpcfVYCbc7d8E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=o/lKFtS3SEBsyc03ZV7lLYkFi7Cr7qlb5YWRz43hAwGBNPt3Kjc5KNU4hXm9cu24D yMTnqZ2kDFrriyvoFvFzuuzbBs0TleEH5Be+MCoSXV5vwHBBa08hYHCH2zfsUAHyYj MY1DiabtwZ+a5vBOTjaTr00oomXPvw299JQQ+sB0kdaK8DArWPhf8gPgPsqaVKU4rq bbvuGIHaRWFXy5Q6WHapuuu4sQm4THUn37/NWxyC3qRijDH2nZ/zWQzadplq8C1EQp 27hwuh4uyKULz44GQHDp2S/f8emx5w0se1Ne2KyNZnrsFWTbm4Q6CbNmO8GEcpVlOA Ff9xNb3BzlMRA== From: Chao Yu To: jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu Subject: [PATCH 2/2] f2fs: use f2fs_err_ratelimited() to avoid redundant logs Date: Fri, 26 Jan 2024 23:19:17 +0800 Message-Id: <20240126151917.837565-2-chao@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240126151917.837565-1-chao@kernel.org> References: <20240126151917.837565-1-chao@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789166827181052560 X-GMAIL-MSGID: 1789166827181052560 Use f2fs_err_ratelimited() to instead f2fs_err() in f2fs_record_stop_reason() and f2fs_record_errors() to avoid redundant logs. Signed-off-by: Chao Yu --- fs/f2fs/super.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index 4ca390363131..f0fa76d227e4 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -4096,7 +4096,9 @@ static void f2fs_record_stop_reason(struct f2fs_sb_info *sbi) f2fs_up_write(&sbi->sb_lock); if (err) - f2fs_err(sbi, "f2fs_commit_super fails to record err:%d", err); + f2fs_err_ratelimited(sbi, + "f2fs_commit_super fails to record stop_reason, err:%d", + err); } void f2fs_save_errors(struct f2fs_sb_info *sbi, unsigned char flag) @@ -4139,8 +4141,9 @@ static void f2fs_record_errors(struct f2fs_sb_info *sbi, unsigned char error) err = f2fs_commit_super(sbi, false); if (err) - f2fs_err(sbi, "f2fs_commit_super fails to record errors:%u, err:%d", - error, err); + f2fs_err_ratelimited(sbi, + "f2fs_commit_super fails to record errors:%u, err:%d", + error, err); out_unlock: f2fs_up_write(&sbi->sb_lock); }