From patchwork Fri Jan 26 07:40:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nylon Chen X-Patchwork-Id: 192439 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:e09d:b0:103:945f:af90 with SMTP id gm29csp531817dyb; Fri, 26 Jan 2024 01:02:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IHC9SRGAlmpv0Gk28HqnFKR2PdCciPjqQzP+yFqFWQWR6PU1SjuoX/EILg2BSj3AToqUREn X-Received: by 2002:a9d:7f0f:0:b0:6dd:ec2c:aecb with SMTP id j15-20020a9d7f0f000000b006ddec2caecbmr1156343otq.1.1706259778689; Fri, 26 Jan 2024 01:02:58 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706259778; cv=pass; d=google.com; s=arc-20160816; b=W152TxRwdg9zf77iG/cMFIsY/Vo3B+j90v8sdYBfoQ9zN9mTQTvelLGjBAMOV0iPOL Z9/HekDNw+BuwFiEbvAaUQCh+8pto90z/GfoBB4G5PhNJ+F6ay4DWKJdn9sUdb27adCY 2qAN4cZ432Kl2YHlBl8YF1cPxjL6FzQ51MrIzkv3HkA1a6JaYfRt/OQPep8kzTVn5S7q q3UKOPlinFKzrl1xK31VmxXGu/z25afXHYYMefyn/ew4GZSy+4UnrTNr/YlWGTs+iILq lHc5NTqT+0i0nrMIwlHzyMWAkrAz2r1PbP9CkXGp0hvw1eZiq71vbB+teyojT2O/lEEM 6nnQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=rRcRbgsRNptjKbWJltVNRyiCjNqQwGUOGyfVxx0zgtk=; fh=Qrb5Ac7Hx58Fd/ge8iuFOuOgZDMQwo5h6kfwZmwjKZA=; b=0mnhI1FTI4S92HFrNPeT1ryu50FxcUzMCM8vwotzJ24wKHG5i5W5hjqV6sBogwFrKG NT+Zd95D2kOM/fkre7O2bBneuKFRYsmBASXHeS0+3o8MGtn98CEaksqgmdos0c7NcuDF RioIrSuJlbztpjq5OhjGciyTeksBnND0NeJjJCTQuX4jKCoEurvhDsBZ5ZyVcCzGF1qG 8v0x68qp2VWPXlbkjq6icIKJMZDzgGUDkNwR5o8KHgJACyc5oI3zahrW+8SR1/JTKk0q xndyb1Xn1IPksnecymvqNqteR8WgAZOTEPh3f95uDSoRWzWEavzz1Lw5gnhEglrHa8T7 pcUg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=PBYHx9+0; arc=pass (i=1 spf=pass spfdomain=sifive.com dkim=pass dkdomain=sifive.com dmarc=pass fromdomain=sifive.com); spf=pass (google.com: domain of linux-kernel+bounces-39713-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-39713-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=sifive.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id i9-20020ad45c69000000b006827ae81717si856800qvh.192.2024.01.26.01.02.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 01:02:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-39713-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=PBYHx9+0; arc=pass (i=1 spf=pass spfdomain=sifive.com dkim=pass dkdomain=sifive.com dmarc=pass fromdomain=sifive.com); spf=pass (google.com: domain of linux-kernel+bounces-39713-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-39713-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=sifive.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 5D8F11C25DF1 for ; Fri, 26 Jan 2024 09:02:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 204075BAEB; Fri, 26 Jan 2024 07:41:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="PBYHx9+0" Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D2A55B5D9 for ; Fri, 26 Jan 2024 07:41:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706254869; cv=none; b=fKzZcbaZyj9xiWc1I53rS6Fv7mT1g5F38PawupvmZzkjK/aEpFPudUQ5hAoGm7PkvgjQs7b60mC5P8HxCOFAy+C5LrBM+Tu1GQqtW02rc2BxA9BcsN7EfdGx4bgKvbJoThIGzKAJMiaBUqWa7ORYXU049hjv3Utbep+HD8jjcw8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706254869; c=relaxed/simple; bh=vo1MXNksdwyMhK3dw454VBvsuvuDah4af4HHol3J5x8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hp/2e8z2z8s0YxvCCfRGs+1JEt2V/TsdXaW+rayM2g7tbieW0ctRlY+EAIXXdyhq/YwEycYKph8IIJIfDa5FQ1syYUrQ41pqUHOKM2rc/Z/NDoYSVMgSHUnGFCE+yNURK45d+DvWXf2Sz6xer/mXBKsMLdnRce56oH/81zhImU8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=PBYHx9+0; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1d746ce7d13so1974165ad.0 for ; Thu, 25 Jan 2024 23:41:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1706254867; x=1706859667; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rRcRbgsRNptjKbWJltVNRyiCjNqQwGUOGyfVxx0zgtk=; b=PBYHx9+0/55m2Z44xvjsuoTHelDTExKLAA2Oq0dMg6mQREarCqjIBwnf5nOJ99o5+O iENWScyvdDVSD2oXzlfAG9GWxZljP5oCaDFY5uy1fSQdhtuMs2pW2JR0yn4ZF6CUiu4U 5PTVX+jSIsV6U77ExIBKp59BrZg4llrpZqiLI408iRg18snKDMXZTT78r1rwrdjg3zp5 X/WD/A8/HWof8SFO23ybBqh0JM54/V9yFGIyFkVmM8STUt5DZVCJvFfyD3RJQE/cGJ14 aZ4N9sRAxvS2wF7QMPSxmtSxgub61xTFrbubDQkL06F7FEksTxITsIpGt8spYNRRrXNv svYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706254867; x=1706859667; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rRcRbgsRNptjKbWJltVNRyiCjNqQwGUOGyfVxx0zgtk=; b=jLeqy0O0b7fVr5XOd/eZSX0TI+pl115Df1ZWOaYHRQz1eHEjFoie/Pfha56sasTN5q aT9EgI3Q/9Ik0Y2k4csd7ZbxW2q4iG27CbZWWYUqBKViIgFriEAZ5Vaym43LOnOkZdW4 OJY7qSH8X1HEvN/kBwz9Jvt82Rg6uGtJ9qF2VnE0uzSHCA8P5AR9Fq7yDBWy4gS5NZ9Y Ph2fe7NiXr/CxnN0RxG7R9L2DkNiAcrjXp9PlAnxU9JMJ/eii9Najb1L2xXDcXzYlf4K hv4b2rVy7hXh1KlH6ZYk3oJZ0mTZgdlRqjeA4iStN0Uow2JAAE6qGZfMYYXmHtOwcjlr 5FSg== X-Gm-Message-State: AOJu0YzYasQ252salLakVimZsSU4rE9qpUjiv1PNdJE/BEk+EnMCVGIh xl0pxtOC7upVw66sA1OswBjvQ6FMnODFEC3XgvrWk0sCfOR2Y23xyOR95pg7b+Q= X-Received: by 2002:a17:902:7805:b0:1d7:6f15:7869 with SMTP id p5-20020a170902780500b001d76f157869mr1063575pll.73.1706254866785; Thu, 25 Jan 2024 23:41:06 -0800 (PST) Received: from hsinchu15.internal.sifive.com (59-124-168-89.hinet-ip.hinet.net. [59.124.168.89]) by smtp.gmail.com with ESMTPSA id n3-20020a170902e54300b001d4816958c2sm521066plf.166.2024.01.25.23.41.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 23:41:06 -0800 (PST) From: Nylon Chen To: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, conor@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, palmer@dabbelt.com, paul.walmsley@sifive.com, aou@eecs.berkeley.edu, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de Cc: vincent.chen@sifive.com, zong.li@sifive.com, nylon.chen@sifive.com, nylon7717@gmail.com Subject: [PATCH v8 3/3] pwm: sifive: Fix the error in the idempotent test within the pwm_apply_state_debug function Date: Fri, 26 Jan 2024 15:40:45 +0800 Message-ID: <20240126074045.20159-4-nylon.chen@sifive.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20240126074045.20159-1-nylon.chen@sifive.com> References: <20240126074045.20159-1-nylon.chen@sifive.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789143054070176663 X-GMAIL-MSGID: 1789143054070176663 Round the result to the nearest whole number. This ensures that real_period is always a reasonable integer that is not lower than the actual value. e.g. $ echo 110 > /sys/devices/platform/led-controller-1/leds/d12/brightness $ .apply is not idempotent (ena=1 pol=0 1739692/4032985) -> (ena=1 pol=0 1739630/4032985) Co-developed-by: Zong Li Signed-off-by: Zong Li Signed-off-by: Nylon Chen --- drivers/pwm/pwm-sifive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c index b07c8598bb21..7cf7a76cdb44 100644 --- a/drivers/pwm/pwm-sifive.c +++ b/drivers/pwm/pwm-sifive.c @@ -101,7 +101,7 @@ static void pwm_sifive_update_clock(struct pwm_sifive_ddata *ddata, /* As scale <= 15 the shift operation cannot overflow. */ num = (unsigned long long)NSEC_PER_SEC << (PWM_SIFIVE_CMPWIDTH + scale); - ddata->real_period = div64_ul(num, rate); + ddata->real_period = DIV_ROUND_UP_ULL(num, rate); dev_dbg(ddata->chip.dev, "New real_period = %u ns\n", ddata->real_period); }