[v5,3/6] dt-bindings: serial: add binding for rs485 rx-enable state when rs485 is disabled
| Message ID | 20240126-dev-rx-enable-v5-3-5d934eda05ca@theobroma-systems.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel+bounces-40433-ouuuleilei=gmail.com@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a05:7301:2395:b0:106:343:edcb with SMTP id gw21csp27497dyb;
Fri, 26 Jan 2024 09:30:02 -0800 (PST)
X-Google-Smtp-Source:
AGHT+IGXo75RcTE4RJ9OQEaqPu785ZF+mECuHdaumNaHWECgfi7pf4blhWu2mtbtStnc9lGjD6gt
X-Received: by 2002:a17:90a:de14:b0:290:e59c:aeb6 with SMTP id
m20-20020a17090ade1400b00290e59caeb6mr189299pjv.74.1706290202017;
Fri, 26 Jan 2024 09:30:02 -0800 (PST)
Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org.
[2604:1380:45e3:2400::1])
by mx.google.com with ESMTPS id
p10-20020a17090b010a00b0028caafee648si1447760pjz.77.2024.01.26.09.30.01
for <ouuuleilei@gmail.com>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 26 Jan 2024 09:30:02 -0800 (PST)
Received-SPF: pass (google.com: domain of
linux-kernel+bounces-40433-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Authentication-Results: mx.google.com;
dkim=pass header.i=@theobroma-systems.com header.s=selector1
header.b=LXXSImBb;
arc=fail (signature failed);
spf=pass (google.com: domain of
linux-kernel+bounces-40433-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:45e3:2400::1 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-40433-ouuuleilei=gmail.com@vger.kernel.org";
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=theobroma-systems.com
Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org
[52.25.139.140])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by sv.mirrors.kernel.org (Postfix) with ESMTPS id C8CBD282065
for <ouuuleilei@gmail.com>; Fri, 26 Jan 2024 17:30:01 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
by smtp.subspace.kernel.org (Postfix) with ESMTP id 557A721358;
Fri, 26 Jan 2024 17:28:50 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (2048-bit key) header.d=theobroma-systems.com
header.i=@theobroma-systems.com header.b="LXXSImBb"
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
(mail-he1eur04on2054.outbound.protection.outlook.com [40.107.7.54])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F48B208C0;
Fri, 26 Jan 2024 17:28:44 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
arc=fail smtp.client-ip=40.107.7.54
ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
t=1706290126; cv=fail;
b=lKBm9LfochdCRVVD59GupFr5uej791Zt4G0QYew7jP1ZFu+v4o7FWg8q9R3RSYcREx0vf4FokCu9CYSa1UsI6mmmeVDSSVo0j5L/JDowLHkmlxJBB29c96rfmAP2hWfW5ljToD7TCUDib8qhhL7YJYGCjDWLUKuHiUnIs/BympY=
ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org;
s=arc-20240116; t=1706290126; c=relaxed/simple;
bh=bU8QzIIAEmLwIHySXLaVymY4yS06nq9pd0KTDM18h3M=;
h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To:
To:Cc:MIME-Version;
b=nh98flohODleQrVgqFa2ck6iWfhr9fF9yCCA+DlvRUhFJpRqlKOCgX3/Z6WFkz0FFKPgvFzdGpX3IIzBATc9PwXpGZOSVsu3WbujhI+55eNqtkG0zkCSk9FTptKISp8/ZG5eFmPdS+upmmgv/c5wSaTFa2ER7Ca+tNF4Vz499sU=
ARC-Authentication-Results: i=2; smtp.subspace.kernel.org;
dmarc=pass (p=quarantine dis=none) header.from=theobroma-systems.com;
spf=pass smtp.mailfrom=theobroma-systems.com;
dkim=pass (2048-bit key) header.d=theobroma-systems.com
header.i=@theobroma-systems.com header.b=LXXSImBb;
arc=fail smtp.client-ip=40.107.7.54
Authentication-Results: smtp.subspace.kernel.org;
dmarc=pass (p=quarantine dis=none) header.from=theobroma-systems.com
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=theobroma-systems.com
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=O/XWUTVnGXM8fkCyYKfMx3EI0DXgTnt0indLa3kHSZCpsSiOW6oA+gY9aOvTt3uABrq1/yjPEELXWjgJfW2Db5fh9rE6KHM6BDS3/mFmC258iGXWJJRECtiFMQCTYi9R2TX5/XQHFeSEpFGvsCzfVjNo+SYnwI1PRS7wTH6P2vfe6xAgYhl4Q8epmmbOWeYxeRMEoAmpL01a/bC55Z2XvgchtOe6ThQskLaciFXJalZS+RwlU8Z4PgLSx1APecfihzDegg5rYq4cIcvfQRRJQDC9dBMzL2VMcJ/wlka1kqTHAGPz/QbSYz3Y+gSCrg4q8d4KfeA86FWckGEFty0QOA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=Wb46A5LLYS4lPodtjzqkEpywdweV2Ij7mTZrNtpcHr8=;
b=Q4JhFCNOzH0egUqrOZG+xJqmD6XqW13DMyfMeb0QDDgowgKPLmePMjMFTssOhMW1WZ/pa+FF0tza2hqiDWOx7jO0gtWZg2jHgpdGGHPWiAJHtBGTR08SRTk+M/CeaIOrHRotcee9qqPAIw6xoF+9YbBfPyMGqHn6YdRf4QMuRrAl00AS/XO6sOyNPiYJMDLVsDl/Ips40zKrT7MG86LKmm6HmeMuJwhE1buzuQeByDzew237gt7brhCft2PsyGuqG51wcV1T9+DP27RZZt5h19RcbP4hVj3KFfLquZ5gp4B/oS5H8/sI/MTHY1XJlXGPiXkktLTPaut7kffmoiiZSw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=theobroma-systems.com; dmarc=pass action=none
header.from=theobroma-systems.com; dkim=pass header.d=theobroma-systems.com;
arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=theobroma-systems.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=Wb46A5LLYS4lPodtjzqkEpywdweV2Ij7mTZrNtpcHr8=;
b=LXXSImBbBh3Rl+kbiyZr4VbxpAIwgJCN+uXKjzLTuLJNIeh/Ri3F+QTK02UKzphvOTU8S8u5s+vThDBgQ6is7UqvBbAKHgIlOKEJMT0DG2A4ZpJ74bkygJOnfnPZDQ1UOfwb4pLo/bcwNNuVFQDci3wm+fLTUxaJAJ3Qz0wDIgST7idzOcSr6nNuIRpYaBMnP67/wtpJXnhd37WH41V2jioGiPbhgpE0KGGrt43IQ0CJDZZugR4KqWF5BSi4q5rdcfGQxIfIu6jAmdHDyccKrkN83qAmGQgxEV7Af90DM6nnB9CaHv6J/hlkHmz/PrATNN9GsFcRUAKHiRMqp0e7Kw==
Authentication-Results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=theobroma-systems.com;
Received: from VE1PR04MB6382.eurprd04.prod.outlook.com (2603:10a6:803:122::31)
by DB9PR04MB9820.eurprd04.prod.outlook.com (2603:10a6:10:4c3::10) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.26; Fri, 26 Jan
2024 17:28:36 +0000
Received: from VE1PR04MB6382.eurprd04.prod.outlook.com
([fe80::d4b1:cea8:7085:ec50]) by VE1PR04MB6382.eurprd04.prod.outlook.com
([fe80::d4b1:cea8:7085:ec50%4]) with mapi id 15.20.7228.027; Fri, 26 Jan 2024
17:28:36 +0000
From: Farouk Bouabid <farouk.bouabid@theobroma-systems.com>
Date: Fri, 26 Jan 2024 18:27:44 +0100
Subject: [PATCH v5 3/6] dt-bindings: serial: add binding for rs485
rx-enable state when rs485 is disabled
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20240126-dev-rx-enable-v5-3-5d934eda05ca@theobroma-systems.com>
References: <20240126-dev-rx-enable-v5-0-5d934eda05ca@theobroma-systems.com>
In-Reply-To: <20240126-dev-rx-enable-v5-0-5d934eda05ca@theobroma-systems.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Heiko Stuebner <heiko@sntech.de>
Cc: Rob Herring <robh@kernel.org>, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org,
quentin.schulz@theobroma-systems.com,
Farouk Bouabid <farouk.bouabid@theobroma-systems.com>
X-Mailer: b4 0.12.3
X-ClientProxiedBy: VE1PR03CA0003.eurprd03.prod.outlook.com
(2603:10a6:802:a0::15) To VE1PR04MB6382.eurprd04.prod.outlook.com
(2603:10a6:803:122::31)
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6382:EE_|DB9PR04MB9820:EE_
X-MS-Office365-Filtering-Correlation-Id: b466c037-1544-4b2c-fb7f-08dc1e9439ee
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
P0isZ+qFcu1OXMAuorUI6IbCuDe7YsNZQQqGx+wzcLJcggDWwqLvFBJpMh41fenSz8nFdNrE94kcNFasCpIL+mxGVomi//1ZuYnObenKWfP0Wq5AmUY3DykEs2W4aha/4CPFg60RvXsUeQkz5cMyFypRSOp3DkK0h6ImfiEuYacyw+yp6pY94NbFqJSD8lhsIp9mdA7Cq3u26BSBgrqZj5sjdQzEsjdRKQheTmB5faoBHtk2PJIySlNudpScikS/QFOmQ0RHNMhx4v9tzxJHmr93I6b9Cyf/LZnk6+2LG8M6SYEc8WwgqFcyye8uPNdKk0UQszS6HpmeKoTzNrRm8/UJ02WOnzvU+2zY4DASHIOvb7fHKSWt6sx6MoZQOp5Da+41JAS+BoaRjQ+6XsqO5x1Do7WxmjTqO8vzGa4jKkR2528BSWFJVpDWhZTMIYp+DzsTNHvh/99kVEh7nNbJRPiBOpBb1wRqxZFMVd8nqqjNkbfWetY2ThQdkdmYsI7F4CBXlkjph6O5rz2FTOp0IkFiJ/vuldEDZbBSOgU9HYCOF88sGhOnv+Vdt0zzJRY8QUMxm4jB3tyN/bEMlmc9VpaeppjVIbKKwTThb0axwLI6awFxe+0AYZEyxc3UDRUD
X-Forefront-Antispam-Report:
CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6382.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(39850400004)(136003)(376002)(366004)(396003)(230922051799003)(64100799003)(186009)(1800799012)(451199024)(36756003)(478600001)(8676002)(4326008)(7416002)(8936002)(66556008)(54906003)(5660300002)(6486002)(44832011)(66476007)(316002)(2906002)(110136005)(66946007)(86362001)(6666004)(38350700005)(52116002)(6512007)(38100700002)(83380400001)(6506007)(2616005)(41300700001)(26005)(107886003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?VlEft33cfsEb/ZW3W7B9pN5YdfgT?=
=?utf-8?q?Z9SVmuDL8wUOA6yOKLoBhIHoc1464abcJZMD2WIWIe77Ixs3o6ugeCdcMU87xHBM6?=
=?utf-8?q?l8i0t6sKHhPZ3PKatk7ix9iJPSs+F7LtR1cbuUCArjs+oz+54XdddYuGzcy/RGqjO?=
=?utf-8?q?z5e32S7AD/18a9xoBP2XldoMNql9d890hb02hSzuBGYczZg0isJlDOjgjs8hfFV6t?=
=?utf-8?q?VJ5QTefIgfXgAh8nR59mDYyS/rsvkt5wrY3k3WeAXZHLouSxDDCDxd8UZXRMxWvQX?=
=?utf-8?q?YPf6xYpLnjT0gXG1kzaD5pYjKZP9m6/PEUDoa6FHIe81CU9Erv2tCw0o0x6w/sCRJ?=
=?utf-8?q?0DufGUEOp2ow7Ycj4LRO+SUlJaYi+bXq8dstoCYjKFv6cK2K5mTHKPzCAiYTjep0I?=
=?utf-8?q?ABlP9NA1Uqup1w8ljEzUJMDQzJ/IAd4i39pDgiVo+9ciBlet42lkHZ3b/7tEwBi8u?=
=?utf-8?q?s6cavXJ2/+3fS4piQzPwh+WCB/mTXz1f+enStKOPuLDLfa2NV+EwcazJOpN8NGRCU?=
=?utf-8?q?5CT69y6Jjll2G+f45+vbU644EJ5HUdl05znGbDMQV0Yr6CUBMiua6PNm1S9HRX+hB?=
=?utf-8?q?+bRff4atx8Xfaj5bbUka5iux3FsRTe0uPoKJdVpybbGZ4eyVv9NsGy6imqhOv9G9A?=
=?utf-8?q?jgki/2I8AwMS0+LGITrMp6Issvhxz8HpKYnhLkld0bj+BwG8sr2dhLvE5IVPTSxAF?=
=?utf-8?q?L/57DlBIEHb5rXSuUFDD+2aTmtqcV+/1XioTVkNDgfO4WuD4mj3/cdFfw4TD0KKVs?=
=?utf-8?q?ekX73OZKA2yIkBoVnqQujMvBse3D/nbOb4x7ppUqyUYujDHYUE5QYa/n455Z3TJY3?=
=?utf-8?q?k+OOqSYzMIK09VUDv7QQrKuIr/942FRsmYZOMjIS1JcIjlf159T/FjsxRgaZaZRIe?=
=?utf-8?q?QKYw3mfce0aWxNXUpwb45MGIDxhWmLR8A+YIG2IuVHyVG/vSps24n68fY2ELjV5Ds?=
=?utf-8?q?ixNUdxL2xhfLtmHKZSr31kAqTAot4JI9gt0Nky0WA7UzlMy171y11iKRZaFO9NWcT?=
=?utf-8?q?fw7gUf+EpMo+ZbryF+V1+LhkC3qrwD9Be2W+Oes8vBul2s1hcB+f1FWZGOdIQMeQF?=
=?utf-8?q?PpsYS7hK7XEiV72ak11A6YZjhv6UsWaOvfHdH/U0YaI2qATMvyOIK6O7yBFNO6mQP?=
=?utf-8?q?Sa+/+yIBW8Kq9HPQ8CVF748tiSq2N9B9liIx3oTI9/xV1e/x9EzdoiHFdW4O7+lBN?=
=?utf-8?q?61/JakHCEDggW8iqu2pIFIIRTofoWg1SVre4+oBpxsxeWfqWUvm3KTqHO9RXHZqXH?=
=?utf-8?q?tEYNLH3/hq8zvlvkiIa6PkdVyMRMinIOKKK7kRYW6HyFEuoQUud1kn5zq6wHYQrRt?=
=?utf-8?q?uS+CVhwzNpD1d3mAb3cNoxSscNqTY3wVX0JGqEMkJeFljWq8ALrndL23MatmAVk4E?=
=?utf-8?q?ZltUeP2Iw9qwH2tpWPrV5GNG1FmVdcUtKaFMtYqHpNgi97f86LKZcUiE0Kj4pQKgH?=
=?utf-8?q?swO1oMhtRivL6ontBnkjL0jZfeC3XyEWXYUT4rV9QYvqdI2lYoc34CQkuW1ldnzYf?=
=?utf-8?q?EdJPHTf4LvZsz+Up6i7hTsGyy1No19xBgWiVhu04/wd0wokRlV2o59w=3D?=
X-OriginatorOrg: theobroma-systems.com
X-MS-Exchange-CrossTenant-Network-Message-Id:
b466c037-1544-4b2c-fb7f-08dc1e9439ee
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6382.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2024 17:28:35.6552
(UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5e0e1b52-21b5-4e7b-83bb-514ec460677e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName:
gbiBoWmkXLfXnlwJODFn/Dnp7Pi9Jh5rGwkEotyIribKFu9Swr0HAjyfmZxUVUCMi7sP747yZAMs9UHT/tkrT8uSCca+S7m15Lvz6ZwyrxRaSU4z41nDXMUJ8TTWjs6n
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9820
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1789174954941146660
X-GMAIL-MSGID: 1789174954941146660
|
| Series |
serial: 8250: Add support for rs485 half/full duplex on puma/ringneck-haikou
|
|
Commit Message
Farouk Bouabid
Jan. 26, 2024, 5:27 p.m. UTC
RS485 can have a receiver-enable gpio (rx-enable-gpios). When rs485 is
enabled, this gpio, if provided, must be driven active while receiving.
However when RS485 is disabled this gpio should not have an undefined
state. In that case, as DE and RE pins can be connected both to this gpio,
if its state is not properly defined, can cause unexpected transceiver
behavior.
This binding depend on rx-enable-gpios to be implemented.
Signed-off-by: Farouk Bouabid <farouk.bouabid@theobroma-systems.com>
---
Documentation/devicetree/bindings/serial/rs485.yaml | 5 +++++
1 file changed, 5 insertions(+)
Comments
On Fri, Jan 26, 2024 at 06:27:44PM +0100, Farouk Bouabid wrote: > RS485 can have a receiver-enable gpio (rx-enable-gpios). When rs485 is s/gpio/GPIO/ > enabled, this gpio, if provided, must be driven active while receiving. > However when RS485 is disabled this gpio should not have an undefined > state. In that case, as DE and RE pins can be connected both to this gpio, > if its state is not properly defined, can cause unexpected transceiver > behavior. > This binding depend on rx-enable-gpios to be implemented. Sounds like a constraint: dependencies: rs485-rx-enable-inactive-when-rs485-disabled: [ rx-enable-gpios ] > > Signed-off-by: Farouk Bouabid <farouk.bouabid@theobroma-systems.com> > --- > Documentation/devicetree/bindings/serial/rs485.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/serial/rs485.yaml b/Documentation/devicetree/bindings/serial/rs485.yaml > index b64577036b5c..4c79dfaaf460 100644 > --- a/Documentation/devicetree/bindings/serial/rs485.yaml > +++ b/Documentation/devicetree/bindings/serial/rs485.yaml > @@ -55,6 +55,11 @@ properties: > description: GPIO to handle a separate RS485 receive enable signal > maxItems: 1 > > + rs485-rx-enable-inactive-when-rs485-disabled: For something a bit shorter, perhaps: rs485-rx-enable-inactive-on-disable > + description: rx-enable GPIO is not active when RS485 is disabled. If missing, active-state > + is assumed. > + $ref: /schemas/types.yaml#/definitions/flag > + > rs485-term-gpios: > description: GPIO pin to enable RS485 bus termination. > maxItems: 1 > > -- > 2.34.1 >
diff --git a/Documentation/devicetree/bindings/serial/rs485.yaml b/Documentation/devicetree/bindings/serial/rs485.yaml index b64577036b5c..4c79dfaaf460 100644 --- a/Documentation/devicetree/bindings/serial/rs485.yaml +++ b/Documentation/devicetree/bindings/serial/rs485.yaml @@ -55,6 +55,11 @@ properties: description: GPIO to handle a separate RS485 receive enable signal maxItems: 1 + rs485-rx-enable-inactive-when-rs485-disabled: + description: rx-enable GPIO is not active when RS485 is disabled. If missing, active-state + is assumed. + $ref: /schemas/types.yaml#/definitions/flag + rs485-term-gpios: description: GPIO pin to enable RS485 bus termination. maxItems: 1