Message ID | 20240125142907.33015c9f@canb.auug.org.au |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-37924-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2553:b0:103:945f:af90 with SMTP id p19csp1398568dyi; Wed, 24 Jan 2024 19:31:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IE5JuG2L3PKJsJ7ehyddj5XWL1tuhha7qdBN0Ktz5KUxO9rBanKpPp7dzrin9Wckvs52fqn X-Received: by 2002:a17:90a:2dce:b0:28e:7528:3d4c with SMTP id q14-20020a17090a2dce00b0028e75283d4cmr305936pjm.55.1706153506588; Wed, 24 Jan 2024 19:31:46 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706153506; cv=pass; d=google.com; s=arc-20160816; b=VQoj7cw4jA4SsRWGM+VNxTQuRLLBE9Te4YAbJ+tMA/+dpUbiH+Jl+dzQGl2Bfa/paz MNqrVhAvxXE9o7smC4SC0Qu8tWB2YKAq7okMjDNYJsFZaAcHd6Y3YcSPnksbzYAEpBQr Jai5FAFliArCKS/pPA+PBtyBmiLF1sPUD/m9U1b/s8bNFCxp3Zd0wRlSN+UEhFifL3ZZ ueRUVBUL/t03sR++Qf9QASsaChE1qVPYgkdrYpCPI8LqQOS9LPh9JKjDChA9wLtlyzEo ihBQp4Oa+GmJMBKK3MRsxycdXz+Wkh92qXaVToucUXugOf5LokJutRuAsCFHBivR92OU UUYw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:subject:cc:to:from:date:dkim-signature; bh=GHY4swhnXLMFacA3pX4da7TLNe5sUk48QIMV0TOgBiw=; fh=Z4XWI8ZhrvMbyNnpEUllOyv+6m6270uOaYAB+99BS0k=; b=x+ORPQnELhbqgqzONJrHD1VrCC75GmGdtLtzoKEJi2oIBunbM10cIZQ3yaC1Ck18fB OxzmT8IKPvnAE9xt3UW8L/yhZ/tWU5DUax/2VVc1yGybwDrD0Gd13tVPVZQzyJ8dSeES YDBusqcw0rszeom4RgdRJSURq/jtFXd0DblPxhiUVT0E1+EwZDW1NEhjLVuqLsXjowaK x8kd7aDB89AIsXTCBx2bUmO21GpIk7vAAjyRO22y57oqAzmQSoZwEp9HYBrgXKECAyvR MOUJr5WAuIttxuvd+ms2y2zOYwTyyvJWTqgcvu+czxqc4DnXHKDo17l0hPhkqSWVMAU6 BAbA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@canb.auug.org.au header.s=201702 header.b=Xa4V+T8N; arc=pass (i=1 spf=pass spfdomain=canb.auug.org.au dkim=pass dkdomain=canb.auug.org.au dmarc=pass fromdomain=canb.auug.org.au); spf=pass (google.com: domain of linux-kernel+bounces-37924-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-37924-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canb.auug.org.au Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id f5-20020a17090ace0500b002902f53c190si590306pju.57.2024.01.24.19.31.46 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 19:31:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-37924-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@canb.auug.org.au header.s=201702 header.b=Xa4V+T8N; arc=pass (i=1 spf=pass spfdomain=canb.auug.org.au dkim=pass dkdomain=canb.auug.org.au dmarc=pass fromdomain=canb.auug.org.au); spf=pass (google.com: domain of linux-kernel+bounces-37924-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-37924-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canb.auug.org.au Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 316C12849A0 for <ouuuleilei@gmail.com>; Thu, 25 Jan 2024 03:31:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 71B5517732; Thu, 25 Jan 2024 03:29:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=canb.auug.org.au header.i=@canb.auug.org.au header.b="Xa4V+T8N" Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EF8D17593; Thu, 25 Jan 2024 03:29:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=150.107.74.76 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706153354; cv=none; b=J1hqYSR9XUgohJHR6+xhXd7tHZuRRl4dDIIek0sFi/Ioe6+ba7B0O59UPwA+es3srHoDAq2FMtCOvJz7XH1GwANDk9jFrFiEGAe2fhN6YhTaYUjjCArrZBl/UX+2XSCVly6Kt8F266v3xB/ARlhNSWIR2p/gzKamj0lvdFBFT0E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706153354; c=relaxed/simple; bh=0X6rWEK09NHa6BBHCR9XLlM19S/MwmJPDvK/vZWqAwM=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type; b=SKH4xslsfqajPrcTO092bS6Cw0wrXh3eYCEgZYCmXpDPOybDrmlFzamshCClTEmZh5x9ZYmdQ4AmbLUfVpd+ZrEetbfMQjHlaU8WD1TINl4RTgLyuVc/1h7LnB1uStXihFcSNFGZavb7+ZPK+M9IYot6V16wzRg5T87GJqsZPEw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=canb.auug.org.au; spf=pass smtp.mailfrom=canb.auug.org.au; dkim=pass (2048-bit key) header.d=canb.auug.org.au header.i=@canb.auug.org.au header.b=Xa4V+T8N; arc=none smtp.client-ip=150.107.74.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=canb.auug.org.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canb.auug.org.au DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canb.auug.org.au; s=201702; t=1706153349; bh=GHY4swhnXLMFacA3pX4da7TLNe5sUk48QIMV0TOgBiw=; h=Date:From:To:Cc:Subject:From; b=Xa4V+T8NbVpRKFKzBpDs21TVuE9j0m4nySPKuhLFdgGPtOZTLpWz0JuqdEterO0si aXr0tQjKg2URi/awXMg094hoWGzpxCeEUmZLdlrnl/pXnWZ2RhJQFlmFzHnGK7o/8C HEHbmS0FspNnVeRCOmaqyaD5m64NpuUmjHFTgOM7fNeu/IxNg6SeU73ISpuzlC/s5p R1iaPiLxGsy5s/0Uox11+vmQdfgtiryx7zCkICXYT4WDuSa/jmnkl+fDXWAsYwk/dC C8B9G8/ylGyVUyURd/o+OsMHWLxkmSrzLOaiFuWQers1UjJQHNEhMp+YtvbRY7zRuS kYZr0zmPqQS6g== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4TL5sK2Bw4z4wcJ; Thu, 25 Jan 2024 14:29:08 +1100 (AEDT) Date: Thu, 25 Jan 2024 14:29:07 +1100 From: Stephen Rothwell <sfr@canb.auug.org.au> To: Andrew Morton <akpm@linux-foundation.org> Cc: Baoquan He <bhe@redhat.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux Next Mailing List <linux-next@vger.kernel.org> Subject: linux-next: build failure after merge of the mm tree Message-ID: <20240125142907.33015c9f@canb.auug.org.au> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/8NWZy_aWMrBmtL5e3YMQfKX"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789031619045314957 X-GMAIL-MSGID: 1789031619045314957 |
Series |
linux-next: build failure after merge of the mm tree
|
|
Commit Message
Stephen Rothwell
Jan. 25, 2024, 3:29 a.m. UTC
Hi all, After merging the mm tree, today's linux-next build (powerpc allnoconfig) failed like this: WARNING: unmet direct dependencies detected for CRASH_DUMP Depends on [n]: ARCH_SUPPORTS_CRASH_DUMP [=y] && KEXEC_CORE [=n] Selected by [y]: - ARCH_SELECTS_KEXEC [=y] arch/powerpc/kernel/crash_dump.c:101:6: error: redefinition of 'is_kdump_kernel' 101 | bool is_kdump_kernel(void) | ^~~~~~~~~~~~~~~ In file included from arch/powerpc/kernel/crash_dump.c:12: include/linux/crash_dump.h:64:20: note: previous definition of 'is_kdump_kernel' with type 'bool(void)' {aka '_Bool(void)'} 64 | static inline bool is_kdump_kernel(void) | ^~~~~~~~~~~~~~~ kernel/crash_core.c: In function 'kimage_crash_copy_vmcoreinfo': kernel/crash_core.c:43:18: error: invalid use of undefined type 'struct kimage' 43 | if (image->type != KEXEC_TYPE_CRASH) | ^~ kernel/crash_core.c:43:28: error: 'KEXEC_TYPE_CRASH' undeclared (first use in this function); did you mean 'KEXEC_ON_CRASH'? 43 | if (image->type != KEXEC_TYPE_CRASH) | ^~~~~~~~~~~~~~~~ | KEXEC_ON_CRASH kernel/crash_core.c:43:28: note: each undeclared identifier is reported only once for each function it appears in kernel/crash_core.c:55:27: error: implicit declaration of function 'kimage_alloc_control_pages' [-Werror=implicit-function-declaration] 55 | vmcoreinfo_page = kimage_alloc_control_pages(image, 0); | ^~~~~~~~~~~~~~~~~~~~~~~~~~ kernel/crash_core.c:55:25: warning: assignment to 'struct page *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 55 | vmcoreinfo_page = kimage_alloc_control_pages(image, 0); | ^ kernel/crash_core.c:66:14: error: invalid use of undefined type 'struct kimage' 66 | image->vmcoreinfo_data_copy = safecopy; | ^~ kernel/crash_core.c: At top level: kernel/crash_core.c:74:5: error: redefinition of 'kexec_should_crash' 74 | int kexec_should_crash(struct task_struct *p) | ^~~~~~~~~~~~~~~~~~ In file included from kernel/crash_core.c:12: include/linux/kexec.h:474:19: note: previous definition of 'kexec_should_crash' with type 'int(struct task_struct *)' 474 | static inline int kexec_should_crash(struct task_struct *p) { return 0; } | ^~~~~~~~~~~~~~~~~~ kernel/crash_core.c:92:5: error: redefinition of 'kexec_crash_loaded' 92 | int kexec_crash_loaded(void) | ^~~~~~~~~~~~~~~~~~ include/linux/kexec.h:475:19: note: previous definition of 'kexec_crash_loaded' with type 'int(void)' 475 | static inline int kexec_crash_loaded(void) { return 0; } | ^~~~~~~~~~~~~~~~~~ kernel/crash_core.c: In function 'kexec_crash_loaded': kernel/crash_core.c:94:18: error: 'kexec_crash_image' undeclared (first use in this function); did you mean 'kexec_crash_loaded'? 94 | return !!kexec_crash_image; | ^~~~~~~~~~~~~~~~~ | kexec_crash_loaded kernel/crash_core.c: At top level: kernel/crash_core.c:103:16: error: redefinition of '__crash_kexec' 103 | void __noclone __crash_kexec(struct pt_regs *regs) | ^~~~~~~~~~~~~ include/linux/kexec.h:472:20: note: previous definition of '__crash_kexec' with type 'void(struct pt_regs *)' 472 | static inline void __crash_kexec(struct pt_regs *regs) { } | ^~~~~~~~~~~~~ kernel/crash_core.c: In function '__crash_kexec': kernel/crash_core.c:114:21: error: 'kexec_crash_image' undeclared (first use in this function); did you mean 'kexec_crash_loaded'? 114 | if (kexec_crash_image) { | ^~~~~~~~~~~~~~~~~ | kexec_crash_loaded kernel/crash_core.c:117:25: error: implicit declaration of function 'crash_setup_regs' [-Werror=implicit-function-declaration] 117 | crash_setup_regs(&fixed_regs, regs); | ^~~~~~~~~~~~~~~~ kernel/crash_core.c:120:25: error: implicit declaration of function 'machine_kexec' [-Werror=implicit-function-declaration] 120 | machine_kexec(kexec_crash_image); | ^~~~~~~~~~~~~ kernel/crash_core.c: At top level: kernel/crash_core.c:128:1: warning: ignoring attribute 'noinline' because it conflicts with attribute 'gnu_inline' [-Wattributes] 128 | { | ^ include/linux/kexec.h:473:20: note: previous declaration here 473 | static inline void crash_kexec(struct pt_regs *regs) { } | ^~~~~~~~~~~ kernel/crash_core.c:127:18: error: redefinition of 'crash_kexec' 127 | __bpf_kfunc void crash_kexec(struct pt_regs *regs) | ^~~~~~~~~~~ include/linux/kexec.h:473:20: note: previous definition of 'crash_kexec' with type 'void(struct pt_regs *)' 473 | static inline void crash_kexec(struct pt_regs *regs) { } | ^~~~~~~~~~~ kernel/crash_core.c: In function '__crash_shrink_memory': kernel/crash_core.c:356:9: error: implicit declaration of function 'crash_free_reserved_phys_range' [-Werror=implicit-function-declaration] 356 | crash_free_reserved_phys_range(ram_res->start, ram_res->end); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ kernel/crash_core.c: In function 'crash_shrink_memory': kernel/crash_core.c:370:13: error: 'kexec_crash_image' undeclared (first use in this function); did you mean 'kexec_crash_loaded'? 370 | if (kexec_crash_image) { | ^~~~~~~~~~~~~~~~~ | kexec_crash_loaded In file included from include/linux/kernel.h:27, from arch/powerpc/include/asm/page.h:11, from arch/powerpc/include/asm/thread_info.h:13, from include/linux/thread_info.h:60, from arch/powerpc/include/asm/processor.h:41, from include/linux/sched.h:13, from include/linux/utsname.h:6, from kernel/crash_core.c:9: kernel/crash_core.c:377:38: error: 'KEXEC_CRASH_MEM_ALIGN' undeclared (first use in this function) 377 | new_size = roundup(new_size, KEXEC_CRASH_MEM_ALIGN); | ^~~~~~~~~~~~~~~~~~~~~ include/linux/math.h:61:16: note: in definition of macro 'roundup' 61 | typeof(y) __y = y; \ | ^ kernel/crash_core.c: In function 'crash_save_cpu': kernel/crash_core.c:437:36: error: 'KEXEC_CORE_NOTE_NAME' undeclared (first use in this function); did you mean 'CRASH_CORE_NOTE_NAME'? 437 | buf = append_elf_note(buf, KEXEC_CORE_NOTE_NAME, NT_PRSTATUS, | ^~~~~~~~~~~~~~~~~~~~ | CRASH_CORE_NOTE_NAME kernel/crash_core.c: In function 'kexec_crash_loaded': kernel/crash_core.c:95:1: error: control reaches end of non-void function [-Werror=return-type] 95 | } | ^ cc1: some warnings being treated as errors Caused by commit 9dc830523e4e ("ppc, crash: enforce KEXEC and KEXEC_FILE to select CRASH_DUMP") I have applied the following patch: From: Stephen Rothwell <sfr@canb.auug.org.au> Date: Thu, 25 Jan 2024 14:20:51 +1100 Subject: [PATCH] fix up for "ppc, crash: enforce KEXEC and KEXEC_FILE to select CRASH_DUMP" Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> --- arch/powerpc/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 31f013e636e3..e7707bebc061 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -610,6 +610,8 @@ config ARCH_SUPPORTS_KEXEC config ARCH_SELECTS_KEXEC def_bool y + depends on ARCH_SUPPORTS_CRASH_DUMP + depends on KEXEC_CORE select CRASH_DUMP config ARCH_SUPPORTS_KEXEC_FILE