diff mbox series

[06/15] tick: No need to clear ts->next_tick again

Message ID 20240124170459.24850-7-frederic@kernel.org
State New
Headers
Series timers/nohz cleanups and hotplug reorganization |

Commit Message

Frederic Weisbecker Jan. 24, 2024, 5:04 p.m. UTC 
  The tick sched structure is already cleared from
tick_cancel_sched_timer(), so there is no need to clear that field
again.

Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
---
 kernel/time/tick-sched.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Thomas Gleixner Jan. 25, 2024, 9:33 a.m. UTC | #1 
On Wed, Jan 24 2024 at 18:04, Frederic Weisbecker wrote:

> The tick sched structure is already cleared from
> tick_cancel_sched_timer(), so there is no need to clear that field
> again.
>
> Signed-off-by: Frederic Weisbecker <frederic@kernel.org>

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
diff mbox series

Patch

diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index 4089bd274d8e..e8e3b5d447e9 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -1101,11 +1101,6 @@  static bool can_stop_idle_tick(int cpu, struct tick_sched *ts)
 	if (unlikely(!cpu_online(cpu))) {
 		if (cpu == tick_do_timer_cpu)
 			tick_do_timer_cpu = TICK_DO_TIMER_NONE;
-		/*
-		 * Make sure the CPU doesn't get fooled by obsolete tick
-		 * deadline if it comes back online later.
-		 */
-		ts->next_tick = 0;
 		return false;
 	}