From patchwork Wed Jan 24 14:45:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chao Yu X-Patchwork-Id: 191601 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2553:b0:103:945f:af90 with SMTP id p19csp1038977dyi; Wed, 24 Jan 2024 06:54:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IH7AhYFYFd0wz6MfZGk5TmUX3C12LzIqwczCpf5TPNmJrJza3baEE23+2di32a/rYQI2PUn X-Received: by 2002:a05:6512:3f13:b0:50e:8ead:3889 with SMTP id y19-20020a0565123f1300b0050e8ead3889mr4037372lfa.75.1706108072468; Wed, 24 Jan 2024 06:54:32 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706108072; cv=pass; d=google.com; s=arc-20160816; b=owFxjTPlk7LHN31NOMAJbMUWITQbfXluvhPw4SD/RwSi6wdb9da9y5Y1dNECkk9Gqc AcAPc34+woraSngAN0i0OXM3A9456MtMapSWJnwmS+r2AbFJKA0uA7rpsbeJQmiUBXob BRhZXGN5/vdmS1r5blEOXotUbIYsl7vkKS07QpvXLsENTD8pjz0XMaGx5kMIE6Ce7Pi8 uyU2tPXXsgpNoYLldnYnxXedVGp6+jirJtjsJoTZrh1joZfBnE7q9L7arBZyLxIe6yBr 1EXZT/Iallj6cg+GNWqmaDV9CjBi+Soo1R6ltJrgeNhT/cvQzo8KPz6/kVClRNVuTtny XHSQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=nsEXfTgUZdb7O/1sIzQN1ud74814hofAGDkAZxkm5U8=; fh=X1/oBJvTGJUQ0YtRp03u+3tPfRw/dXXALWynfOSlfQQ=; b=J86VW0lVAXiNy5m3LxvLahNE+h+nuCDPHr2lFeGoXOjmUzHnm2mH/gcFPDsbVmsALh 6wljjhdWevVM5VOnrx3hos+rV8MzAM2e2hR7BCwZoGpkIpVtrkOZ71CI97tH4tnzPWYg cyQsyPit1JuV0/MHh9nzrH9TYd07YGC68ooVTeHaUhnFHbR/f/sOQMIbWk5E6tTXp3X/ stg9vvM0XADtYXG7/R0eLokW695EbMFZw8e5x8d4Qy5yvlhWl6bslPO86JbeWQmqs9Ky 0+rlkWN/q0RphZmf2607sKJPkLsIz8l0BjsdDUOd6zyQBAHbqz0mxAXTOMcAb6ov9jPM vk4Q== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JqkQ1rzS; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-37200-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-37200-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id l13-20020a17090612cd00b00a26ac591e55si13016106ejb.129.2024.01.24.06.54.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 06:54:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-37200-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JqkQ1rzS; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-37200-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-37200-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 148E21F21BBE for ; Wed, 24 Jan 2024 14:54:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0D15A1292C0; Wed, 24 Jan 2024 14:45:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JqkQ1rzS" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73AE2128376 for ; Wed, 24 Jan 2024 14:45:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706107512; cv=none; b=RRXKqcwwkyprnnGgPyNGD1wnghsQggAxtmaYLMP7zPjwylsGbQBr0K55ynIEKR14GULSTT6cP9m3ccRTn91JhX9W749NZlO5ZP3UI/+bI90UmZROkKb7jw5xwn7jVYUg/0IOdwzkSMaX22MC0iSWIm6cYOFYN4159O+Uc81DuFo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706107512; c=relaxed/simple; bh=GmaYoIhCc4vPw5Lo1/sPZc2Sy8eWLhDLcOKDvMVTJ2w=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=cUc6ogT8D9sNCvExoMaTohVM2bDWsotGk5YjzjTSz9qRsqeoifjoHqEpGsML8SxGGb8fEAn1X1cZmr0Hhl96NwkpWF506Jwo3bXGPXZhD8BAweSJq5fiBxxupqWH9LQjxSdJ7/GuMLDL7Pchz1i04A09mm6bM3iW3iFBcLc71ZQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JqkQ1rzS; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95B78C43399; Wed, 24 Jan 2024 14:45:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706107512; bh=GmaYoIhCc4vPw5Lo1/sPZc2Sy8eWLhDLcOKDvMVTJ2w=; h=From:To:Cc:Subject:Date:From; b=JqkQ1rzSk81G/5oXUF5vcMSH2UZHazJHBuWisp7JuQJHVG2oIqbzkFhkn0rXELxgQ G5R2uXqeV+zN1N3MbpQSqsOz423fo50SAHbHP+2ItzD+9au1VGqrk1k75NPAJTT5W6 a5dtFwkf8kHu8bKIMmoVrmyPeAFAVOL8jRwfiSy59udfUX15cAKoa66i9Yubaj/seC pqwSXow7WXuXHh7C2c8AaJCjpEyyuX9C4aZ5OnW5G8IQzKK6ZGnd+8TOzeomNgKUhB FXN8ufRsme/VIWKSsFeAjINnzFaji1xRpNpvBZkHhJFNtc3Jkqd1zfVP2Xer3tFtHc ViUBKDhj5lm/w== From: Chao Yu To: jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu Subject: [PATCH] f2fs: use printk_ratelimited to avoid redundant logs Date: Wed, 24 Jan 2024 22:45:06 +0800 Message-Id: <20240124144506.15052-1-chao@kernel.org> X-Mailer: git-send-email 2.40.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788983977803072324 X-GMAIL-MSGID: 1788983977803072324 Use printk_ratelimited() instead of f2fs_err() in f2fs_record_stop_reason(), and f2fs_record_errors() to avoid redundant logs. Signed-off-by: Chao Yu --- fs/f2fs/super.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index e2c066fbc0fa..7e437aea268e 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -4091,7 +4091,9 @@ static void f2fs_record_stop_reason(struct f2fs_sb_info *sbi) f2fs_up_write(&sbi->sb_lock); if (err) - f2fs_err(sbi, "f2fs_commit_super fails to record err:%d", err); + printk_ratelimited( + "%sF2FS-fs (%s): f2fs_commit_super fails to record stop_reason, err:%d\n", + KERN_ERR, sbi->sb->s_id, err); } void f2fs_save_errors(struct f2fs_sb_info *sbi, unsigned char flag) @@ -4134,8 +4136,9 @@ static void f2fs_record_errors(struct f2fs_sb_info *sbi, unsigned char error) err = f2fs_commit_super(sbi, false); if (err) - f2fs_err(sbi, "f2fs_commit_super fails to record errors:%u, err:%d", - error, err); + printk_ratelimited( + "%sF2FS-fs (%s): f2fs_commit_super fails to record errors:%u, err:%d\n", + KERN_ERR, sbi->sb->s_id, error, err); out_unlock: f2fs_up_write(&sbi->sb_lock); }