[07/14] phy: qcom: qmp-pcie: Add a comment to clarify the use of "aux and "phy_aux" clocks
Message ID | 20240124-pcie-aux-clk-fix-v1-7-d8a4852b6ba6@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-36561-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2553:b0:103:945f:af90 with SMTP id p19csp831754dyi; Tue, 23 Jan 2024 23:39:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IF4TJp8CoR4JLGdK7f527FVfB/inhtlEUQ5laWfPoqeroI6vq8x84OIOGKYpoGHwkfbLKMg X-Received: by 2002:a05:6358:9494:b0:175:9b4d:5d82 with SMTP id i20-20020a056358949400b001759b4d5d82mr5635307rwb.51.1706081971064; Tue, 23 Jan 2024 23:39:31 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706081971; cv=pass; d=google.com; s=arc-20160816; b=GM3qbiyMkF2B56aToMU5Ptrn1o+2vqDwhNU10vsFlPdSnQoay9nGkV00c4rn4VOF+4 PMNQkSK6hX6Gqkashn2vfTPBC+2Q9OxXeioCZllcSfFceUeSSuf/Ft1/bPD+TK/27KLx iDhlhYmwuhtn0gMGyZEvQNm/qdziTMl5O3CzsSuRVVWOi6qKrXGdzxJRENzeELR0CuaN N1tsoH5ksCDQtAC5MgEE1gXzOFVKHRYOxfbAkOHobzS6U2SkjLBfWgzcmCpxZrAFVaUu rkcLhFqWroS38qdTGeofAniWrO7bIn3DO66nppC3cYc4EY885wH2Ru/aflx8djS+Nvil /Z9Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=oJnupBgFvOzDewfsN2fbqfoXAijS1cIjpRbgOobXJnE=; fh=URzuBkYDgttHqT4caDiYqlUau8FxKJHkC8IVArcgaN4=; b=G5lWAEn2V/c9dvuCHlbOwI9po5FpXvAq+c1bCL9T0Un0xdXkBVjadP3FzcG1+7Z4N8 j0e5DgA1nM/6OoZzac+iU2N7Uk4iAfbdTd2RouOtEZRPqCurojfEa0SbkFsh1gX9XDwI LL+iqHa0Eaa4O/OxFYAWkSmQd0X4Pi30U2Z1yFEG340ORuqHfuPHWuPJ5tlx7rAHI/wG 8XjsGPtwMZj7JL8R8uySW7J/3KygZVllup/w6Jq1KheMXyvcabeP1++ZBsLyApA7+E3F nJ3Bgi2dWtR+sotjH73aBjIyafOnkTCYleO90ZGaSfbmJAv+ovTSrzqvYRErDt2+fE3B Ik9g== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Ef25jQVK; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-36561-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-36561-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id i8-20020a63cd08000000b005ceb5338d74si11307990pgg.510.2024.01.23.23.39.30 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 23:39:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-36561-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Ef25jQVK; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-36561-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-36561-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B603E28391F for <ouuuleilei@gmail.com>; Wed, 24 Jan 2024 07:39:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0FAA117BB6; Wed, 24 Jan 2024 07:37:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ef25jQVK" Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E031817BA4 for <linux-kernel@vger.kernel.org>; Wed, 24 Jan 2024 07:37:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706081842; cv=none; b=UoHx/U05m07tN0xyrX5OHVR3fBoCF9ZtI2PJXVs1A/YTfFRRNjILcPCJkIKfR+1qZBNtZY95grJT6mfFBisGuouh7zArnh+jJ3RPLbCVjE5qHJCAcWqlEO6/UtrKFONPiGEaoH2/1jxvUpUlCDHIugONY6uyEHIxzMtqEWhC1Ao= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706081842; c=relaxed/simple; bh=SMDJRGbt8Jv9ABIlOfDcm2JYxpzZQjqrX46K5L5t/xk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jiBlBEp9N/4xqws27mqDPXX4cbWGKGska9MdQZSQDPnFXdnMG33a9kCTRlvja5s+cb5FW+U2yeHPafz2vpFMKlc5RAp6wmDR4BGwkkkqY35SjjmDLYqpVUbO+cSs/6sCgVrbRvjyUcfyxMpcUtVpLc4UkmhqO9Mlx+zIcLsLCjE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Ef25jQVK; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1d70a98c189so30092665ad.1 for <linux-kernel@vger.kernel.org>; Tue, 23 Jan 2024 23:37:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706081840; x=1706686640; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=oJnupBgFvOzDewfsN2fbqfoXAijS1cIjpRbgOobXJnE=; b=Ef25jQVKTs1NV/SOt3b1Ov7l22+0+Ki1oZFBXxKof/9+dEMvwJQJXm6XU5eOJf0vLE RTB61OVOwkfN4eG/ktcOAnLrNy73mnDK7trot6OCUdXdt4TD9nz6pQlldiyiDpll1JGb BBT0LW9i64GfwjazODgWYloNVr6ASjXasgdhwFPImvLPSm1kYnFy7OjlllPuvOP8VVuW Jv/ZLlwpw5YmDbv9ZJ4xbToen4mjpz7I5IGbhrmHmZxHNSyXAlxTJ5ah3tGmxPrXGQ1L QQJ75dIIuTQzW+6NZSOSFBa+HZiem2cLjKaN4sLMQ5PWyJ06u3y6NzGek3inqr4E29Ta JVsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706081840; x=1706686640; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oJnupBgFvOzDewfsN2fbqfoXAijS1cIjpRbgOobXJnE=; b=nvmD9HpEvQMF5YbnAkW0YDlxjhhH1WFvwRtVHQNFn6CgL0pWyoMdBe2Q+AQ00zAY6u P/zablFiKHqvNeGV8CGtvc5AJ+57QtOECb9yZAFZFY7SKzyGwq6+HE1fHBWU4oHymdb7 YyvA6ziu3NNVfLXLK1nO91GbwObni2KTNXOwyyKYZVMWFFl5ZhI9FloBuSgQ1QxRUDhn WWUKa3miPY9k2FaANNumeu69Pg2CIPoZ+5TKUjV8l3nmkheMSMEVm+cCnprRIG2NUSnr ZMrvXvtb0xnDpZhamkDQDoToUwViqkGqijiy/0UN0880UwA30ebhRYwSz/Lmd3HvySY6 56MA== X-Gm-Message-State: AOJu0Yz0IfGuF/PCPNL1ER3XhY/zaJ2le/AsJoKCxmQCMwmjv2IknTso 7IUg+qklXq1Z+GbwSuayyjdle87vq6HtmOsTfI5zyd5HlPtZwMqGb73zamZ/zA== X-Received: by 2002:a17:903:8d0:b0:1d5:f255:d386 with SMTP id lk16-20020a17090308d000b001d5f255d386mr363745plb.11.1706081840194; Tue, 23 Jan 2024 23:37:20 -0800 (PST) Received: from [127.0.1.1] ([117.217.189.109]) by smtp.gmail.com with ESMTPSA id t3-20020a170902b20300b001d726d9f591sm7386982plr.196.2024.01.23.23.37.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 23:37:19 -0800 (PST) From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Date: Wed, 24 Jan 2024 13:06:35 +0530 Subject: [PATCH 07/14] phy: qcom: qmp-pcie: Add a comment to clarify the use of "aux and "phy_aux" clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240124-pcie-aux-clk-fix-v1-7-d8a4852b6ba6@linaro.org> References: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> In-Reply-To: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> To: Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Vinod Koul <vkoul@kernel.org>, Kishon Vijay Abraham I <kishon@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1589; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=SMDJRGbt8Jv9ABIlOfDcm2JYxpzZQjqrX46K5L5t/xk=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlsL4Ey0uoNqHHYLtSpRKMWtRALxolVDEIjsBe1 zYzwB5mGOmJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbC+BAAKCRBVnxHm/pHO 9WzXCACg8RokdsMoSt1cI+uOd7qIPPW8HvoqXvRdXwF/FVdYRM+4YTHK6EJJElspwuRhLnphsdy I/+Z8lnLaKfuPLCXoircyEnF9PPdsGKbcCCII0YGpCWaSmLIkvRddCBfZvXKsN9gaegvATDg9Pe xA7iGWN9VVDOmdVyOJdadAtul4vlv3KrUW8QdLJL0vCouWa/OJx9m6CwnZ5A+iUMXO7gmWvgCrj WQsUUQfmlRWqZAmEkT1p8XoYs7Fwo5a7T8LDXcKSdbbkQTHNI0FbpTPq9IDoWqkqv/hGznNtaVb BKEJ7RfVUA3wOjPqCq86Shm4jUiYP6nbnLRDjXzXLdFxdPKZ X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788956608554402126 X-GMAIL-MSGID: 1788956608554402126 |
Series |
Drop PCIE_AUX_CLK from the PCIe PHY nodes of Qcom SoCs
|
|
Commit Message
Manivannan Sadhasivam
Jan. 24, 2024, 7:36 a.m. UTC
PCIe PHY hw on some SoCs require PCIE_PHY_AUX_CLK when the link enters L1SS
state. Historically, DTs of those SoCs passed this clock as "aux" clock.
But, SA8775P passed PCIE_PHY_AUX_CLK as "phy_aux" and PCIE_AUX_CLK as "aux"
mistakenly as the latter is not needed at all. Even though the SA8775P DT
got fixed, both of these clocks are kept here for backwards compatibility.
So add a comment to make it clear.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c index 9a220cbd9615..044e3c5ba341 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c @@ -2328,7 +2328,15 @@ static inline void qphy_clrbits(void __iomem *base, u32 offset, u32 val) readl(base + offset); } -/* list of clocks required by phy */ +/* list of clocks required by phy + * + * PCIe PHY hw on some SoCs require PCIE_PHY_AUX_CLK when the link enters L1SS + * state. Historically, DTs of those SoCs passed this clock as "aux" clock. But, + * SA8775P passed PCIE_PHY_AUX_CLK as "phy_aux" and PCIE_AUX_CLK as "aux" + * mistakenly as the latter is not needed at all. Even though the SA8775P DT got + * fixed, both of these clocks are kept here for backwards compatibility. + */ + static const char * const qmp_pciephy_clk_l[] = { "aux", "cfg_ahb", "ref", "refgen", "rchng", "phy_aux", };