Message ID | 20240123165831.970023-17-avromanov@salutedevices.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-35737-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2553:b0:103:945f:af90 with SMTP id p19csp490911dyi; Tue, 23 Jan 2024 09:32:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IEonspfsmZA/y/uwj7JdJW6HsChEWqFbIQkgT8euvlBT53eVoVkqe/RvNKInsg5xzvisTnf X-Received: by 2002:a05:6a00:240e:b0:6d9:be17:999 with SMTP id z14-20020a056a00240e00b006d9be170999mr3959561pfh.67.1706031124520; Tue, 23 Jan 2024 09:32:04 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706031124; cv=pass; d=google.com; s=arc-20160816; b=dvgD92jIfUDQJEL22p4Xoe1ypYg/lFE3qJ6Nrlyrez2devPjJiexiGfaoasHJo6vEa wxPXUrm4idVCyQT0x6imJW9h2KsycgMBEjYLCaKBQQfI8Yru2kdBQXkEDJ5dWqbG0cP1 FEwCRu7nDEpyCRJG6eExlm+SxXVtYl37yXpawleUnoRQ36pzvqQT9mTNcPcuLRHruGXH W5wMDEImZMqpR/jjaqgpcy2arGVo8khXKIbS9gK6Z8ZGkKGnbFTdGCmj2/GGXbX8wm05 eTD3dteRMK6tCPWX+cqv6SUVWiXnrwAIsjbtf8r08sES0oGt88b1n1dJr69gTdxz+2DM OLAA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature:dkim-filter; bh=aRWkZZe66hW5kxCXdPYRNigJUlN+4koWostk3jDjVfQ=; fh=sWLzCHBGAMV8YmCmzANlKtNZ6o4a+v+Uz9J5hgSC3iE=; b=utXg45xGk802Rn9t4k4/1D/di9xPNKFDiG1ljDBzQNaEm+EivhIJUJuG5bj6f7UNzP JAhexr0Zjpc9kzgugLGCQyMZqMtQk3+/bWfL9oVi6E6VlbFG+ViGjpef+rWwW+zBodHT S9xgEqL2lX5Q1SdXpzUr80gmfN2Ai+DS2DwvAG546h32k3TITV+Liq8ryuIaRqXxO5jd r2X3SwcGzma868+5mgOES4VW/7+wQs78M0ZgYdKcC5j92Grcz6xWJ5ce7gpjVAlLGwX3 40F9sCOiy1z5m4mEyoU7+IZtaCtJVdtt9hzGH3L7FNTXM+QUObiRgRj+bI+EtfNjNcDr dmiQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@salutedevices.com header.s=mail header.b=ZrYCBIdd; arc=pass (i=1 spf=pass spfdomain=salutedevices.com dkim=pass dkdomain=salutedevices.com dmarc=pass fromdomain=salutedevices.com); spf=pass (google.com: domain of linux-kernel+bounces-35737-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-35737-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=salutedevices.com Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id t7-20020a63eb07000000b005ce087e004dsi9917809pgh.799.2024.01.23.09.32.04 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 09:32:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-35737-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@salutedevices.com header.s=mail header.b=ZrYCBIdd; arc=pass (i=1 spf=pass spfdomain=salutedevices.com dkim=pass dkdomain=salutedevices.com dmarc=pass fromdomain=salutedevices.com); spf=pass (google.com: domain of linux-kernel+bounces-35737-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-35737-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=salutedevices.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id EFE7AB20C90 for <ouuuleilei@gmail.com>; Tue, 23 Jan 2024 17:05:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E2EA512A143; Tue, 23 Jan 2024 16:59:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=salutedevices.com header.i=@salutedevices.com header.b="ZrYCBIdd" Received: from mx1.sberdevices.ru (mx1.sberdevices.ru [37.18.73.165]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 892D686AD7; Tue, 23 Jan 2024 16:58:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=37.18.73.165 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706029139; cv=none; b=OW7MmWr7nuhwiR9onkjEn1wKJmZf8GLL3/NA/pglUcwvOq3QXrn68yU4S2P8oFYWMQ8bzBk7+pzP+wNjNxJCGptIS4IPz+nmP70uyXuurU3MH8L+ySO1jWfBYNJG1PNtgpT+FMelaKydNrcA/rtECRG/2plaP8FdzoQpmHeE078= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706029139; c=relaxed/simple; bh=I/OA1xdZqYmydQEXjMunKUa+5azQtbBZdB4cJ/B/q+Q=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=T3vzlXl4VL7ACaeLRUcrba02O0RBHzZgE7ZrxZkQAEyejMrWMJYEMBfOLR8lk2NGC3qOOyokvgrHdebXqMunkUhf7gLDW5/RpK2jrVyqDNym8O42yQnDZNay/FIUuYCBf4RYI+wPrRoYZgNjj/qbcTMYA56Z0lfz3J1H5MMbu3I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=salutedevices.com; spf=pass smtp.mailfrom=salutedevices.com; dkim=pass (2048-bit key) header.d=salutedevices.com header.i=@salutedevices.com header.b=ZrYCBIdd; arc=none smtp.client-ip=37.18.73.165 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=salutedevices.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=salutedevices.com Received: from p-infra-ksmg-sc-msk01 (localhost [127.0.0.1]) by mx1.sberdevices.ru (Postfix) with ESMTP id 18C0F100015; Tue, 23 Jan 2024 19:58:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru 18C0F100015 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=salutedevices.com; s=mail; t=1706029135; bh=aRWkZZe66hW5kxCXdPYRNigJUlN+4koWostk3jDjVfQ=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From; b=ZrYCBIddPx1iq+sxCpkgh1h+3X9NF+LlzHkMobdxEi8TzOyZlaDHE0YssXeHE8qfK quxTk0o1x79I6pECqbhpN3NUQ4mjugEVBx1DnR56RzbSgP2nAQPwupXfUZ+AsPU8uG n7Qp4ndW9kGJPDlYyrXKxqMpU/hWmbbknOrGg/WU1Aj/oumVBoDYjxbDEwLXnw/eLm sJHsf+UrVPFsSlqZgl9M8mAP5NckG5Z8mU4L5IK0BJvVK/YJgEyWK9N1mnWKyC2jVC Au4snff+lHfa8RomFqFwev36c7ejfzCDSIh0MpoxF7s6K8ElRq6a5DV2sRzUnbvZTr 68yz6NfcNJ1xA== Received: from smtp.sberdevices.ru (p-i-exch-sc-m01.sberdevices.ru [172.16.192.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sberdevices.ru (Postfix) with ESMTPS; Tue, 23 Jan 2024 19:58:54 +0300 (MSK) Received: from user-A520M-DS3H.sberdevices.ru (100.64.160.123) by p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Tue, 23 Jan 2024 19:58:54 +0300 From: Alexey Romanov <avromanov@salutedevices.com> To: <neil.armstrong@linaro.org>, <clabbe@baylibre.com>, <herbert@gondor.apana.org.au>, <davem@davemloft.net>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>, <khilman@baylibre.com>, <jbrunet@baylibre.com>, <martin.blumenstingl@googlemail.com> CC: <linux-crypto@vger.kernel.org>, <linux-amlogic@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <kernel@salutedevices.com>, Alexey Romanov <avromanov@salutedevices.com> Subject: [PATCH v2 16/20] dt-bindings: crypto: meson: add new compatibles Date: Tue, 23 Jan 2024 19:58:27 +0300 Message-ID: <20240123165831.970023-17-avromanov@salutedevices.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240123165831.970023-1-avromanov@salutedevices.com> References: <20240123165831.970023-1-avromanov@salutedevices.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) To p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) X-KSMG-Rule-ID: 10 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Lua-Profiles: 182873 [Jan 23 2024] X-KSMG-AntiSpam-Version: 6.1.0.3 X-KSMG-AntiSpam-Envelope-From: avromanov@salutedevices.com X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Info: LuaCore: 7 0.3.7 6d6bf5bd8eea7373134f756a2fd73e9456bb7d1a, {Tracking_from_domain_doesnt_match_to}, 100.64.160.123:7.1.2;127.0.0.199:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;smtp.sberdevices.ru:7.1.1,5.0.1;salutedevices.com:7.1.1, FromAlignment: s, ApMailHostAddress: 100.64.160.123 X-MS-Exchange-Organization-SCL: -1 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiPhishing: Clean X-KSMG-LinksScanning: Clean X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960, bases: 2024/01/23 13:53:00 #23383939 X-KSMG-AntiVirus-Status: Clean, skipped X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788903292729831988 X-GMAIL-MSGID: 1788903292729831988 |
Series |
Support more Amlogic SoC families in crypto driver
|
|
Commit Message
Alexey Romanov
Jan. 23, 2024, 4:58 p.m. UTC
Now we can use crypto driver at G12A/G12B/S4/A1/SM1/AXG.
Signed-off-by: Alexey Romanov <avromanov@salutedevices.com>
---
.../bindings/crypto/amlogic,gxl-crypto.yaml | 31 ++++++++++++++++---
1 file changed, 27 insertions(+), 4 deletions(-)
Comments
On Tue, 23 Jan 2024 19:58:27 +0300, Alexey Romanov wrote: > Now we can use crypto driver at G12A/G12B/S4/A1/SM1/AXG. > > Signed-off-by: Alexey Romanov <avromanov@salutedevices.com> > --- > .../bindings/crypto/amlogic,gxl-crypto.yaml | 31 ++++++++++++++++--- > 1 file changed, 27 insertions(+), 4 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.example.dtb: crypto-engine@c883e000: compatible: 'oneOf' conditional failed, one must be fixed: ['amlogic,gxl-crypto'] is too short 'amlogic,gxl-crypto' is not one of ['amlogic,g12a-crypto', 'amlogic,s4-crypto', 'amlogic,a1-crypto'] from schema $id: http://devicetree.org/schemas/crypto/amlogic,gxl-crypto.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240123165831.970023-17-avromanov@salutedevices.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 23/01/2024 17:58, Alexey Romanov wrote: > Now we can use crypto driver at G12A/G12B/S4/A1/SM1/AXG. > > Signed-off-by: Alexey Romanov <avromanov@salutedevices.com> > --- > .../bindings/crypto/amlogic,gxl-crypto.yaml | 31 ++++++++++++++++--- > 1 file changed, 27 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml b/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml > index 948e11ebe4ee..a7145b126a06 100644 > --- a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml > +++ b/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml > @@ -11,8 +11,15 @@ maintainers: > > properties: > compatible: > - items: > - - const: amlogic,gxl-crypto > + oneOf: > + - items: That's just enum. > + - enum: > + - amlogic,g12a-crypto > + - amlogic,s4-crypto > + - amlogic,a1-crypto > + - items: > + - const: amlogic,gxl-crypto > + - const: amlogic,axg-crypto This is neither explained nor correct. You just affected all DTS. > > reg: > maxItems: 1 > @@ -32,8 +39,24 @@ required: > - compatible > - reg > - interrupts > - - clocks > - - clock-names > + > +if: Missing allOf > + properties: > + compatible: > + contains: > + enum: > + - amlogic,gxl-crypto > +then: > + required: > + - clocks > + - clock-names Why? Also not explained. Entire patch was not tested and it unexpectedly affects/changes existing bindings without explanation in commit msg. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml b/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml index 948e11ebe4ee..a7145b126a06 100644 --- a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml +++ b/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml @@ -11,8 +11,15 @@ maintainers: properties: compatible: - items: - - const: amlogic,gxl-crypto + oneOf: + - items: + - enum: + - amlogic,g12a-crypto + - amlogic,s4-crypto + - amlogic,a1-crypto + - items: + - const: amlogic,gxl-crypto + - const: amlogic,axg-crypto reg: maxItems: 1 @@ -32,8 +39,24 @@ required: - compatible - reg - interrupts - - clocks - - clock-names + +if: + properties: + compatible: + contains: + enum: + - amlogic,gxl-crypto +then: + required: + - clocks + - clock-names + properties: + interrupts: + maxItems: 2 +else: + properties: + interrupts: + maxItems: 1 additionalProperties: false