From patchwork Tue Jan 23 06:17:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nylon Chen X-Patchwork-Id: 190726 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2553:b0:103:945f:af90 with SMTP id p19csp150435dyi; Mon, 22 Jan 2024 22:26:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IHNOgetuHygaMO+Nysz5JEt+l3Q8eLy+a9tWHqprzycB3c+a1DD+W04hadMRWkgQlf8PePI X-Received: by 2002:a19:5f4b:0:b0:50e:ab9b:c1d with SMTP id a11-20020a195f4b000000b0050eab9b0c1dmr1382576lfj.37.1705991192871; Mon, 22 Jan 2024 22:26:32 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705991192; cv=pass; d=google.com; s=arc-20160816; b=JgaQAkMFzq7fKeWm62YMSeBqkJQ8ZHyeqW/uEFIjK0jyqtR9Tl+K6sPd8CGdXECcQF /C7YtNHGg3d3RAD6HOl0eyYF/uU5aWFjwGohhy9M2NLrroUzP3JWOxYweLzCOvepqd7f +lkrgG/VattdwGjN6mM4/W52X/2vNLc69jWAGB1aVTJf4Tnfz2qQjBQp2WaOJI8uqa8F TJQlrlOdrA7avzpIeOtuy52uJurHhVJQo5ubqAf52OOkXeMYGMORmr25S6DUmi4IXBOG ATG7jE7Ka1nkpg3JQOTeVY69P48CyPBDT3b/lsXK0vnbtcq9EjiZeA4xNUZ2Op/4+iT9 p/GA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=nYo9wXWOZdh4xBQbuTEOxrcqZQMwofEU/9c/S0MDuwU=; fh=47CjjQUQloFpsdVYhLLUkNEWA6N2o9aDP0IqYdYBPnk=; b=Fvq04TDR9FMYWCf/nA68uI6rnJ/J1A/rVOF4IjDyOHhN930XI5JsIJ9SF6L3lRCBRu 8DV9m72UynG3Vn5BTqrV2cKjW2AkHD8ZZ6yAoe/fHpgtMokypLkfneI7GhsM3zxeXa28 usDc8/HvAOH+4Efpy3IW55BVHFjQQ0t7Zo+CfQxwER05WF1HR8nc47gMYbNYb92I7yPv 82DPPVZbZRxvHbcHPtkaCPELHkj76FgRdMtMY1h+/4tHtOwWpP8nHiC3Ah0zDgQNrrhT VrRmVJTf0QkmUh4Tjp8XZbxMmAzI7nwWD7R/LYTk8EOk9fThYyC2aRclIUomXspZUFNc fWHw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=Gx07QkKR; arc=pass (i=1 spf=pass spfdomain=sifive.com dkim=pass dkdomain=sifive.com dmarc=pass fromdomain=sifive.com); spf=pass (google.com: domain of linux-kernel+bounces-34765-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-34765-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=sifive.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id gs21-20020a170906f19500b00a3095588e20si887222ejb.804.2024.01.22.22.26.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 22:26:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-34765-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=Gx07QkKR; arc=pass (i=1 spf=pass spfdomain=sifive.com dkim=pass dkdomain=sifive.com dmarc=pass fromdomain=sifive.com); spf=pass (google.com: domain of linux-kernel+bounces-34765-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-34765-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=sifive.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 782CA1F22D17 for ; Tue, 23 Jan 2024 06:26:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9A3545466E; Tue, 23 Jan 2024 06:18:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="Gx07QkKR" Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4FDD53E21 for ; Tue, 23 Jan 2024 06:18:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705990689; cv=none; b=hhpX3PbvV6jMp6I3cMLLTB9pdSuK9YpCjY8azIx9VPQW29Swdl4TcjMspeU5c/wfwva6EFXfAEUNvv6AESUJ23tqnswGIDSpc5iJL84munufHBeQc3EJiasYE+USvTsYvo0KRzyj0l6M6ih/7eHxdaiEDzrhpZ3NFS+ogjAZq8g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705990689; c=relaxed/simple; bh=apn60oQs5B60ozKkNhLxgpW/v7Nd7OMtzE1ceBaZjWU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qgHyG7aNPOPBoqCuJWqVQ32T8C8Uns9Jojvaigr5Z1VzPoG0pJxvMLMYjHjqdD6Y8/GZc6JXjCCCAcaxSONXObREY6kmq5SFZOS3z0gGL64fuS1KPrIeiu1ZQDkhDVShyNuMgWnnsHRTNJ0C2G57HiarjnpNonp1BKRlVJtV0Wg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=Gx07QkKR; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1d71c844811so17514675ad.3 for ; Mon, 22 Jan 2024 22:18:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1705990687; x=1706595487; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nYo9wXWOZdh4xBQbuTEOxrcqZQMwofEU/9c/S0MDuwU=; b=Gx07QkKRumLLwy5aHCC5hu1QhH/Ct1ZNLcLPaXeEoTR3twwFffROiEiTfYnfVI87dr T379wkWKJyIClB5ZpyCL9hzI6sgT+liIEb2NEEpfWcJLLSXCxLnFNCzxzP676dGCp6IB 2JXfkPJr8cGcc46nub3Pd4GXWp+pRzTMXpuaNiEiOGpkiGjA/bgpBMHRyZK6KmxdQMBn gZh2DnItigv6aGbDELZiE8qtb66JPz87u9me2M2l/KGsHNkOusknS2hy7V3NHDMu0txj OLBVTfVRkVcbkmLZ7olgHK0E60oP/eX3bT3pT2LGB6SW4FhmF2FyF/XulI/VojHoFtPl vgCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705990687; x=1706595487; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nYo9wXWOZdh4xBQbuTEOxrcqZQMwofEU/9c/S0MDuwU=; b=BsCevPqdXaweRSFHak7IzcoUM0J3IWRkiUw9HDp1PIm7jYYUODv/2qQFkQ3+5wCdBP 892KWnRGD6GghQyeJgWh59+/o629njuQC+YlQMg+FfFdZeTvrqfSfoZ7tyVmXKyr9sTy yR8NULmhrhL/bfAntVeuQ5AvFf5N6ZRHQNqF+2UzTmB5XLXNdIclWG2g+v8almGGpYB0 jnd+1iclnjeo0YFx5X3uj2OIF6j+uK4nRhgu8AShGce0+SPXvUPksfg9upMqwPF52JKt eWcuO+ZK374nD2ZN1e8stFtv9GzNgazkB/oiz/wfhY7XX5WDvoClF6Kytyaf4akqim1j tqIA== X-Gm-Message-State: AOJu0YxPAzWq2xV5xYCyR3IIwBjkaQoAqrZcW1+C/Zy0HbossAdHVfBE d+ZY0ziqtN4xU8ydD55zNfTDzITZPC16geB8l1ROJ2If1Guma+pdHoSJlE9dJfk= X-Received: by 2002:a17:902:7897:b0:1d5:78db:4293 with SMTP id q23-20020a170902789700b001d578db4293mr3043550pll.29.1705990686972; Mon, 22 Jan 2024 22:18:06 -0800 (PST) Received: from hsinchu15.internal.sifive.com (59-124-168-89.hinet-ip.hinet.net. [59.124.168.89]) by smtp.gmail.com with ESMTPSA id p7-20020a170902b08700b001d733c88646sm4425376plr.216.2024.01.22.22.18.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 22:18:06 -0800 (PST) From: Nylon Chen To: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, conor@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, palmer@dabbelt.com, paul.walmsley@sifive.com, aou@eecs.berkeley.edu, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de Cc: vincent.chen@sifive.com, zong.li@sifve.com, nylon.chen@sifive.com, nylon7717@gmail.com Subject: [PATCH v7 3/3] pwm: sifive: Fix the error in the idempotent test within the pwm_apply_state_debug function Date: Tue, 23 Jan 2024 14:17:48 +0800 Message-ID: <20240123061748.8844-4-nylon.chen@sifive.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20240123061748.8844-1-nylon.chen@sifive.com> References: <20240123061748.8844-1-nylon.chen@sifive.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788861421212654298 X-GMAIL-MSGID: 1788861421212654298 Round the result to the nearest whole number. This ensures that real_period is always a reasonable integer that is not lower than the actual value. e.g. $ echo 110 > /sys/devices/platform/led-controller-1/leds/d12/brightness $ .apply is not idempotent (ena=1 pol=0 1739692/4032985) -> (ena=1 pol=0 1739630/4032985) Co-developed-by: Zong Li Signed-off-by: Zong Li Signed-off-by: Nylon Chen --- drivers/pwm/pwm-sifive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c index b07c8598bb21..7cf7a76cdb44 100644 --- a/drivers/pwm/pwm-sifive.c +++ b/drivers/pwm/pwm-sifive.c @@ -101,7 +101,7 @@ static void pwm_sifive_update_clock(struct pwm_sifive_ddata *ddata, /* As scale <= 15 the shift operation cannot overflow. */ num = (unsigned long long)NSEC_PER_SEC << (PWM_SIFIVE_CMPWIDTH + scale); - ddata->real_period = div64_ul(num, rate); + ddata->real_period = DIV_ROUND_UP_ULL(num, rate); dev_dbg(ddata->chip.dev, "New real_period = %u ns\n", ddata->real_period); }