From patchwork Tue Jan 23 00:06:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Rogers X-Patchwork-Id: 190543 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2553:b0:103:945f:af90 with SMTP id p19csp43208dyi; Mon, 22 Jan 2024 16:37:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IGyviDi1BzBFcoiB/kRiPVXpDFgen440DE0o3H0qvpKNdiklLsk8QEMuDnfddRxYYrcUVu0 X-Received: by 2002:a17:902:7047:b0:1d7:396a:2188 with SMTP id h7-20020a170902704700b001d7396a2188mr1773279plt.12.1705970228044; Mon, 22 Jan 2024 16:37:08 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705970228; cv=pass; d=google.com; s=arc-20160816; b=cm6bTVX4PDyaZtTwUDQ4/MsA/EaYvdS3QVLiEx2e5f+UFMDZnWRtsOlVGoSK4DVp5Y PDqCPcALTRnDWMiI1hVs7DBApbOrNbJ8K6x38zI+MDpAPJrjp3mFlSlZzANNQK4pIDUI gOjcWrkmMBmjPIMvi+mZC6QSJCiiXB4XQl3j2QAnhO4VPniZZJnQodQHFMohOWhZwBax l0K4lIS/cX1xYL7GTzTFVJ+iY8I3OOwzv0m67rrR8SPrbf6neNb2bBU38AvbsEw9CZhv +y1LxPIgov1CQKEim+U4jI8kx2wXx8o2KFGG9GwpI/UfQNgVPSzoQdH6DPQZCglk0vQ2 jqMA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=to:from:subject:references:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:in-reply-to:date :dkim-signature; bh=v3mpNhly1K/FvbNZbxoXHC3VDHfIYZfutn2fVhIXUKE=; fh=OSPvvrodhCXrbS0tgWY7ZQ1FjQjyOgKyIFsZYsPrQ8s=; b=kA6PVVIYwB+qtNhTGdHdkE2xvXSY6UhX8eHumtZlpvFWbXGAifBomI67OxAwMrAOoT Y+XFd4YisMJ588mgNS22sGRiSApxb4PhePrJQESIVzOX6wAcmNloMWhnBTPbxX9C/TYY b57RidyfOnilTYG1EK1MQ2YVB7SutTfpvX5gxXepBTrK6hvygfeETprrFahBN5dmsJba 3+r09tpVAIy4sxpucQB2T4Vv9mRsqoXGjhDruhadEcZL80RutgB7PjewfrjSGpUatkSV XzSfsmTXQqHbEOqTXvh794ThXrFPVOzzVdHGh+6es9Bwhk1qe/plHy6q8dbSZVPIYC/q 5sFA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b="pv40Lpp/"; arc=pass (i=1 spf=pass spfdomain=flex--irogers.bounces.google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-34436-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-34436-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id b12-20020a170903228c00b001d70c272ccesi8161864plh.409.2024.01.22.16.37.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 16:37:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-34436-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b="pv40Lpp/"; arc=pass (i=1 spf=pass spfdomain=flex--irogers.bounces.google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-34436-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-34436-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 7B7BA28A29D for ; Tue, 23 Jan 2024 00:27:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 16A5A146908; Tue, 23 Jan 2024 00:06:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="pv40Lpp/" Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14804145B30 for ; Tue, 23 Jan 2024 00:06:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705968376; cv=none; b=kQQpUFi417CKBx6uI0AdeEoz4Uk86TuVxk+QpCNC5LHsHOtwZXz/PcOklEGiSjpquYyhoES3ECk+nUmlTTpcU/bxdlAHO6rFeXjWQxvzVGW1ItGOI/Lu32hz0Ygkgmzn/8H5odarjgwZTJc4M5fe3wor685d5/NUC8+rCSuZ/Wo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705968376; c=relaxed/simple; bh=2Mcju2GLkOcjIP4VmHebW0u9y/4mznKlV2xvs1tiG0E=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=P0y/TGOh+hZB0NCh/L3A4iIXL/uHK0wCp8o9QucKOVlsPxN5K0ZYH8jXidWNK+OJiockrSFLkXmGRKNnW5XB4I/d1qOyi6/l7WO+9yMZlTO4U769zPRt7x1swnsGSKzbZ/X1k4UCeeDVvIGyrcB08AhS6k8Uxt0AnxU+v+iy3WQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=pv40Lpp/; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-5ff93902762so57691247b3.2 for ; Mon, 22 Jan 2024 16:06:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1705968374; x=1706573174; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=v3mpNhly1K/FvbNZbxoXHC3VDHfIYZfutn2fVhIXUKE=; b=pv40Lpp/n6yPN3Jz8ClUDW3t63AozyP4SRlbgC9zaXuXXJLf2XZvSs1BRiSRM3Aj8u s/exOBEDYj+40H/xlYV3PwZzoSdGTLlmPKKJ2Fkis4r1qUtQ/AtB2SQhB90VznqqE/Em NIR2VPswNSCQ/rKuhJpq7i/cXFlHamW9YJUXdBv1weHY9hh++yJEsPT/xrJxwHrbydT6 C45nTaq1UUNHF/M7qK7i1e43m4KtXuz9/2InR56vI0bxK0DpYJx/ipLvYFha97dF4dYC ZXlf8f9lZNaa+wg/qrcDOOCubN3EQe/ceuB6jNB9C0XaESgjnga/RN/JVyevbjOwKxj8 rOow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705968374; x=1706573174; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v3mpNhly1K/FvbNZbxoXHC3VDHfIYZfutn2fVhIXUKE=; b=njhszlAh6SAGGOcxZ0XFq87KJUbYrxrP3D5Fs8cgTUAGokPY2rlXPB1Za1NyAHbRR3 uQ1szkDLtcPEx9quolonI5GbBArSTmHYci76UBnZ/t1pGYsMDZh+KjMDxsyfI8Wsg6cD b6Uq2qCbP5ixgHgFm/YLIlm1DFxuDHviPDiFN8nDJeLjxSyQvJUA5oBVfPoZvZ2giCBL p1+0nNe7cVpxvYuKwMM5INEJpqK8Jl4YBgBUH9CnY1ULO0BcTFBjFoBzz5wFPDL1YBy/ 9hMGXX7teo+k9u/+lmxTY0bI8uO/lW+UL3h/j0AS8H4Z0hTX4fdE2cMB3xwt4axYjpqy 8ROA== X-Gm-Message-State: AOJu0YxQBjnciDuqqvhUejVpgYZZ0lH7CMwT8duVPIMu4gpS2iP/tiqz Te8hJOPZO221e2wc7uoYPhMqKLuTw+BIf2WAxCr4cbMIYq/zQY3061k3DBDvnIvr+ml71l8hhoO ncn3JHw== X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:6aba:f97a:4dc7:7e92]) (user=irogers job=sendgmr) by 2002:a81:4c88:0:b0:5d8:4274:bae2 with SMTP id z130-20020a814c88000000b005d84274bae2mr2333638ywa.6.1705968374141; Mon, 22 Jan 2024 16:06:14 -0800 (PST) Date: Mon, 22 Jan 2024 16:06:00 -0800 In-Reply-To: <20240123000604.1211486-1-irogers@google.com> Message-Id: <20240123000604.1211486-2-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240123000604.1211486-1-irogers@google.com> X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog Subject: [PATCH v1 1/5] perf list: Switch error message to pr_err From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Ravi Bangoria , Ross Zwisler , Athira Rajeev , Shirisha G , Kajol Jain , Kan Liang , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788839437939820930 X-GMAIL-MSGID: 1788839437939820930 Using printf can interrupt perf list output, use pr_err which can respect debug settings and the debug file. Signed-off-by: Ian Rogers --- tools/perf/util/print-events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/print-events.c b/tools/perf/util/print-events.c index b0fc48be623f..9e47712507cc 100644 --- a/tools/perf/util/print-events.c +++ b/tools/perf/util/print-events.c @@ -66,7 +66,7 @@ void print_tracepoint_events(const struct print_callbacks *print_cb __maybe_unus put_tracing_file(events_path); if (events_fd < 0) { - printf("Error: failed to open tracing events directory\n"); + pr_err("Error: failed to open tracing events directory\n"); return; }