From patchwork Tue Jan 23 19:13:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 191177 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2553:b0:103:945f:af90 with SMTP id p19csp569715dyi; Tue, 23 Jan 2024 11:50:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IEI4I41/x35CbMuta4bbbKbNFWs9IcZEtHlxrrSCuKd/mxIXa9XNkYuXq3Uz+cmaIl8NPq7 X-Received: by 2002:a05:6a20:4a30:b0:199:8389:5357 with SMTP id fr48-20020a056a204a3000b0019983895357mr6777367pzb.46.1706039446290; Tue, 23 Jan 2024 11:50:46 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706039446; cv=pass; d=google.com; s=arc-20160816; b=Jsz/RhK8l19krQJ204iwiuNz6meSBBYr4e/qyPAJDNQWbyGRLYDMunNjN1v61IAESt c5nGZlIaAIr9hAi/4ugEVFiIzahD1puWZKPThWZZGo8YqoiwJ1bXqV8vc9UcWEgVsWob sCxISwC6jSAWTRcqWu3X3gH9Z9Usr6ZisrV4J9dPIpeBhNPs7GoK8iUOctUIfF0H2Qf2 hcuOF2/XAQDmMqvHHeB6zGjHDTvFVK5kXWlTf9diXv+GyRjyJAddaPDR4aoHnjAfckrH d6HHeeCCQHiuEpTq32yc70/NYRK/d2RrbpY/CXHcZa3RtQO1269hbO7Z17VmADJe1eU7 dobA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:message-id:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:subject:date :from:dkim-signature; bh=JX1C39DLRiXRo9KmPAPcoOAD8i9NqnqwxEQEJ9FubBk=; fh=CXZE9uXh55auTVHaPa8q2uncacx44YUlOHX+UGf2vws=; b=jypeG8nnFRKaYzI2lvylNN9ZD3RXfNJC+oX6c3p5h+7O5wvJApsVNe2cjizFw1zU6Q t/J4KvWSGxtkRVWsgCx5X3Scu3jjsjnCFJoSxwZbshGC2dlTnEitSmWou0Ydh9h8EQk9 SAv8pPw7UpKHzSjVkFRaaSbV/df4loACA3iHDcJ8HYtOpx4lU08+fg5mLmy6D3am9ZKh YVfBh/iNaTlXQo/WkaMDcqSkLsXZnisHYL18P725kS8F+zoOQbUj7+/5uRTABjxbyYRP +uAAbZEarFCxXoyUE+d7oFKXyX4u3pKu0A+tK/bQm2OqHWq1MPqsvgSEtC4tff0wCSWJ wDmA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VbLRBQVR; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-35973-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-35973-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id u12-20020a63234c000000b005ce170df09esi10097011pgm.310.2024.01.23.11.50.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 11:50:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-35973-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VbLRBQVR; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-35973-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-35973-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 0FE19B2A00B for ; Tue, 23 Jan 2024 19:14:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0C9C982D67; Tue, 23 Jan 2024 19:14:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VbLRBQVR" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 856C0433D1 for ; Tue, 23 Jan 2024 19:14:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706037266; cv=none; b=O67+uN4M38kAGev9zik7IApOnCDL64e14pDy5eV0uDLmygof6cVZ/9opLTlBDEh94v/U7wGKGW9mqaNW7lJCHtsRUeAauY1I4CUu9/Nw6Sn7uc4QR5ZwyWCussMYjV9MFyDkqnj4IsGhATCdQWg031BGRduzZNQEkc5XEHisR1o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706037266; c=relaxed/simple; bh=XyTcwd8qXE/hKl/HKpN6+Q+TlUcZa83KF6IodAsDa/A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=rBDOOCA7H9mB6xOOlfkt14szrhpgLFGq7cX8qygg6WD8qKJve8TDTcVNQkiJ6sqD+Q1CRuoyjtIrj/PFpiEHUP5eP0B5n7baDZUNhS8UcPT4rusv+yjCy6LrUIGEepw4ymIkS/tUNLeXVL4VhpIE4KKKnh5xKHlENWbplYdGSeM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VbLRBQVR; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706037262; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JX1C39DLRiXRo9KmPAPcoOAD8i9NqnqwxEQEJ9FubBk=; b=VbLRBQVRUNuhy+io31f+AcFKsZLpKMtn070olk06CIfa6kILPZezn6GefJl3GAganqk7F+ z6zFZXCNMBdHlkjTHozXTZLCBufYWirZZnFV0G3S+v0/Mf1MKgO8LXtiYkPjrOXIL4httn LG3pM3qYwrdCOaJlhSgLZr12G2zAqbw= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-116-dnH6Br9WMjGTA0PRTRdUOQ-1; Tue, 23 Jan 2024 14:14:20 -0500 X-MC-Unique: dnH6Br9WMjGTA0PRTRdUOQ-1 Received: by mail-ua1-f69.google.com with SMTP id a1e0cc1a2514c-7d2f873493cso750698241.0 for ; Tue, 23 Jan 2024 11:14:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706037260; x=1706642060; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JX1C39DLRiXRo9KmPAPcoOAD8i9NqnqwxEQEJ9FubBk=; b=X6bXRB0Sl7kaPeQEqWnro7dLETX1yNU7Hfsxgzw1ne86lqp0TTCBMmqyQKeRZz+zS3 UD2+5nCteEqqiu8I3WI5cWlxtg5e7E75TYtYkGr2rAIMdgmJtzoDARpVnN2eMN5zsPZN C8dMUgKAgMsyzZevPsrgDRcqTCBifcPGP4KhG4MnNjAXFgFVjP76rYHNh+N9aI+kLDBb RLa9UJWuf+D4p8rKwSQ/K8lWaudLuTdjHfL/lQwoKHA2szZNLuvb+p4jh0UEMRmXLQF5 Go9oxUFJ9Je1Ab5HwoyLCv7S4y62pE4BAl+eRmd2NVw7G1+ZTx+65uXljO4/oDS2Fq6N qaPA== X-Gm-Message-State: AOJu0Yx3UOQMcRgLpgxXxO9N8ntpzXxAINxfqLz35YxySL8ORN1D5BtY IqS39fu9xJOy/iQWJ2XDXpHW28niGw1YqGZXVDXgwd2A3ZJk70vPznHKQg1oGalQfV8MnvMxfaj ZlhRqI34cJB1GGEzDCIZM9E/vTajq6+Tr0hX6vX+CpYZMeKRupYlsSUSjFcjhkw== X-Received: by 2002:a05:6102:504:b0:469:877d:fc1a with SMTP id l4-20020a056102050400b00469877dfc1amr3831539vsa.8.1706037260324; Tue, 23 Jan 2024 11:14:20 -0800 (PST) X-Received: by 2002:a05:6102:504:b0:469:877d:fc1a with SMTP id l4-20020a056102050400b00469877dfc1amr3831528vsa.8.1706037259988; Tue, 23 Jan 2024 11:14:19 -0800 (PST) Received: from [192.168.171.162] ([2600:380:6a3c:801d:216a:a904:5575:54a5]) by smtp.gmail.com with ESMTPSA id oh6-20020a056214438600b00685754458c9sm3616658qvb.115.2024.01.23.11.14.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 11:14:19 -0800 (PST) From: Andrew Halaney Date: Tue, 23 Jan 2024 13:13:36 -0600 Subject: [PATCH] scsi: ufs: qcom: Clarify comments about the initial phy_gear Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240123-ufs-reinit-comments-v1-1-ff2b3532d7fe@redhat.com> X-B4-Tracking: v=1; b=H4sIAN8PsGUC/x3MQQqAIBBA0avErBtQM4OuEi3ExppFFk5FEN09a fkW/z8glJkE+uqBTBcLb6lA1xWExaeZkKdiMMpYpU2DZxTMxIkPDNu6UjoEdRes9dEZ12oo5Z4 p8v1fh/F9P0uIne1lAAAA To: Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , echanude@redhat.com Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Halaney X-Mailer: b4 0.12.3 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788912018513518757 X-GMAIL-MSGID: 1788912018513518757 The comments that currently are within the hw_ver < 4 conditional are misleading. They really apply to various branches of the conditionals there and incorrectly state that the phy_gear value can increase. Right now the logic is to: * Default to max supported gear for phy_gear * Set phy_gear to minimum value if version < 4 since those versions only support one PHY init sequence (and therefore don't need reinit) * Set phy_gear to the optimal value if the device version is already populated in the controller registers on boot Let's move some of the comment to outside the if statement and clean up the bit left about switching to a higher gear on reinit. This way the comment more accurately reflects the logic. Signed-off-by: Andrew Halaney Reviewed-by: Manivannan Sadhasivam --- This is a minor comment cleanup inspired by my mistaken understanding of the flow over at [0] [0] https://lore.kernel.org/linux-arm-msm/20240123143615.GD19029@thinkpad/ --- drivers/ufs/host/ufs-qcom.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) --- base-commit: 319fbd8fc6d339e0a1c7b067eed870c518a13a02 change-id: 20240123-ufs-reinit-comments-17c44af62651 Best regards, diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index 39eef470f8fa..d9ec2dfbbda4 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -843,15 +843,20 @@ static void ufs_qcom_set_phy_gear(struct ufs_qcom_host *host) struct ufs_host_params *host_params = &host->host_params; u32 val, dev_major; + /* + * Default to powering up the PHY to the max gear possible, which is + * backwards compatible with lower gears but not optimal from + * a power usage point of view. After device negotiation, if the + * gear is lower a reinit will be performed to program the PHY + * to the ideal gear for this combo of controller and device. + */ host->phy_gear = host_params->hs_tx_gear; if (host->hw_ver.major < 0x4) { /* - * For controllers whose major HW version is < 4, power up the - * PHY using minimum supported gear (UFS_HS_G2). Switching to - * max gear will be performed during reinit if supported. - * For newer controllers, whose major HW version is >= 4, power - * up the PHY using max supported gear. + * These controllers only have one PHY init sequence, + * let's power up the PHY using that (the minimum supported + * gear, UFS_HS_G2). */ host->phy_gear = UFS_HS_G2; } else if (host->hw_ver.major >= 0x5) {