Message ID | 20240122225710.1952066-2-peter.griffin@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-34265-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2553:b0:103:945f:af90 with SMTP id p19csp1861dyi; Mon, 22 Jan 2024 14:58:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IEsG2hrk6F03Lua9Fbv0lFci39HLpBHp86W380tQihRIYgajY2Z998EY2kZuUrYV5L0Zi+3 X-Received: by 2002:a81:7185:0:b0:5e9:4f2d:2c51 with SMTP id m127-20020a817185000000b005e94f2d2c51mr2461625ywc.85.1705964294189; Mon, 22 Jan 2024 14:58:14 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705964294; cv=pass; d=google.com; s=arc-20160816; b=zo+A3lkxO/nqgITBYT1Y5xxlqE3yId9PgXSLWrnw/A9DZszwlymklueAEF87kjlFSR 4G0p0zkoP9dk4mFRV6btXX63G6JYWHmPgkbeSfP1EYdR+pGCQaX5wjTFpc9Zo054Wo2+ owOCUUHkOyswHc/lO9NKqqbPLrYgA995t/Z1PKV2yrJ7E8LPvYKPRw/kDLi5t+Gy/yTX TLAHw+lgXxpe2fdlOWTiGOEq2zAftVJYBr09vai0KXebBzspzIAb2S610qzbOxbXZsd+ osLBTWdKaYW9Xn56TnDNpVJmoKzHrfvJS/W88ai9lpO14NSMAGTJu/A3fNjsy3lmRt6K L9TA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=JBly9XkHZ0SVFvJINs6dkm8lumCZ4YgOwJi4aC1YyJM=; fh=u8/VSB5cpTPdWeoVxksi30G6E0YUOVbHMc21IacEKwc=; b=y1apKNjZ2I1DvnpwpcHvb+T90oTmcbPKqSwEXy+DA22KiccJSOhzSUBqUJuLdXnuQP RFkIJyTFwf/WQg8qhLTwy8Z4BntaXN2zGDXLrAadJTj6U75OWd0ncS3VoGtTS0QxBR04 lTaNFfX2dYQ9bdf2/of1ORAhJ6qHdtsaXh5flXdJ5K8nI7G1llZOQCFx9huST9cK6dp0 u78HwWYvI+aWFD/A2iancWydYIgMCqZKsaRytDLHKGYUP0pNCULEAVylNP1AfjWavXj6 88OWgKzgJRY4AvCT9236RlCfawrrVXMmaQt/j9jJZyiEar71o3k4+xKM9hduc7typ9pV hxTw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="U+rueY/u"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-34265-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-34265-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id j21-20020ac85f95000000b0042a4332eb23si2296175qta.324.2024.01.22.14.58.14 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 14:58:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-34265-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="U+rueY/u"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-34265-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-34265-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id D9F291C22DDA for <ouuuleilei@gmail.com>; Mon, 22 Jan 2024 22:58:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 24E9C36B0C; Mon, 22 Jan 2024 22:57:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="U+rueY/u" Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40D3B20B31 for <linux-kernel@vger.kernel.org>; Mon, 22 Jan 2024 22:57:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705964251; cv=none; b=RdCysxGF0A7AGMei7SCAwJqdLLlTBZAOIlglPwr41KT+iiB8EyERM450I9ohiHLJUeMGYr5nsZcKiUJGLZNxfIoOsruKPWAl+OLO6GgomjVAPy2B+/wkFFm/9j8xZ55fC9bSUuu/RsTqEC7pE1FNyrBIkxneOLNt5Hyrt/eudg0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705964251; c=relaxed/simple; bh=ADcQXaAoCN3feVEUxUAN7RPLnjxcu0Da4xFhPbbzd5Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IavL4oTFKI005d/MIG474m7SuhcS5fYVQ+Mgoyqgl81VwyZyUKcy4asdOKq2wa2v3zrBzcT9e2XBnPtEaT2HnLZ6cFc08gAsUNWBBFkhvJJgNx+FmMgBhwZCu9Hupe+rxyugVoWwQPvzRLbNeVdED0WfsLrVPR+pkyMWFjSULac= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=U+rueY/u; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-40e80046246so22043975e9.1 for <linux-kernel@vger.kernel.org>; Mon, 22 Jan 2024 14:57:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705964247; x=1706569047; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JBly9XkHZ0SVFvJINs6dkm8lumCZ4YgOwJi4aC1YyJM=; b=U+rueY/ums3yLa+tPEPHkPAH413XgjgrkNiM90wko/POsOVn897uZzu6UmuieY6ZNH moSQzOKLGVx8RFDIj9qzOvIU/GhNCPuhG9ZK6QJd8/SZn6rGl5Nj2/ciyDCZFdcO7e7C GHtCWLm66ybuQKe9Cpn/L0NaKRM6q8eWQhJsLR3a52i5Ppm7HzklHHM9sEGPAr42pamZ DCSWKBfVT+OGseYwtMR3mh1GYRl+tWUJs2tEIPeX85z3/RUDY/VzeTh/td3LW2tHH1tY bw8yTpAhQAOn9KedVyX1fWVYvP+8MR9Fhw6GN0TzJUGAZIzqatAHVK3aNI1XAPZTzjbc Zaww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705964247; x=1706569047; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JBly9XkHZ0SVFvJINs6dkm8lumCZ4YgOwJi4aC1YyJM=; b=o6xoUOioV486m+UcBzhKhjLgYfXgTEqH6i49yjJKXyOyHxwXjx24zt5pAHdIKZr/PQ Aekgs6dFrixsCk5KzntZMbfhhqRCe9YiK/vye0AXRprHNiHyta6ieLL2wyqQg22MlMJr iBv4781LTQj/2dsTrz1RwuBQDJ84/7gG0P0o0ekVClGR+sMElbLWKle0ClLjRNt4nN3J GVaP2/f7vnyCSTv9hfopHo4SPly48Q4Yf3RzokeRuwaHCqTUl1TfmfKGZYTpyxCDhxD4 UqdDD9qkmrPnEIXxbAWrJjLQhxa4pcb67+56fzlVGy0/OW970z2LprWyY2h4WBmg4Yp4 lUXQ== X-Gm-Message-State: AOJu0YxMinoFjP9yVscAmghWFiYv2PSPa61F/AkKXK4Th0v0mQLl2t7W lhlFkg3xryCDSGv+tufsnY+Z4XLe6MdiNXlkSo0uSOmu8rezgQXNv9Ox+fBB//A= X-Received: by 2002:a05:600c:45cc:b0:40e:a565:3ce2 with SMTP id s12-20020a05600c45cc00b0040ea5653ce2mr2204825wmo.73.1705964247305; Mon, 22 Jan 2024 14:57:27 -0800 (PST) Received: from gpeter-l.lan (host-92-18-76-30.as13285.net. [92.18.76.30]) by smtp.gmail.com with ESMTPSA id fa26-20020a05600c519a00b0040e89ff10f5sm19776847wmb.1.2024.01.22.14.57.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 14:57:26 -0800 (PST) From: Peter Griffin <peter.griffin@linaro.org> To: arnd@arndb.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux@roeck-us.net, wim@linux-watchdog.org, conor+dt@kernel.org, alim.akhtar@samsung.com, jaewon02.kim@samsung.com, chanho61.park@samsung.com, semen.protsenko@linaro.org Cc: kernel-team@android.com, peter.griffin@linaro.org, tudor.ambarus@linaro.org, andre.draszik@linaro.org, saravanak@google.com, willmcvicker@google.com, linux-fsd@tesla.com, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH 1/9] dt-bindings: watchdog: samsung-wdt: deprecate samsung,syscon-phandle Date: Mon, 22 Jan 2024 22:57:02 +0000 Message-ID: <20240122225710.1952066-2-peter.griffin@linaro.org> X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog In-Reply-To: <20240122225710.1952066-1-peter.griffin@linaro.org> References: <20240122225710.1952066-1-peter.griffin@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788833216113107600 X-GMAIL-MSGID: 1788833216113107600 |
Series |
Add exynos_pmu_update/read/write() APIs to exynos-pmu
|
|
Commit Message
Peter Griffin
Jan. 22, 2024, 10:57 p.m. UTC
The watchdog driver no longer requires a phandle to obtain a regmap
to the PMU registers. So mark this as deprecated.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
.../devicetree/bindings/watchdog/samsung-wdt.yaml | 15 +--------------
1 file changed, 1 insertion(+), 14 deletions(-)
Comments
On 22/01/2024 23:57, Peter Griffin wrote: > The watchdog driver no longer requires a phandle to obtain a regmap > to the PMU registers. So mark this as deprecated. > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > --- > .../devicetree/bindings/watchdog/samsung-wdt.yaml | 15 +-------------- > 1 file changed, 1 insertion(+), 14 deletions(-) > > diff --git a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml > index 77a5ddd0426e..3970d6bf8576 100644 > --- a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml > +++ b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml > @@ -56,6 +56,7 @@ properties: > description: > Phandle to the PMU system controller node (in case of Exynos5250, > Exynos5420, Exynos7, Exynos850 and gs101). > + deprecated: true I don't see how your driver handles probe or suspend ordering, so I don't think this is correct approach. Handling of the watchdog requires poking PMU, thus the watchdog device node must have reference to the PMU node. Removing it from DTS makes the hardware representation incomplete, beside mentioned driver issue. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml index 77a5ddd0426e..3970d6bf8576 100644 --- a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml +++ b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml @@ -56,6 +56,7 @@ properties: description: Phandle to the PMU system controller node (in case of Exynos5250, Exynos5420, Exynos7, Exynos850 and gs101). + deprecated: true required: - compatible @@ -66,20 +67,6 @@ required: allOf: - $ref: watchdog.yaml# - - if: - properties: - compatible: - contains: - enum: - - google,gs101-wdt - - samsung,exynos5250-wdt - - samsung,exynos5420-wdt - - samsung,exynos7-wdt - - samsung,exynos850-wdt - - samsung,exynosautov9-wdt - then: - required: - - samsung,syscon-phandle - if: properties: compatible: